Page MenuHomePhabricator

[S] Tablet: Improve the search layout and search preview widths on tablets
Closed, ResolvedPublic

Description

Problem

Mobile design is currently applied by default to all tablets except Apple tablets because Apple gives iPad a desktop user agent which overrides our redirects to mobile site on tablets. Also despite having the mobile skin applied to Android tablets and mobile, users can still switch to Desktop version. In both of those use cases, users will have a mediocre search preview experience as with current implementation the previews are rendered very narrow in an attempt to fit on smaller devices.

After several design iterations and discussions on amount of time required and feasibility, the following solution is being proposed.

Solution

Layout improvements

  • Make all the screens between 1440px and 720px that are not using mobile skin/view to have a different width distribution of column. For example currently it shows 8/12 of content, 1/12 whitespace, 3/12 interwiki results. This should be adjusted to: 7/12 of content, 1/12 whitespace, 4/12 interwiki results. This would allow more space for search previews and interwiki results.

Edited on 04/03

  • If the sidebar is closed ratio between 1440px and 1000px) should be 7/12 - 1/12 - 3/12 - 1/12 (same as when the screen is over 1440px)
  • If the sidebar is closed ratio between 720px and 1000px) should be 8/12 - 1/12 - 3/12
  • When Advanced search is enabled. Clicking it should close the search preview (currently clicking the advanced search does not close the search preview). Filed as T334498: Search Preview should be closed when Advanced search is clicked.
NOTE: we are not going to make any changes to the Y position of the search preview.
  • Previous discussion and current column widths captured in this ticket

[] Do not show the thumbnails for screens size at or below 720px (Currently the layout switches to 1 column below 720 so there is no need to hide the thumbnails)

Link to proposal in Figma

Tablet.png (1×1 px, 160 KB)

Event Timeline

Sneha updated the task description. (Show Details)
CBogen renamed this task from Tablet: Improve the search layout and search preview discovery on tablets to [S] Tablet: Improve the search layout and search preview discovery on tablets.Jan 11 2023, 5:56 PM
CBogen updated the task description. (Show Details)
Sneha renamed this task from [S] Tablet: Improve the search layout and search preview discovery on tablets to [S] Tablet: Improve the search layout and search preview widths on tablets.Mar 21 2023, 2:40 PM
Sneha updated the task description. (Show Details)
Sneha updated the task description. (Show Details)

Change 902054 had a related patch set uploaded (by Simone Cuomo; author: Simone Cuomo):

[mediawiki/extensions/SearchVue@master] Tablet: Improve the search layout and search preview widths on tablets

https://gerrit.wikimedia.org/r/902054

Change 902677 had a related patch set uploaded (by Simone Cuomo; author: Simone Cuomo):

[mediawiki/core@master] Tablet: Improve the search layout and search preview widths on tablets

https://gerrit.wikimedia.org/r/902677

Test wiki created on Patch demo by EGardner (WMF) using patch(es) linked to this task:
https://patchdemo.wmflabs.org/wikis/4e68216f56/w

Change 902677 merged by jenkins-bot:

[mediawiki/core@master] Tablet: Improve the search layout and search preview widths on tablets

https://gerrit.wikimedia.org/r/902677

Change 902054 merged by jenkins-bot:

[mediawiki/extensions/SearchVue@master] Tablet: Improve the search layout and search preview widths on tablets

https://gerrit.wikimedia.org/r/902054

Etonkovidova subscribed.

for @Sneha review - please let me know if some adjustments or additional testing are needed.
Checked betalabs (widths between 1440px and 720px) and compared with idwiki wmf.1
browser window size 1402px (Chrome)

idwiki wmf.1betalabs
div#mw-content-text.mw-body-content
Screen Shot 2023-03-28 at 1.54.16 PM.png (1×2 px, 437 KB)
Screen Shot 2023-03-28 at 2.10.30 PM.png (1×2 px, 490 KB)
div.mw-search-results-container
Screen Shot 2023-03-28 at 1.53.46 PM.png (1×2 px, 534 KB)
Screen Shot 2023-03-28 at 2.12.57 PM.png (1×2 px, 843 KB)
Screen Shot 2023-03-28 at 2.11.36 PM.png (1×2 px, 484 KB)
Screen Shot 2023-03-28 at 1.57.02 PM.png (1×2 px, 592 KB)
div.mw-search-quick-view.mw-app-view-desktop
Screen Shot 2023-03-28 at 2.16.06 PM.png (1×2 px, 820 KB)
Screen Shot 2023-03-28 at 1.56.25 PM.png (1×2 px, 685 KB)
div#mv-interwiki-results
Screen Shot 2023-03-28 at 1.54.45 PM.png (1×2 px, 559 KB)
Screen Shot 2023-03-28 at 2.18.53 PM.png (1×2 px, 394 KB)
div.iw-result_header
Screen Shot 2023-03-28 at 1.55.11 PM.png (1×2 px, 603 KB)
Screen Shot 2023-03-28 at 2.19.44 PM.png (1×2 px, 509 KB)

This is outside of the ticket scope - @Sneha please review in case there are some actionable adjustments. Basically, the desktop view is affected by those side menu switches.

Also checked the tablets for overall display with the new menu toggles:

  • the new UI allows a wider Quickview
  • the menu switch toggles have a moderate impact on the Quickview display
betalabscurrent production wmf.1
Screen Shot 2023-03-28 at 2.58.55 PM.png (1×1 px, 559 KB)
Screen Shot 2023-03-28 at 2.36.58 PM.png (1×1 px, 477 KB)
Screen Shot 2023-03-28 at 2.54.06 PM.png (1×1 px, 495 KB)
Screen Shot 2023-03-28 at 3.00.32 PM.png (1×1 px, 660 KB)
Screen Shot 2023-03-28 at 2.36.48 PM.png (1×1 px, 454 KB)
Screen Shot 2023-03-28 at 2.55.58 PM.png (1×1 px, 496 KB)

Thanks @Etonkovidova for screenshots. For the most part it looks good. There are two issues I am noticing:

  1. The sister project column had some white space on the right which is not in the new adjustments which I think we forgot to discuss. @SimoneThisDot some background on this can be found in this comment. The white space on the right in that column was there so that sister project column does not take too much space on the screen as the search result column is the primary content. I think we should still maintain that white space in the new column adjustments. The white space can be there until the column becomes as small as the size of the content (or we can define this), after that we don't need that white space. Does that makes sense? Below is the white space highlighted in yellow that I am referring to (which is lost in the new adjustment)
    search white space.png (938×1 px, 214 KB)
  1. @SimoneThisDot Are we able to adjust where the position of preview so that it does not overlap advance search widget. We did that for the footer and right now the preview will adjust its height to avoid the overlap on footer. Perhaps we can do the something similar for this case. Below is an example of it not overlapping the search widget. This preferred position happened accidentally for me while playing around on beta and I am not able to trigger it again.
    search preview.png (1×1 px, 1 MB)

hi @Sneha

  1. The right margin is just added for screens that are greater than 1440px wide and it was already there. The changes we made were from 720 to 1440px. Happy to change it, but I think on a large screen it is nice that there is some space.
  1. We can, but it will make the search preview super little. The example you pasted had a narrow width and super long height. Usually, the proportion would be different, and making the search preview start from below the advanced search would not provide much space. Also, one more point to remember is that if the focus would ever happens to be moved to the search widget, the search preview will cost, so it is not really affecting it usage. Happy to make the change, but I wanted to make sure you are aware of this. Attached is an iPad size example

image.png (698×1 px, 352 KB)

@SimoneThisDot

  1. I did not understand what you meant by this:

Happy to change it, but I think on a large screen it is nice that there is some space.

I think without that white space the second column is starting to look a bit wider and more primary than it should be. That white space is mostly required in the landscape screenshots that Elena posted above. The portrait ones are already too narrow for any space so we can leave those as is. I would also assume that adding white space would only affect the width of sister project content and not necessarily the preview width.

  1. Right now when you click on advanced search fields the preview does not close. It seems to only close when you interact with the options within the dropdown or the search input itself but not other elements of the widget. So perhaps we should fix that.

if the focus would ever happens to be moved to the search widget, the search preview will cost,

Also the tablet landscape example you shared I agree looks too small. Looks like this is the issue we cannot resolve without making a change with search widget design or position, as it may fix one scenario but may affect another.

Change 906535 had a related patch set uploaded (by Simone Cuomo; author: Simone Cuomo):

[mediawiki/skins/Vector@master] Special Search: Improve the search layout and search preview widths on tablets

https://gerrit.wikimedia.org/r/906535

Change 906535 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Special Search: Improve the search layout and search preview widths on tablets

https://gerrit.wikimedia.org/r/906535

@SimoneThisDot - was the following spec implemented?

  • When Advanced search is enabled. Clicking it should close the search preview (currently clicking the advanced search does not close the search preview).

Not yet, that acceptance criteria is in a different extension and not that straight forward to fix. Shall we split it into two tickets? They are completely unrelated coding-wise..

Not yet, that acceptance criteria is in a different extension and not that straight forward to fix. Shall we split it into two tickets? They are completely unrelated coding-wise..

Thx @SimoneThisDot, I agree - I filed it as as a separate task T334498: Search Preview should be closed when Advanced search is clicked.

Checked in wmf.4 - the width looks according to the specs. Figma places the quick search preview below the search controls

Tablet.png (1×1 px, 160 KB)

The current placement of the quick search preview for the first article doesn't match the figma mockup. The issue is not specific to tablets, so I filed it as T334704.

Test wiki on Patch demo by EGardner (WMF) using patch(es) linked to this task was deleted:

https://patchdemo.wmflabs.org/wikis/4e68216f56/w/