Page MenuHomePhabricator
Create Task
Maniphest T325388

Regression: Missing TOC scrollable indicator
Closed, ResolvedPublic3 Estimated Story Points
Actions

Description

Background

The scroll indicator fade at the bottom of the TOC is missing.
Introduced in https://gerrit.wikimedia.org/r/c/mediawiki/skins/Vector/+/859143

AC

  • Fix the scrollable indicator
  • Add Pixel test case to cover this

Details

SubjectRepoBranchLines +/-
Fix missing TOC scrollable indicatormediawiki/skins/Vectormaster+1 -1
Customize query in gerrit

Related Objects

Event Timeline

bwang created this task.Dec 16 2022, 7:37 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 16 2022, 7:37 PM
gerritbot added a comment.Dec 16 2022, 7:37 PM

Change 868457 had a related patch set uploaded (by Bernard Wang; author: Bernard Wang):

[mediawiki/skins/Vector@master] Fix missing TOC scrollable indicator

https://gerrit.wikimedia.org/r/868457

gerritbot added a project: Patch-For-Review.Dec 16 2022, 7:37 PM
bwang updated the task description. (Show Details)Dec 16 2022, 8:03 PM
Aklapper triaged this task as High priority.Dec 17 2022, 8:13 PM
Aklapper moved this task from Incoming to Current Fiscal Year on the Web-Team-Backlog board.
Aklapper moved this task from Incoming to Table of Contents on the Desktop Improvements (Vector 2022) board.
Aklapper merged a task: T324997: Make it obvious when the TOC is scrollable (i.e. there are sections out of view).
Aklapper added subscribers: Samwalton9-WMF, • alexhollender_WMF, Jdlrobson, ovasileva.
ovasileva edited projects, added Web-Team-Backlog (Kanbanana-2022-23-Q2); removed Web-Team-Backlog.Dec 19 2022, 6:13 PM
ovasileva moved this task from Needs Analysis to Code Review on the Web-Team-Backlog (Kanbanana-2022-23-Q2) board.
LGoto assigned this task to Jdrewniak.Dec 19 2022, 6:15 PM
LGoto reassigned this task from Jdrewniak to Mabualruz.
LGoto set the point value for this task to 3.
LGoto added a subscriber: Jdrewniak.
Mabualruz reassigned this task from Mabualruz to Edtadros.Dec 20 2022, 7:33 PM
Mabualruz moved this task from Code Review to QA on the Web-Team-Backlog (Kanbanana-2022-23-Q2) board.
Mabualruz subscribed.
gerritbot added a comment.Dec 20 2022, 9:49 PM

Change 868457 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Fix missing TOC scrollable indicator

https://gerrit.wikimedia.org/r/868457

ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.17; 2023-01-02).Dec 20 2022, 10:00 PM
Maintenance_bot removed a project: Patch-For-Review.Dec 20 2022, 10:30 PM
Edtadros moved this task from QA to QA in Prod on the Web-Team-Backlog (Kanbanana-2022-23-Q2) board.Jan 6 2023, 3:07 AM

Test Result - Beta

Status: ✅ PASS
Environment: beta
OS: macOS Ventura
Browser: Chrome
Device: MBP
Emulated Device:NA

Test Artifact(s):

QA Steps

✅ Fix the scrollable indicator

Screen Recording 2023-01-05 at 7.05.00 PM.mov.gif (478×922 px, 1 MB)

❓ Add Pixel test case to cover this
verify this with devs

Jdlrobson added a comment.Jan 6 2023, 5:26 PM

@bwang is it possible to get this covered by Pixel?

Edtadros reassigned this task from Edtadros to Jdlrobson.EditedJan 9 2023, 3:43 AM
Edtadros subscribed.

Test Result - Prod

Status: ❓
Environment: enwiki
OS: macOS Ventura
Browser: Chrome
Device: MBP
Emulated Device:NA

Test Artifact(s):

QA Steps

❓ Fix the scrollable indicator
@Jdlrobson, this doesn't behave the same as beta. In beta the scroll bar fades at the bottom, here it does not. I just want to be sure that Beta is the correct behavior.

Screen Recording 2023-01-08 at 7.40.11 PM.mov.gif (536×870 px, 1 MB)

⬜ Add Pixel test case to cover this
Not testable in prod

Jdlrobson reassigned this task from Jdlrobson to bwang.Jan 9 2023, 6:19 PM
bwang added a comment.Jan 9 2023, 6:37 PM

@Edtadros Beta and prod both seem to be working fine for me. @Jdlrobson Yes we should add a pixel case, I just havent gotten around to that yet. Maybe this should go to needs more work

bwang removed bwang as the assignee of this task.Jan 9 2023, 6:37 PM
bwang moved this task from QA in Prod to Needs More Work on the Web-Team-Backlog (Kanbanana-2022-23-Q2) board.
LGoto assigned this task to bwang.Jan 9 2023, 6:49 PM
LGoto edited projects, added Web-Team FY2022-23 Q3 Sprint 1; removed Web-Team-Backlog (Kanbanana-2022-23-Q2).Jan 9 2023, 10:21 PM
LGoto moved this task from Incoming to Needs More Work on the Web-Team FY2022-23 Q3 Sprint 1 board.
ovasileva lowered the priority of this task from High to Medium.Jan 11 2023, 5:42 PM
bwang moved this task from Needs More Work to Code Review on the Web-Team FY2022-23 Q3 Sprint 1 board.Jan 12 2023, 4:40 PM
bwang removed bwang as the assignee of this task.Jan 12 2023, 4:42 PM
bwang added a comment.Jan 12 2023, 4:52 PM

Pixel test case added in https://github.com/wikimedia/pixel/pull/155

• nray claimed this task.Jan 12 2023, 5:20 PM
Samwalton9-WMF unsubscribed.Jan 12 2023, 5:20 PM
• nray removed • nray as the assignee of this task.Jan 13 2023, 11:32 PM
• nray moved this task from Code Review to Ready for Signoff on the Web-Team FY2022-23 Q3 Sprint 1 board.
• nray subscribed.

I merged the pixel case today so I'm moving this to sign-off with the assumption that this has already been QA'd.

ovasileva closed this task as Resolved.Jan 13 2023, 11:46 PM
ovasileva claimed this task.

Looks good, signing off.

• alexhollender_WMF mentioned this in T326672: Vector 2022 Toc ::after fade positioned slightly over scroll bar..Jan 19 2023, 12:49 PM
Jdlrobson merged a task: T326672: Vector 2022 Toc ::after fade positioned slightly over scroll bar..Jan 25 2023, 6:36 PM
Jdlrobson added a subscriber: Terasail.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL