As per design ticket T325058
As an organiser
I want to be able to compose an email, with a subject line
And I want to be able to send the email to selected participants
And I want to know if the selected participants cannot receive the email
Description
Description
Details
Details
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | MHorsey-WMF | T325098 [EPIC] Event organizer can email participants | |||
| Resolved | MHorsey-WMF | T326413 Implement front end module for participant email, compatible with current tab layout | |||
| Resolved | MHorsey-WMF | T326619 Implement participant selection logic and interface | |||
| Duplicate | None | T326620 Implement Email editing interface (Plain Text?) |
Event Timeline
Comment Actions
Change 927191 had a related patch set uploaded (by Mhorsey; author: Mhorsey):
[mediawiki/extensions/CampaignEvents@master] Implement email sending interface
Comment Actions
Change 927191 had a related patch set uploaded (by Mhorsey; author: Mhorsey):
[mediawiki/extensions/CampaignEvents@master] Implement email sending interface
Comment Actions
Change 927191 merged by jenkins-bot:
[mediawiki/extensions/CampaignEvents@master] Implement email sending interface
Comment Actions
@MHorsey-WMF a few notes on this ticket.
For this AC
And I want to know if the selected participants cannot receive the email
In the comp there is a count of the participants who will not receive the email "4 of the selected participants...":
In the build instead of a number it says "Some of the selected participants ..."
Where it says Add recipients it should say Edit recipients, particularly when all participants have already been added. Should it say Add recipients only when no recipients have been added - thoughts @gonyeahialam?
comp:
build
There should be a line break here at the end of the first sentence:
comp:
build:
There should be an expandable View more / View less that should go under the ... selected participants do not have an email address on their account and won't receive your email notice.
comp:
build:
After an email is sent, the message box outline remains red like it would be if there were less than 10 characters in the email message. It should reset to gray after the email is sent:
Comment Actions
> Where it says Add recipients it should say Edit recipients, particularly when all participants have already been added. Should it say Add recipients only when no recipients have been added - thoughts @gonyeahialam?
comp:
build
Add recipients is for when there are no recipients, Edit recipient or Edit recipients is for when there is at least one recipient.
Comment Actions
For this AC
And I want to know if the selected participants cannot receive the emailIn the comp there is a count of the participants who will not receive the email "4 of the selected participants...":
Getting the number of participants is not possible because not all participants are loaded. @gonyeahialam I thought I had discussed this with you in the past, are you ok with this?
Where it says Add recipients it should say Edit recipients, particularly when all participants have already been added. Should it say Add recipients only when no recipients have been added
There should be a line break here at the end of the first sentence
After an email is sent, the message box outline remains red like it would be if there were less than 10 characters in the email message. It should reset to gray after the email is sent:
I will fix these
There should be an expandable View more / View less that should go under the ... selected participants do not have an email address on their account and won't receive your email notice.
I'm not sure what the intended behaviour for this is, @gonyeahialam can you advise? Given that we don't know all of the users, each time you click this we would have to do a lot of work in the background to search through the users and find ones that don't have an email address.
Comment Actions
@vaughnwalters @MHorsey-WMF What do the red usernames here refer to? Are we displaying all the usernames of the recipients in the UI?
Getting the number of participants is not possible because not all participants are loaded. @gonyeahialam I thought I had discussed this with you in the past, are you ok with this?
I'm not sure what the intended behavior for this is, @gonyeahialam can you advise? Given that we don't know all of the users, each time you click this we would have to do a lot of work in the background to search through the users and find ones that don't have an email address.
@MHorsey-WMF Since it is not possible, we can go with what we have in the build.
But how do we detect that some of the recipients have no email if we don't know them?
@vaughnwalters @MHorsey-WMF What do the red usernames here refer to? Are we displaying all the usernames of the recipients in the UI?
Comment Actions
how do we detect that some of the recipients have no email if we don't know them?
We only know of the ones that are loaded in the participants tab.
What do the red usernames here refer to? Are we displaying all the usernames of the recipients in the UI?
Yes, those are the selected users. They are red because they do not have user talk pages.
Comment Actions
Decided: “some participants…” all the time in the warning message.
Decided: remove section with usernames.
Decided: show number of participants instead of the usernames themselves
Decided: If one participant is selected show username
Comment Actions
Change 944928 had a related patch set uploaded (by Mhorsey; author: Mhorsey):
[mediawiki/extensions/CampaignEvents@master] Design corrections for email sending interface
Comment Actions
Change 944928 merged by jenkins-bot:
[mediawiki/extensions/CampaignEvents@master] Design corrections for email sending interface
Comment Actions
@MHorsey-WMF The following three UI items remain to be fixed (testing on betacluster currently). I can break these out into separate tasks if you prefer:
@MHorsey-WMF a few notes on this ticket.
Where it says Add recipients it should say Edit recipients, particularly when all participants have already been added. Should it say Add recipients only when no recipients have been added - thoughts @gonyeahialam?
comp:
build
If all participants have been added, there is a link to Add recipients, and this button should change to an Edit recipients button. From @gonyeahialam in T326413#9030715
Add recipients is for when there are no recipients, Edit recipient or Edit recipients is for when there is at least one recipient.
from betacluster:
There should be a line break here at the end of the first sentence:
comp:
build:
After an email is sent, the message box outline remains red like it would be if there were less than 10 characters in the email message. It should reset to gray after the email is sent:
Comment Actions
Where it says Add recipients it should say Edit recipients, particularly when all participants have already been added. Should it say Add recipients only when no recipients have been added - thoughts @gonyeahialam?
comp:
build
If all participants have been added, there is a link to Add recipients, and this button should change to an Edit recipients button. From @gonyeahialam in T326413#9030715
Add recipients is for when there are no recipients, Edit recipient or Edit recipients is for when there is at least one recipient.from betacluster:
Created followup ticket T346843
There should be a line break here at the end of the first sentence:
comp:
build:
Created follow up ticket T346839
After an email is sent, the message box outline remains red like it would be if there were less than 10 characters in the email message. It should reset to gray after the email is sent:
Created follow up ticket T346838
AC is met, and follow up tickets are created for UI issues, moving this to design sign off.
Comment Actions
Since separate tickets have been created for the changes, I am moving this to product sign-off.