Page MenuHomePhabricator
Create Task
Maniphest T326475

Next phan-taint-check-plugin release
Closed, ResolvedPublicRelease
Actions

Description

Would be nice to get rMTPSfc31270ae44a: Using ${var} in strings is deprecated, use {$var} instead out for PHP 8.2 support logspam (T326472: Use of "self" in callables is deprecated in php8.2 from wikimedia/php-cssjanus etc)

https://github.com/wikimedia/phan-taint-check-plugin/compare/4.0.0...master

rMTPS9f78bde95f87: [BREAKING CHANGE] Raise claimed PHP need from 7.2+ to 7.4+ suggests this will be 5.0.0

Any other changes we want to get shipped?

Details

Related Objects
Search...

Event Timeline

Reedy created this task.Jan 7 2023, 5:06 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 7 2023, 5:06 PM
Reedy added a subtask: T326476: Next mediawiki-phan-config release.Jan 7 2023, 5:11 PM
Reedy mentioned this in T326476: Next mediawiki-phan-config release.
Reedy renamed this task from phan-taint-check-plugin next release to Next phan-taint-check-plugin release.Jan 7 2023, 5:13 PM
Reedy removed a subtask: T326476: Next mediawiki-phan-config release.
Reedy added a parent task: T326476: Next mediawiki-phan-config release.
DLynch subscribed.Apr 7 2023, 5:13 PM

The default version of php installed by homebrew on macos seems to be 8.2 now, which suggests this would be useful to get out for local development.

Jdforrester-WMF subscribed.Apr 7 2023, 7:22 PM

We need a blocked-upstream-but-not-this-task-specifically tag, clearly. :-(

Daimona added a subtask: T325321: phan-taint-check-plugin depends on creation of dynamic properties which gets deprecated in php8.2.Apr 8 2023, 12:05 PM
Daimona added a comment.Jul 14 2023, 2:24 PM

I think we should just do this to unblock T324207. But the plugin will still emit deprecation warnings in PHP 8.2 due to T325321, for which I haven't heard anything upstream.

Daimona removed a subtask: T325321: phan-taint-check-plugin depends on creation of dynamic properties which gets deprecated in php8.2.Jul 14 2023, 2:24 PM
Daimona added a subtask: T325321: phan-taint-check-plugin depends on creation of dynamic properties which gets deprecated in php8.2.Jul 14 2023, 2:29 PM
In T326475#9015596, @Daimona wrote:

I think we should just do this to unblock T324207. But the plugin will still emit deprecation warnings in PHP 8.2 due to T325321, for which I haven't heard anything upstream.

... Or maybe not, given that the bug with array offsets is still present in phan 5.4.2.

Frostly changed the subtype of this task from "Task" to "Release".Oct 2 2023, 3:08 AM
Mainframe98 changed the status of subtask T325321: phan-taint-check-plugin depends on creation of dynamic properties which gets deprecated in php8.2 from Stalled to Open.Feb 8 2024, 8:06 PM
Jdforrester-WMF closed this task as Resolved.Feb 10 2024, 2:30 PM
Jdforrester-WMF claimed this task.
Jdforrester-WMF closed subtask T325321: phan-taint-check-plugin depends on creation of dynamic properties which gets deprecated in php8.2 as Resolved.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL