Page MenuHomePhabricator

Impact module: "Views on articles you've edited" total should use dailyTotalViews
Closed, ResolvedPublic

Description

Description

Currently in the new Impact module, the page views chart data comes from dailyTotalViews (sum of page view data for all articles edited by the user) while the number is topViewedArticlesCount (view totals for the 5 most-viewed articles only).

Ideally the number of page views is a total of all dailyTotalViews (since the user edited the article) within the 60 day time frame.

Acceptance Criteria
Given I'm viewing the new impact module,
When I have completed more than one edit,
Then the total "Views on articles you've edited" count reflects ALL articles I've edited in the last 60 days (not just the 5 top viewed articles).


Completion checklist

Functionality

  • The patches have been code reviewed and merged
  • The task passes its acceptance criteria

Engineering

  • There are existing and passing unit/integration tests
  • Tests for every involved patch should pass
  • Coverage for every involved project should have improved or stayed the same

Design & QA

  • If the task is UX/Design related: it must be reviewed and approved by the UX/Design team
  • Must be reviewed and approved by Quality Assurance.

Documentation

  • Related and updated documentation done where necessary

Event Timeline

Change 886355 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):

[schemas/event/secondary@master] homepagemodule: Document daily_total_views_count in action_data

https://gerrit.wikimedia.org/r/886355

Change 886356 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):

[mediawiki/extensions/GrowthExperiments@master] NewImpact: Make total views count reflect all edits, not just top viewed

https://gerrit.wikimedia.org/r/886356

It looks like in T310660: Impact module: Cumulative pageviews trendchart we didn't indicate what the source should be for "Views on articles you edited".

Change 886355 merged by jenkins-bot:

[schemas/event/secondary@master] homepagemodule: Document total_pageviews_count in action_data

https://gerrit.wikimedia.org/r/886355

Change 886356 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] NewImpact: Make total views count reflect all edits, not just top viewed

https://gerrit.wikimedia.org/r/886356

Checked on testwiki wmf.24 - works as expected per the AC:

"Views on articles you've edited" count reflects ALL articles I've edited in the last 60 days (not just the 5 top viewed articles).