Page MenuHomePhabricator

Impact module: Cumulative pageviews trendchart
Closed, ResolvedPublic

Description

Description

  • New cumulative pageview trendchart for the impact module that takes the full width of the card. Should be the same style as the spark line chart.
  • Styling and size will be the same for desktop and mobile versions
  • While this is a standalone element that will link to the corresponding pageviews page, ideally it should always be displayed with a description label.

Screenshot 2022-09-08 at 11.48.19.png (1×2 px, 192 KB)

Figma design.

Acceptance Criteria

Given I am viewing my impact module,
When I see "Views on articles you edited",
Then I also see a cumulative pageviews trendchart

Given I'm viewing my impact module,
When I click or tap on the cumulative pageviews trendchart section of the module,
Then I am linked to the corresponding pageviews page

Completion checklist

Functionality

  • The patches have been code reviewed and merged
  • The task passes its acceptance criteria

Engineering

  • There are existing and passing unit/integration tests
  • Tests for every involved patch should pass
  • Coverage for every involved project should have improved or stayed the same

Design & QA

  • If the task is UX/Design related: it must be reviewed and approved by the UX/Design team
  • Must be reviewed and approved by Quality Assurance.

Documentation

  • Related and updated documentation done where necessary

Event Timeline

Sgs added subscribers: KieranMcCann, Sgs.

We are building the underlying components to back this feature. I remember we discussed we'd like to make the sections user configurable (ie: a user that does not like to see the streak data can disable it). We're not aiming to provide such configuration to users on the first iteration of the feature but defining which UI blocks belong to each "section/category" would help creating future-proof code.

Screenshot 2022-09-29 at 13.54.32.png (1×1 px, 276 KB)

afaiu top level sections are: scorecards, recent activity, articles pageviews

Does the "trendchart" conceptually belong to the articles section, the recent activity or the it's a section on its own? cc @KieranMcCann @KStoller-WMF

Change 836842 had a related patch set uploaded (by Sergio Gimeno; author: Sergio Gimeno):

[mediawiki/extensions/GrowthExperiments@master] [WIP] User impact: create articles edited trend chart

https://gerrit.wikimedia.org/r/836842

Does the "trendchart" conceptually belong to the articles section, the recent activity or the it's a section on its own? cc @KieranMcCann @KStoller-WMF

@Sgs I would say it conceptually belongs in a section on its own. Any thoughts on that @KStoller-WMF?

It's my sense that the trendchart either fits with the articles section or on it's own...

I would say it conceptually belongs in a section on its own.

So that sounds fine with me.

Sgs changed the task status from Open to In Progress.Sep 30 2022, 4:50 PM
Sgs moved this task from In Progress to Code Review on the Growth-Team (Sprint 0 (Growth Team)) board.
kostajh triaged this task as Medium priority.Oct 14 2022, 12:48 PM

Change 843418 had a related patch set uploaded (by Sergio Gimeno; author: Sergio Gimeno):

[mediawiki/extensions/GrowthExperiments@master] User impact: toggle impact sections based in config

https://gerrit.wikimedia.org/r/843418

Change 843418 abandoned by Sergio Gimeno:

[mediawiki/extensions/GrowthExperiments@master] User impact: toggle impact sections based in config

Reason:

Work squashed in Id3aaf430f73aef7ce0de40bb493aea12c4fc8add

https://gerrit.wikimedia.org/r/843418

Change 850098 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):

[operations/mediawiki-config@master] [labs] GrowthExperiments: Use d3.js with new impact module

https://gerrit.wikimedia.org/r/850098

Change 836842 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] User impact: create articles edited trend chart

https://gerrit.wikimedia.org/r/836842

Change 850098 merged by jenkins-bot:

[operations/mediawiki-config@master] [labs] GrowthExperiments: Use d3.js with new impact module

https://gerrit.wikimedia.org/r/850098

Sgs changed the task status from In Progress to Open.Oct 30 2022, 10:04 PM
Sgs moved this task from Code Review to QA on the Growth-Team (Sprint 0 (Growth Team)) board.

Change 851613 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):

[mediawiki/extensions/GrowthExperiments@master] NewImpact: Add d3.js to package.json

https://gerrit.wikimedia.org/r/851613

Change 851613 abandoned by Kosta Harlan:

[mediawiki/extensions/GrowthExperiments@master] NewImpact: Add d3.js to package.json

Reason:

Let's go with If6f6caf84c33aee4d051cbf5d866b1610ce14b23 instead

https://gerrit.wikimedia.org/r/851613

Etonkovidova added subscribers: RHo, Etonkovidova.

For @RHo review - no issues found for the cumulative pageviews trendchart. If there is no follow-ups, you may move it to Test in Production.

DesktopMobile
Screen Shot 2022-11-28 at 3.08.40 PM.png (1×1 px, 151 KB)
Screen Shot 2022-11-28 at 1.39.00 PM.png (1×2 px, 673 KB)
Screen Shot 2022-11-28 at 2.13.19 PM.png (1×574 px, 97 KB)
Screen Shot 2022-11-28 at 3.16.46 PM.png (1×782 px, 133 KB)

Just to clarify - the cumulative trendchart is not a link; Most viewed (since you edit) section has links to individual articles' pageviews.

For @RHo review - no issues found for the cumulative pageviews trendchart. If there is no follow-ups, you may move it to Test in Production.

DesktopMobile
Screen Shot 2022-11-28 at 3.08.40 PM.png (1×1 px, 151 KB)
Screen Shot 2022-11-28 at 1.39.00 PM.png (1×2 px, 673 KB)
Screen Shot 2022-11-28 at 2.13.19 PM.png (1×574 px, 97 KB)
Screen Shot 2022-11-28 at 3.16.46 PM.png (1×782 px, 133 KB)

Great, thank you!

Just to clarify - the cumulative trendchart is not a link; Most viewed (since you edit) section has links to individual articles' pageviews.

Yes, I think that's fine, since there is the "view all edits" at the bottom of that section.