Page MenuHomePhabricator

Add new datatypes to Query Builder
Closed, ResolvedPublic8 Estimated Story Points

Description

As a Query Builder user I want to query more properties in order to have a more refined search.

Problem:
We have a limited set of supported datatypes so can not query for everything. We want to expand the range of datatypes we support.

Example:
We would like to expand the datatypes available on Query Builder that require values added via existing Wikit components i.e. "lookup".

This would include in prioritised order:

  • Lexeme
  • Form
  • Sense
  • Property
  • External ID
  • URL

Below is a table of datatypes and the corresponding WiKit components required for the value inputs.

Here's a list of which of the existing WiKit components could be used to input values for properties with unsupported data types.

Data typeWiKit componentFeasibility/ Observations
LexemeLookup
FormLookup
SenseLookup
PropertyLookup
External IDTextInput
URLInput component with type=URL?❌ Missing in WiKit

For URL we can also use TextInput like we will be using on External ID.

Screenshots/mockups:

BDD
GIVEN
AND
WHEN
AND
THEN
AND

Acceptance criteria:

  • These new datatypes are available on the Query Builder with their corresponding value input:
  • Lexeme
  • Form
  • Sense
  • Property
  • External ID
  • URL

Open questions:

Event Timeline

karapayneWMDE set the point value for this task to 8.Feb 7 2023, 10:03 AM

I think I might've copied these notes to a different task accidentally

Task Breakdown Notes

  • We currently offer limited support for the listed data types, once implementation is done, the limited support warning and MenuItem label [screenshot TBA] should no longer appear for these datatypes. (Other datatypes, like commonsMedia, will still have limited support.)
  • External identifier seems to work already
  • Support for senses only works through searching the sense ID, since that is all that wbsearchentities currently supports (once we support better search for senses in general, see T271500, it should also work in query builder)

Potential Plan of Action:

  1. Lexeme T329204
  2. In parallel:
  • In parallel we can also do the URL (however, it is lower prio) T329824
Arian_Bozorg claimed this task.

Thanks so much for your work on this!

All looking good on my end :)