Page MenuHomePhabricator

Sidebar parser broken in 1.18
Closed, ResolvedPublic

Description

See mediawiki.org: links to subpages are stripped of everything past the slash: Special:Code/MediaWiki|codereview results in a link just to Special:Code.


Version: 1.18.x
Severity: major

Details

Reference
bz31100

Related Objects

Event Timeline

bzimport raised the priority of this task from to Unbreak Now!.Nov 21 2014, 11:48 PM
bzimport set Reference to bz31100.
bzimport added a subscriber: Unknown Object (MLST).

Confirmed -- eww! Taking a peek...

Looks like a regression in r86255 -- changes to Title::fixSpecialName ended up discarding the parameter. Need to check for other similar changes...

Fixed in r97857 on trunk.

Merged to 1.18 and 1.18wmf1 in r97858, r97859.

  • Bug 31123 has been marked as a duplicate of this bug. ***

Created attachment 9095
Screenshot of mw.org with broken sidebar

REOPENING. Bug is still happening for some of the sidebar entries. They're not related to subpages of specialpages though. It's the interface / linktext.

MediaWiki is not fetching the message from NS_MEDIAWIKI as it should but splitting out raw message keys (which is the expected fallback)

Attached:

Screen_Shot_2011-09-24_at_9.05.52_PM.png (650×510 px, 113 KB)

(In reply to comment #5)

Created attachment 9095 [details]
Screenshot of mw.org with broken sidebar

REOPENING. Bug is still happening for some of the sidebar entries. They're not
related to subpages of specialpages though. It's the interface / linktext.

MediaWiki is not fetching the message from NS_MEDIAWIKI as it should but
splitting out raw message keys (which is the expected fallback)

Note (might be useful to whomever is fixing), it seems it does work correctly when you have a different language specified using uselang parameter. see my comment on bug 31123

Attached:

Screen_Shot_2011-09-24_at_9.05.52_PM.png (650×510 px, 113 KB)

Fixed on MW.org with a MessageCache->singleton()->clear() call in eval.php

Looks like Brion's fixes still need to be deployed.

(In reply to comment #8)

Looks like Brion's fixes still need to be deployed.

Pushed.

The thing with message keys is a separate bug, probably with no relation, and should be split out to another bug report to avoid confusion.

The special: parameter links were a specific actionable thing.

Brion filed a separate issue: bug 31177. There's a discussion underway on MediaWiki-General to diagnose this.

Clearing the message cache caused it to be fixed, not sure why or if it will happen again.