Page MenuHomePhabricator
Create Task
Maniphest T331078

Missing message string in watchlist due to contributions entry point work
Closed, ResolvedPublic2 Estimated Story PointsBUG REPORT
Actions

Assigned To
None
Authored By
eamedina
Mar 3 2023, 12:14 AM
Tags
Referenced Files
F37029169: Screenshot 2023-05-22 at 9.26.27 AM.png
May 22 2023, 4:29 PM
F36991667: Screenshot 2023-05-10 at 4.03.02 PM.png
May 10 2023, 11:23 PM
F36889489: image.png
Mar 3 2023, 12:14 AM
Subscribers
Aklapper
eamedina
Edtadros
Etonkovidova
Golightlys
Jdlrobson
Mabualruz
ovasileva

Description

Steps to replicate the issue (include links if applicable):

  • On mobile view, under settings, make sure the "Advanced mode" is turned off.
  • Navigate to Special:EditWatchlist

What happens?:
I can see the "special-tab-watchlist-short" key

image.png (882×742 px, 75 KB)

What should have happened instead?:
Actual message string

Software version (skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):

QA Results - Beta

ACStatusDetails
1✅T331078#8843466

QA Results - Prod

ACStatusDetails
1✅T331078#8871445

Details

Other Assignee
Jdlrobson
SubjectRepoBranchLines +/-
MobileFrontend: Watchlist better mobile experiencemediawiki/extensions/MobileFrontendmaster+28 -77
MobileFrontend: Watchlist better mobile experiencemediawiki/extensions/MobileFrontendmaster+20 -75
MobileFrontend: Missing message string in watchlistmediawiki/extensions/MobileFrontendmaster+6 -0
Missing message string in watchlist due to contributions entry point workmediawiki/coremaster+2 -0
Customize query in gerrit

Related Objects

Event Timeline

eamedina created this task.Mar 3 2023, 12:14 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 3 2023, 12:14 AM
Jdlrobson added a project: Web-Team-Backlog.Mar 3 2023, 7:27 PM
Jdlrobson subscribed.

Thanks for the report. I can replicate this on https://en.m.wikipedia.org/wiki/Special:EditWatchlist with AMC disabled. I suspect the issue here is that this page is extending the core class

Olga perhaps this is an opportunity to consolidate designs and drop those big buttons?

Jdlrobson renamed this task from Missing message string in watchlist to Missing message string in watchlist due to contributions entry point work.Mar 3 2023, 7:27 PM
Jdlrobson added a subscriber: ovasileva.
ovasileva triaged this task as Medium priority.Mar 6 2023, 10:29 PM
ovasileva moved this task from Incoming to Current Quarter on the Web-Team-Backlog board.
Golightlys subscribed.Mar 25 2023, 11:47 PM
Ammarpad merged a task: T333418: [mobile wmf.1] Special:Watchlist - ⧼special-tab-watchlist-short⧽ displayed instead of a tab title.Mar 29 2023, 7:27 AM
Ammarpad added a subscriber: Etonkovidova.
ovasileva moved this task from Current Quarter to Current Fiscal Year on the Web-Team-Backlog board.Apr 3 2023, 4:29 PM
Jdlrobson moved this task from Current Fiscal Year to Web Team FY2022-23 Q4 Sprint 2 on the Web-Team-Backlog board.Apr 10 2023, 10:00 PM
Jdlrobson edited projects, added Web-Team-Backlog (Web Team FY2022-23 Q4 Sprint 2); removed Web-Team-Backlog.
ovasileva moved this task from Web Team FY2022-23 Q4 Sprint 2 to Web Team FY2022-23 Q4 Sprint 3 on the Web-Team-Backlog board.Apr 18 2023, 8:33 PM
ovasileva edited projects, added Web-Team-Backlog (Web Team FY2022-23 Q4 Sprint 3); removed Web-Team-Backlog (Web Team FY2022-23 Q4 Sprint 2).
LGoto set the point value for this task to 2.Apr 27 2023, 5:25 PM
ovasileva moved this task from Incoming to Ready for Development on the Web-Team-Backlog (Web Team FY2022-23 Q4 Sprint 3) board.May 8 2023, 2:22 PM
Mabualruz claimed this task.May 9 2023, 10:38 AM
Mabualruz moved this task from Ready for Development to Doing on the Web-Team-Backlog (Web Team FY2022-23 Q4 Sprint 3) board.
Mabualruz added a comment.May 9 2023, 11:26 AM
  • Desktop Pages all go through SpecialWatchlist class and uses the 'watchlisttools-view' message is always used as it is assigned in the override function of the page.
  • Mobile page "Special:Watchlist" uses SpecialMobileWatchlist for watch list there is no override for the getShortDescription function to use the key mentioned. ( SpecialMobileWatchlist is deprecated and waiting for removal )
  • All other tabs on mobile go through SpecialWatchlist class

we can override the function in SpecialMobileWatchlist but since it is deprecated I will add the message key for now so there is no development on a deprecated class.

gerritbot added a comment.May 9 2023, 11:27 AM

Change 917860 had a related patch set uploaded (by Mabualruz; author: Mabualruz):

[mediawiki/core@master] Missing message string in watchlist due to contributions entry point work

https://gerrit.wikimedia.org/r/917860

gerritbot added a project: Patch-For-Review.May 9 2023, 11:27 AM
Mabualruz moved this task from Doing to Code Review on the Web-Team-Backlog (Web Team FY2022-23 Q4 Sprint 3) board.May 9 2023, 11:28 AM
Jdlrobson moved this task from Code Review to Needs More Work on the Web-Team-Backlog (Web Team FY2022-23 Q4 Sprint 3) board.May 9 2023, 4:35 PM
gerritbot added a comment.May 10 2023, 10:17 AM

Change 917860 abandoned by Mabualruz:

[mediawiki/core@master] Missing message string in watchlist due to contributions entry point work

Reason:

https://gerrit.wikimedia.org/r/917860

gerritbot added a comment.May 10 2023, 10:20 AM

Change 918422 had a related patch set uploaded (by Mabualruz; author: Mabualruz):

[mediawiki/extensions/MobileFrontend@master] Missing message string in watchlist due to contributions entry point work

https://gerrit.wikimedia.org/r/918422

Mabualruz moved this task from Needs More Work to Code Review on the Web-Team-Backlog (Web Team FY2022-23 Q4 Sprint 3) board.May 10 2023, 10:21 AM
gerritbot added a comment.May 10 2023, 4:01 PM

Change 918422 merged by jenkins-bot:

[mediawiki/extensions/MobileFrontend@master] MobileFrontend: Missing message string in watchlist

https://gerrit.wikimedia.org/r/918422

Maintenance_bot removed a project: Patch-For-Review.May 10 2023, 4:10 PM
gerritbot added a comment.May 10 2023, 4:16 PM

Change 918524 had a related patch set uploaded (by Mabualruz; author: Mabualruz):

[mediawiki/extensions/MobileFrontend@master] MobileFrontend: Watchlist better mobile experience

https://gerrit.wikimedia.org/r/918524

gerritbot added a project: Patch-For-Review.May 10 2023, 4:16 PM
gerritbot added a comment.May 10 2023, 5:02 PM

Change 918571 had a related patch set uploaded (by Mabualruz; author: Mabualruz):

[mediawiki/extensions/MobileFrontend@master] MobileFrontend: Watchlist better mobile experience

https://gerrit.wikimedia.org/r/918571

gerritbot added a comment.May 10 2023, 5:02 PM

Change 918571 abandoned by Mabualruz:

[mediawiki/extensions/MobileFrontend@master] MobileFrontend: Watchlist better mobile experience

Reason:

https://gerrit.wikimedia.org/r/918571

Jdlrobson updated Other Assignee, added: Jdlrobson.May 10 2023, 5:42 PM
gerritbot added a comment.May 10 2023, 9:01 PM

Change 918524 merged by jenkins-bot:

[mediawiki/extensions/MobileFrontend@master] MobileFrontend: Watchlist better mobile experience

https://gerrit.wikimedia.org/r/918524

Maintenance_bot removed a project: Patch-For-Review.May 10 2023, 9:10 PM
Jdlrobson reassigned this task from Mabualruz to Edtadros.May 10 2023, 9:24 PM
Jdlrobson moved this task from Code Review to QA on the Web-Team-Backlog (Web Team FY2022-23 Q4 Sprint 3) board.
Jdlrobson added a subscriber: Mabualruz.
Edtadros moved this task from QA to Ready for Signoff on the Web-Team-Backlog (Web Team FY2022-23 Q4 Sprint 3) board.May 10 2023, 11:23 PM

Test Result - Beta

Status: ✅ PASS
Environment: beta
OS: macOS Ventura
Browser: Chrome
Device: MBP
Emulated Device:NA

Test Artifact(s):

QA Steps

On mobile view, under settings, make sure the "Advanced mode" is turned off.
Navigate to Special:EditWatchlist
✅ AC1: Message string should show

Screenshot 2023-05-10 at 4.03.02 PM.png (847×389 px, 78 KB)

Jdlrobson claimed this task.May 15 2023, 5:15 PM
Jdlrobson added a subscriber: Edtadros.
Jdlrobson moved this task from Ready for Signoff to QA in Production on the Web-Team-Backlog (Web Team FY2022-23 Q4 Sprint 3) board.May 16 2023, 4:33 PM

Still need to verify this one in production but looks good.

ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.10; 2023-05-23).May 16 2023, 6:01 PM
Jdlrobson reassigned this task from Jdlrobson to Edtadros.May 16 2023, 10:09 PM
Edtadros closed this task as Resolved.May 22 2023, 4:29 PM
Edtadros removed Edtadros as the assignee of this task.

Test Result - Prod

Status: ✅ PASS
Environment: enwiki
OS: macOS Ventura
Browser: Chrome
Device: MBP
Emulated Device:NA

Test Artifact(s):

QA Steps

On mobile view, under settings, make sure the "Advanced mode" is turned off.
Navigate to Special:EditWatchlist
✅ AC1: Message string should show

Screenshot 2023-05-22 at 9.26.27 AM.png (847×390 px, 80 KB)

Edtadros updated the task description. (Show Details)May 22 2023, 4:32 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL