Page MenuHomePhabricator
Create Task
Maniphest T332120

Replace deprecated WikimediaUI Base aliases with current Codex design tokens
Closed, ResolvedPublic
Actions

Description

Background

Initiated in T330694: tokens: Split out deprecated tokens into separate file, Codex v0.7.0 removes deprecated WikimediaUI Base aliases.

Goal

Replace deprecated tokens with current Codex design tokens. The tokens and their replacement keys can be found at 'deprecated-aliases-wikimedia-ui-base.json'.
This aims at making developer experience with Codex tokens simpler.

For example https://codesearch-beta.wmcloud.org/search/?q=background-color-framed&files=&excludeFiles=&repos=

Acceptance criteria for done

Details

SubjectRepoBranchLines +/-
Revert "termbox: update to 2024-01-22-163619-production"operations/deployment-chartsmaster+1 -1
termbox: update to 2024-01-22-163619-productionoperations/deployment-chartsmaster+1 -1
termbox(test): update to 2024-01-22-163619-productionoperations/deployment-chartsmaster+1 -1
Update OOUI to v0.48.3mediawiki/coremaster+1 K -1 K
Replace WikimediaUI Base with Codex design tokenswikibase/termboxmaster+107 -1 K
CX3 Build 0.2.0+20231124mediawiki/extensions/ContentTranslationmaster+3 K -3 K
themes: Replace `background-color-*` variables with category tokensoojs/uimaster+131 -137
WikimediaUI theme: Replace `box-shadow-*` variables with category tokensoojs/uimaster+33 -41
themes: Replace `border-*` variables with category tokensoojs/uimaster+109 -127
themes: Replace `opacity-*` variables with category tokensoojs/uimaster+21 -32
Replace WikimediaUI Base with Codex design tokensmediawiki/extensions/ContentTranslationmaster+296 -309
themes: Replace `color-*` variables with category tokensoojs/uimaster+111 -120
styles, themes: Replace deprecated `size-*` varsoojs/uimaster+134 -119
styles, themes: Replace deprecated `@min-size-*` varsoojs/uimaster+33 -27
styles: Replace WikimediaUI Base with Codex Design Tokenswikidata/query/guimaster+138 -211
build, styles: Replace WikimediaUI Base vars with Codex design tokenswikimedia/portalsmaster+125 -123
Merging from fe3c2c8f0376b952e02c58977ad17dc6ec8ac15cwikidata/query/gui-deployproduction+7 -7
styles, build: Remove WikimediaUI Base dependency and use Codex tokensmediawiki/extensions/WikibaseMediaInfomaster+38 -139
styles, build: Remove WikimediaUI Base dependency and use Codex tokensmediawiki/extensions/MediaSearchmaster+205 -538
styles: Replace deprecated WikimediaUI Base aliases with Codex tokensmediawiki/extensions/GrowthExperimentsmaster+24 -24
Show related patches Customize query in gerrit

Related Objects
Search...

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes
gerritbot added a comment.Mar 15 2023, 11:43 AM

Change 899517 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] styles: Replace deprecated WikimediaUI Base aliases with Codex tokens

https://gerrit.wikimedia.org/r/899517

Volker_E mentioned this in T330694: tokens: Split out deprecated tokens into separate file.Mar 15 2023, 11:56 AM
ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.1; 2023-03-20).Mar 15 2023, 12:00 PM
Maintenance_bot removed a project: Patch-For-Review.Mar 15 2023, 12:10 PM
Volker_E updated the task description. (Show Details)Mar 15 2023, 1:18 PM
kostajh moved this task from Inbox to Triaged on the Growth-Team board.Mar 16 2023, 11:11 AM
ldelench_wmf moved this task from Inbox to Backlog on the Design-System-Team board.Mar 20 2023, 6:56 PM
kostajh subscribed.Mar 24 2023, 12:07 PM

@Volker_E Can we close this task?

Volker_E updated the task description. (Show Details)Apr 27 2023, 12:12 PM
Volker_E added a parent task: T334934: [EPIC] Replace WikimediaUI Base variables with Codex design tokens (mediawiki.skin.variables).Apr 28 2023, 9:53 AM
gerritbot added a comment.May 11 2023, 4:52 AM

Change 918626 had a related patch set uploaded (by VolkerE; author: VolkerE):

[mediawiki/extensions/MediaSearch@master] styles, build: Remove WikimediaUI Base dependency and use Codex tokens

https://gerrit.wikimedia.org/r/918626

gerritbot added a project: Patch-For-Review.May 11 2023, 4:52 AM
Volker_E updated the task description. (Show Details)May 11 2023, 5:04 AM
Volker_E added a comment.May 11 2023, 5:27 AM
In T332120#8724327, @kostajh wrote:

@Volker_E Can we close this task?

Sadly there's quite some more. Haven't had time to put all projects here as I did with the other tasks. Growth's part is resolved!

ldelench_wmf set the point value for this task to 3.May 15 2023, 4:47 PM
ldelench_wmf assigned this task to egardner.May 15 2023, 4:50 PM
ldelench_wmf edited projects, added Design-System-Team (Design-System-Sprint); removed Design-System-Team.
Restricted Application triaged this task as High priority. · View Herald TranscriptMay 15 2023, 4:50 PM
egardner moved this task from Committed to Code Review on the Design-System-Team (Design-System-Sprint) board.May 15 2023, 4:51 PM
gerritbot added a comment.May 17 2023, 8:12 AM

Change 918626 merged by jenkins-bot:

[mediawiki/extensions/MediaSearch@master] styles, build: Remove WikimediaUI Base dependency and use Codex tokens

https://gerrit.wikimedia.org/r/918626

Maintenance_bot removed a project: Patch-For-Review.May 17 2023, 8:30 AM
Volker_E updated the task description. (Show Details)May 17 2023, 4:55 PM
Volker_E updated the task description. (Show Details)May 18 2023, 8:06 PM
Volker_E edited projects, added Design-System-Team; removed Design-System-Team (Design-System-Sprint).May 18 2023, 8:12 PM

Taking this off our sprint board, the rest will be tackled less urgently (Growth and MediaSearch were the two most urgent ones, former for it interweaving also mediawiki.ui vars, latter for prepping to transform the whole interface to Codex).

gerritbot added a comment.Oct 20 2023, 12:42 AM

Change 967325 had a related patch set uploaded (by VolkerE; author: VolkerE):

[mediawiki/extensions/WikibaseMediaInfo@master] styles, build: Remove WikimediaUI Base dependency and use Codex tokens

https://gerrit.wikimedia.org/r/967325

gerritbot added a project: Patch-For-Review.Oct 20 2023, 12:42 AM
gerritbot added a comment.Oct 26 2023, 8:54 AM

Change 967325 merged by jenkins-bot:

[mediawiki/extensions/WikibaseMediaInfo@master] styles, build: Remove WikimediaUI Base dependency and use Codex tokens

https://gerrit.wikimedia.org/r/967325

Maintenance_bot removed a project: Patch-For-Review.Oct 26 2023, 9:11 AM
Volker_E updated the task description. (Show Details)Oct 26 2023, 4:14 PM
Volker_E claimed this task.Oct 26 2023, 8:47 PM
Volker_E added a subscriber: egardner.
gerritbot added a comment.Oct 26 2023, 11:35 PM

Change 969215 had a related patch set uploaded (by VolkerE; author: VolkerE):

[wikidata/query/gui@master] styles: Replace WikimediaUI Base with Codex Design Tokens

https://gerrit.wikimedia.org/r/969215

gerritbot added a project: Patch-For-Review.Oct 26 2023, 11:35 PM
Volker_E updated the task description. (Show Details)Oct 26 2023, 11:39 PM
Volker_E added a project: Language-Team.
Volker_E added a subscriber: CCiufo-WMF.
gerritbot added a comment.Oct 27 2023, 6:27 AM

Change 969232 had a related patch set uploaded (by VolkerE; author: VolkerE):

[mediawiki/extensions/ContentTranslation@master] Replace WikimediaUI Base with Codex design tokens

https://gerrit.wikimedia.org/r/969232

gerritbot added a comment.Oct 27 2023, 10:28 AM

Change 969311 had a related patch set uploaded (by VolkerE; author: VolkerE):

[wikimedia/portals@master] build, styles: Replace WikimediaUI Base vars with Codex design tokens

https://gerrit.wikimedia.org/r/969311

Volker_E updated the task description. (Show Details)Oct 27 2023, 10:28 AM
gerritbot added a comment.Oct 30 2023, 11:43 AM

Change 969215 merged by jenkins-bot:

[wikidata/query/gui@master] styles: Replace WikimediaUI Base with Codex Design Tokens

https://gerrit.wikimedia.org/r/969215

gerritbot added a comment.Oct 30 2023, 11:51 AM

Change 969707 had a related patch set uploaded (by WDQSGuiBuilder; author: WDQSGuiBuilder):

[wikidata/query/gui-deploy@production] Merging from fe3c2c8f0376b952e02c58977ad17dc6ec8ac15c

https://gerrit.wikimedia.org/r/969707

gerritbot added a comment.Oct 30 2023, 12:21 PM

Change 969707 merged by Lucas Werkmeister (WMDE):

[wikidata/query/gui-deploy@production] Merging from fe3c2c8f0376b952e02c58977ad17dc6ec8ac15c

https://gerrit.wikimedia.org/r/969707

gerritbot added a comment.Oct 30 2023, 2:42 PM

Change 969311 merged by jenkins-bot:

[wikimedia/portals@master] build, styles: Replace WikimediaUI Base vars with Codex design tokens

https://gerrit.wikimedia.org/r/969311

Volker_E updated the task description. (Show Details)Oct 30 2023, 4:37 PM
Volker_E removed the point value for this task.Oct 30 2023, 4:42 PM
gerritbot added a comment.Nov 1 2023, 11:31 PM

Change 970878 had a related patch set uploaded (by VolkerE; author: VolkerE):

[oojs/ui@master] styles, themes: Replace deprecated `@min-size-*` vars

https://gerrit.wikimedia.org/r/970878

gerritbot added a comment.Nov 2 2023, 3:26 PM

Change 970878 merged by jenkins-bot:

[oojs/ui@master] styles, themes: Replace deprecated `@min-size-*` vars

https://gerrit.wikimedia.org/r/970878

Volker_E added a project: OOUI.Nov 3 2023, 2:37 AM
Volker_E updated the task description. (Show Details)
gerritbot added a comment.Nov 3 2023, 10:19 PM

Change 971520 had a related patch set uploaded (by VolkerE; author: VolkerE):

[oojs/ui@master] styles, themes: Replace deprecated `size-*` vars

https://gerrit.wikimedia.org/r/971520

gerritbot added a comment.Nov 3 2023, 11:36 PM

Change 971520 merged by jenkins-bot:

[oojs/ui@master] styles, themes: Replace deprecated `size-*` vars

https://gerrit.wikimedia.org/r/971520

Volker_E added a project: Technical-Debt.Nov 4 2023, 3:29 AM
Nardog subscribed.Nov 4 2023, 3:35 AM

The font size in OOUI dialogs has increased unexpectedly. For example, open "Merge with..." in the "More" menu on Wikidata. In addition to the increased font size, the buttons at the top are clipped and there's a small gap beneath them that wasn't there before.

1.png (455×555 px, 26 KB)

Izno subscribed.Nov 4 2023, 5:08 AM

That's likely T350467.

Izno unsubscribed.Nov 4 2023, 5:08 AM
gerritbot added a comment.Nov 4 2023, 5:16 AM

Change 971552 had a related patch set uploaded (by VolkerE; author: VolkerE):

[oojs/ui@master] themes: Replace `background-color-*` variables with category tokens

https://gerrit.wikimedia.org/r/971552

Nardog added a subscriber: Izno.Nov 4 2023, 10:01 AM
In T332120#9306387, @Izno wrote:

That's likely T350467.

Thanks, so it's T348286 that's the culprit.

Nardog removed a subscriber: Izno.Nov 4 2023, 10:01 AM
Volker_E updated the task description. (Show Details)Nov 4 2023, 8:25 PM
gerritbot added a comment.Nov 4 2023, 9:00 PM

Change 971588 had a related patch set uploaded (by VolkerE; author: VolkerE):

[oojs/ui@master] themes: Replace `color-*` variables with category tokens

https://gerrit.wikimedia.org/r/971588

gerritbot added a comment.Nov 5 2023, 1:24 AM

Change 971592 had a related patch set uploaded (by VolkerE; author: VolkerE):

[oojs/ui@master] themes: Replace `opacity-*` variables with category tokens

https://gerrit.wikimedia.org/r/971592

gerritbot added a comment.Nov 5 2023, 2:47 AM

Change 971594 had a related patch set uploaded (by VolkerE; author: VolkerE):

[oojs/ui@master] Replace `border-*` variables with category tokens

https://gerrit.wikimedia.org/r/971594

gerritbot added a comment.Nov 5 2023, 6:40 AM

Change 971603 had a related patch set uploaded (by VolkerE; author: VolkerE):

[oojs/ui@master] WikimediaUI theme: Replace `box-shadow-*` variables with category tokens

https://gerrit.wikimedia.org/r/971603

Nikerabbit updated the task description. (Show Details)Nov 6 2023, 11:16 AM
Nikerabbit removed a project: Language-Team.
gerritbot added a comment.Nov 7 2023, 9:11 PM

Change 971552 merged by jenkins-bot:

[oojs/ui@master] themes: Replace `background-color-*` variables with category tokens

https://gerrit.wikimedia.org/r/971552

gerritbot added a comment.Nov 7 2023, 9:33 PM

Change 971588 merged by jenkins-bot:

[oojs/ui@master] themes: Replace `color-*` variables with category tokens

https://gerrit.wikimedia.org/r/971588

gerritbot added a comment.Nov 8 2023, 4:05 AM

Change 972533 had a related patch set uploaded (by VolkerE; author: VolkerE):

[wikibase/termbox@master] Replace WikimediaUI Base with Codex design tokens

https://gerrit.wikimedia.org/r/972533

gerritbot added a comment.Nov 8 2023, 11:19 AM

Change 969232 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] Replace WikimediaUI Base with Codex design tokens

https://gerrit.wikimedia.org/r/969232

gerritbot added a comment.Nov 10 2023, 9:19 PM

Change 971592 merged by jenkins-bot:

[oojs/ui@master] themes: Replace `opacity-*` variables with category tokens

https://gerrit.wikimedia.org/r/971592

gerritbot added a comment.Nov 10 2023, 9:19 PM

Change 971594 merged by jenkins-bot:

[oojs/ui@master] themes: Replace `border-*` variables with category tokens

https://gerrit.wikimedia.org/r/971594

gerritbot added a comment.Nov 10 2023, 9:19 PM

Change 971603 merged by jenkins-bot:

[oojs/ui@master] WikimediaUI theme: Replace `box-shadow-*` variables with category tokens

https://gerrit.wikimedia.org/r/971603

gerritbot added a comment.Nov 20 2023, 11:35 AM

Change 975779 had a related patch set uploaded (by Nik Gkountas; author: Nik Gkountas):

[mediawiki/extensions/ContentTranslation@master] CX3 Build 0.2.0+20231120

https://gerrit.wikimedia.org/r/975779

gerritbot added a comment.Nov 27 2023, 5:31 PM

Change 975779 merged by Nik Gkountas:

[mediawiki/extensions/ContentTranslation@master] CX3 Build 0.2.0+20231124

https://gerrit.wikimedia.org/r/975779

gerritbot added a comment.Dec 6 2023, 11:20 PM

Change 980958 had a related patch set uploaded (by Anne Tomasevich; author: Anne Tomasevich):

[mediawiki/core@master] Update OOUI to v0.48.3

https://gerrit.wikimedia.org/r/980958

gerritbot added a comment.Dec 7 2023, 8:29 AM

Change 972533 merged by jenkins-bot:

[wikibase/termbox@master] Replace WikimediaUI Base with Codex design tokens

https://gerrit.wikimedia.org/r/972533

Jakob_WMDE mentioned this in rWBTB67270ac25fe3: Replace WikimediaUI Base with Codex design tokens.Dec 7 2023, 8:30 AM
Volker_E updated the task description. (Show Details)Dec 7 2023, 1:55 PM
gerritbot added a comment.Dec 7 2023, 1:57 PM

Change 980958 merged by jenkins-bot:

[mediawiki/core@master] Update OOUI to v0.48.3

https://gerrit.wikimedia.org/r/980958

Maintenance_bot removed a project: Patch-For-Review.Dec 7 2023, 2:11 PM
Volker_E closed this task as Resolved.Jan 4 2024, 10:54 PM
Volker_E updated the task description. (Show Details)
Volker_E updated the task description. (Show Details)
gerritbot added a comment.Jan 23 2024, 9:54 AM

Change 992387 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[operations/deployment-charts@master] termbox(test): update to 2024-01-22-163619-production

https://gerrit.wikimedia.org/r/992387

gerritbot added a project: Patch-For-Review.Jan 23 2024, 9:54 AM
gerritbot added a comment.Jan 23 2024, 3:04 PM

Change 992387 merged by jenkins-bot:

[operations/deployment-charts@master] termbox(test): update to 2024-01-22-163619-production

https://gerrit.wikimedia.org/r/992387

gerritbot added a comment.Jan 23 2024, 3:10 PM

Change 992446 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[operations/deployment-charts@master] termbox: update to 2024-01-22-163619-production

https://gerrit.wikimedia.org/r/992446

gerritbot added a comment.Jan 23 2024, 3:17 PM

Change 992446 merged by jenkins-bot:

[operations/deployment-charts@master] termbox: update to 2024-01-22-163619-production

https://gerrit.wikimedia.org/r/992446

gerritbot added a comment.Jan 23 2024, 3:28 PM

Change 992452 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[operations/deployment-charts@master] Revert "termbox: update to 2024-01-22-163619-production"

https://gerrit.wikimedia.org/r/992452

gerritbot added a comment.Jan 23 2024, 3:30 PM

Change 992452 merged by jenkins-bot:

[operations/deployment-charts@master] Revert "termbox: update to 2024-01-22-163619-production"

https://gerrit.wikimedia.org/r/992452

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits