Page MenuHomePhabricator
Create Task
Maniphest T332319

Leveling up: Off-by-one error for edit-count-for-task-type in impression event
Closed, ResolvedPublicBUG REPORT
Actions

Description

Steps to replicate the issue (include links if applicable):

  • Make enough edits to trigger the "try new task" panel
  • Observe the impression event for the try new task panel

What happens?:

The event looks like this:

{
	"event": {
		"action": "trynewtask-impression",
		"action_data": "next-suggested-task-type=links;edit-count-for-task-type=4",
		"context": "postedit-trynewtask",
		"editor_interface": "visualeditor",
		"help_panel_session_id": "066f72d5882382588f68",
		"is_mobile": false,
		"is_suggested_task": true,
		"page_id": 0,
		"page_ns": 0,
		"page_protection": "",
		"page_title": "",
		"session_token": "{removed}",
		"user_can_edit": true,
		"user_editcount": 21,
		"user_id": 23688
	}
}

What should have happened instead?:

The event should show 5 edits for copyedit:

{
	"event": {
		"action": "trynewtask-impression",
		"action_data": "next-suggested-task-type=links;edit-count-for-task-type=5",
		"context": "postedit-trynewtask",
		"editor_interface": "visualeditor",
		"help_panel_session_id": "066f72d5882382588f68",
		"is_mobile": false,
		"is_suggested_task": true,
		"page_id": 0,
		"page_ns": 0,
		"page_protection": "",
		"page_title": "",
		"session_token": "{removed}",
		"user_can_edit": true,
		"user_editcount": 21,
		"user_id": 23688
	}
}

Software version (skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):

Details

SubjectRepoBranchLines +/-
PostEdit: Increment the edit-count-for-task-type countmediawiki/extensions/GrowthExperimentswmf/1.40.0-wmf.27+5 -1
PostEdit: Increment the edit-count-for-task-type countmediawiki/extensions/GrowthExperimentsmaster+5 -1
Customize query in gerrit

Related Objects
Search...

Event Timeline

kostajh triaged this task as High priority.Mar 16 2023, 2:52 PM
kostajh created this task.
kostajh mentioned this in T330637: Leveling up: Instrumentation for "Try a new task" dialog.
kostajh moved this task from Incoming to Ready for Development on the Growth-Team (Sprint 0 (Growth Team)) board.
kostajh added a parent task: T332317: Leveling Up: Release blockers.
kostajh claimed this task.Mar 17 2023, 11:33 AM
kostajh moved this task from Ready for Development to In Progress on the Growth-Team (Sprint 0 (Growth Team)) board.
gerritbot added a comment.Mar 17 2023, 1:51 PM

Change 900657 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):

[mediawiki/extensions/GrowthExperiments@master] PostEdit: Increment the edit-count-for-task-type count

https://gerrit.wikimedia.org/r/900657

gerritbot added a project: Patch-For-Review.Mar 17 2023, 1:51 PM
kostajh moved this task from In Progress to Code Review on the Growth-Team (Sprint 0 (Growth Team)) board.Mar 17 2023, 1:52 PM
KStoller-WMF moved this task from Backlog to Week 7 (Mar 13 - Mar 17) on the GrowthExperiments-LevelingUp board.Mar 17 2023, 6:07 PM
gerritbot added a comment.Mar 17 2023, 8:52 PM

Change 900657 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] PostEdit: Increment the edit-count-for-task-type count

https://gerrit.wikimedia.org/r/900657

Tgr moved this task from Code Review to QA on the Growth-Team (Sprint 0 (Growth Team)) board.Mar 17 2023, 8:52 PM
ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.1; 2023-03-20).Mar 17 2023, 9:00 PM
Maintenance_bot removed a project: Patch-For-Review.Mar 17 2023, 9:10 PM
gerritbot added a comment.Mar 20 2023, 11:06 AM

Change 900685 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):

[mediawiki/extensions/GrowthExperiments@wmf/1.40.0-wmf.27] PostEdit: Increment the edit-count-for-task-type count

https://gerrit.wikimedia.org/r/900685

gerritbot added a project: Patch-For-Review.Mar 20 2023, 11:06 AM
gerritbot added a comment.Mar 20 2023, 8:29 PM

Change 900685 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@wmf/1.40.0-wmf.27] PostEdit: Increment the edit-count-for-task-type count

https://gerrit.wikimedia.org/r/900685

Maintenance_bot removed a project: Patch-For-Review.Mar 20 2023, 8:30 PM
Stashbot added a comment.Mar 20 2023, 8:47 PM

Mentioned in SAL (#wikimedia-operations) [2023-03-20T20:47:50Z] <kharlan@deploy2002> Started scap: Backport for [[gerrit:901146|TryNewTask: Set an array fallback if TryNewTaskOptOuts is null]], [[gerrit:900685|PostEdit: Increment the edit-count-for-task-type count (T332319)]], [[gerrit:900684|LevelingUpManager: Handle links/link-recommendation collision (T332309)]]

Stashbot mentioned this in T332309: Uncaught TypeError: can't access property "difficulty", this.taskType is undefined.Mar 20 2023, 8:47 PM

Mentioned in SAL (#wikimedia-operations) [2023-03-20T20:49:27Z] <kharlan@deploy2002> kharlan: Backport for [[gerrit:901146|TryNewTask: Set an array fallback if TryNewTaskOptOuts is null]], [[gerrit:900685|PostEdit: Increment the edit-count-for-task-type count (T332319)]], [[gerrit:900684|LevelingUpManager: Handle links/link-recommendation collision (T332309)]] synced to the testservers: mwdebug2001.codfw.wmnet, mwdebug2002.codfw.wmnet, mwdebug1001.eqiad.wmnet, mwdebug1002.eqiad.wmn

Stashbot added a comment.Mar 20 2023, 8:58 PM

Mentioned in SAL (#wikimedia-operations) [2023-03-20T20:58:18Z] <kharlan@deploy2002> Finished scap: Backport for [[gerrit:901146|TryNewTask: Set an array fallback if TryNewTaskOptOuts is null]], [[gerrit:900685|PostEdit: Increment the edit-count-for-task-type count (T332319)]], [[gerrit:900684|LevelingUpManager: Handle links/link-recommendation collision (T332309)]] (duration: 10m 28s)

kostajh added a subscriber: Etonkovidova.Mar 20 2023, 9:00 PM

This change is now in wmf.27, so removing from release blockers. cc @Etonkovidova

ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.27; 2023-03-13).Mar 20 2023, 9:00 PM
kostajh removed a parent task: T332317: Leveling Up: Release blockers.Mar 20 2023, 9:00 PM
Etonkovidova closed this task as Resolved.Mar 29 2023, 8:26 PM

Checked testwiki wmf.2 - when the try new task post edit dialog appears, the event looks correct:

{
	"event": {
		"action": "trynewtask-impression",
		"action_data": "next-suggested-task-type=copyedit;savedTaskType=update;edit-count-for-task-type=5"
		"context": "postedit-trynewtask",
		"editor_interface": "visualeditor",
		"help_panel_session_id": "7822845e9787212e7bec";
		"is_mobile": false,
		"is_suggested_task": true,
		"page_id": 0,
		"page_ns": 0,
		"page_protection": "",
		"page_title": "",
		"session_token": "{removed}",
		"user_can_edit": true,
		"user_editcount": 54,
		"user_id": 50416
	}
}
Etonkovidova mentioned this in T333519: [QA task] discrepancy between user_editcount and edit-count-for-task-type .Mar 30 2023, 2:29 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits