Page MenuHomePhabricator

Prepare Vector 2022 header & sticky header for Zebra#9 design update
Closed, ResolvedPublic8 Estimated Story Points

Description

The Zebra#9 prototype features a page header with a white background that spans the whole viewport (the content of the header remains constrained)

Design spec

Screenshot 2023-03-17 at 3.10.49 PM.png (193×1 px, 56 KB)
Zebra # 9 design

Current implementation

Currently, the header and sticky header have a constrained width along with the background color.

Screenshot 2023-03-17 at 3.19.41 PM.png (227×1 px, 52 KB)
current
Screenshot 2023-03-17 at 3.30.06 PM.png (165×1 px, 78 KB)
current sticky header

The goal of this task is to adjust the header & sticky header so that it can accomodate the new design. The header & sticky headers should still function with the old design, and need work with the full-width toggle in both cases. Styles for the new design should be scoped to the feature class on the html element.

technical notes

Based on the previous spike T331320, we can achieve this look in several different ways, the 3rd approach is preferred:
1. No HTML changes - Use vw units and negative margins to stretch the header to the edge of the viewport

  1. Move the header HTML outside of .mw-page-container and add a wrapper element for the background

3. Move the header HTML outside of .mw-page-container without a wrapper element (give the .vector-sticky-header-start/end elements max-widths that add up to the page's max-width).

A/C

  • When the Zebra#9 feature flag is enabled, the header & sticky header should have a white background stretching to the edge of the viewport
  • When the Zebra#9 feature flag is enabled and the full width toggle is enabled, the header & sticky header should have a white background and content should stretch to the edge of the screen.
  • When the feature flag is off, there should be no visual changes.

Event Timeline

ovasileva moved this task from Incoming to Current Quarter on the Web-Team-Backlog board.
LGoto set the point value for this task to 8.Mar 23 2023, 5:26 PM

Change 903738 had a related patch set uploaded (by Bernard Wang; author: Bernard Wang):

[mediawiki/skins/Vector@master] Setup header and sticky header to be able to be full width

https://gerrit.wikimedia.org/r/903738

bwang removed bwang as the assignee of this task.Mar 28 2023, 8:01 PM
bwang subscribed.

Change 903746 had a related patch set uploaded (by Bernard Wang; author: Bernard Wang):

[mediawiki/skins/Vector@master] Clean up cached grid CSS from moving the Header

https://gerrit.wikimedia.org/r/903746

Jdrewniak updated the task description. (Show Details)

Change 903738 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Setup header and sticky header to be able to be full width

https://gerrit.wikimedia.org/r/903738

Change 904837 had a related patch set uploaded (by Bernard Wang; author: Bernard Wang):

[mediawiki/skins/Vector@master] Implement new zebra design for the header under the flag

https://gerrit.wikimedia.org/r/904837

Change 905296 had a related patch set uploaded (by Bernard Wang; author: Bernard Wang):

[mediawiki/skins/Vector@master] Fix sticky header search

https://gerrit.wikimedia.org/r/905296

Change 905296 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Fix sticky header search

https://gerrit.wikimedia.org/r/905296

Change 904837 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Implement new zebra design for the header under the flag

https://gerrit.wikimedia.org/r/904837

All patches are merged. I don't see https://gerrit.wikimedia.org/r/c/903746 as necessary for sign off. @bwang @Jdrewniak anything left to do here? Would design review/QA be useful at this stage or should this go directly to sign off?
Test URL: https://en.wikipedia.beta.wmflabs.org/wiki/Dog?vectorzebradesign=1

@Jdlrobson I think this could go to sign off, the main design change here is the width of the header which looks good so far

Change 906062 had a related patch set uploaded (by Bernard Wang; author: Bernard Wang):

[mediawiki/skins/Vector@master] Follow-up: add border to zebra header

https://gerrit.wikimedia.org/r/906062

Oops, I just realized I forgot to include the border style thats in the mocks. This small patch should fix that, and then this can be put in sign off https://gerrit.wikimedia.org/r/c/mediawiki/skins/Vector/+/906062

Change 906062 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Follow-up: add border to zebra header

https://gerrit.wikimedia.org/r/906062

Change 903746 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Clean up cached grid CSS from moving the Header

https://gerrit.wikimedia.org/r/903746

@bwang, @Jdlrobson - would it make sense to do any QA for this one?

Per standup, no. Design review should be sufficient at this stage.

Per the A/C I was able to see the new header design on beta with the feature flag turned on:

Screenshot 2023-04-11 at 5.18.54 PM.png (1×1 px, 237 KB)