Page MenuHomePhabricator

Visual Edits do not save
Closed, ResolvedPublicBUG REPORT

Description

Steps to replicate the issue (include links if applicable):

  • Start a draft edit in Visual edit mode (vector 2022) skin
  • Try to publish (it freezes without proceeding)
  • Switch to source mode
  • Publishing then does work

Other information (browser name/version, screenshots, etc.):
Firefox version 111, Vector 2022 skin on English Wikipedia

Event Timeline

Please disable all user scripts and verify if the problem is still presenting for you.

I am unable to replicate the error anymore, despite not changing anything. I will try some more visual editor edits and try your workaround if anything comes up.

Well, it started working again!

Nope false alert, it's not working again for me. So will try your work around

Would this be correct way to load a page in safe mode? (Note I am loading it in edit mode already) https://en.wikipedia.org/wiki/Trader_Joe's_unions?veaction=edit?safemode=1

That did not work for me unfortunately on https://en.wikipedia.org/wiki/Trader_Joe%27s_unions. I had to switch to source mode (even when loading in safe mode with your link)

Change 904700 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[operations/mediawiki-config@master] Revert "Enable hidden tag for "Edit Check" project on Wikipedias"

https://gerrit.wikimedia.org/r/904700

Change 904700 merged by jenkins-bot:

[operations/mediawiki-config@master] Revert "Enable hidden tag for "Edit Check" project on Wikipedias"

https://gerrit.wikimedia.org/r/904700

Mentioned in SAL (#wikimedia-operations) [2023-03-31T16:02:30Z] <ladsgroup@deploy2002> Started scap: Backport for [[gerrit:904700|Revert "Enable hidden tag for "Edit Check" project on Wikipedias" (T324733 T333612)]]

Mentioned in SAL (#wikimedia-operations) [2023-03-31T16:03:50Z] <ladsgroup@deploy2002> matmarex and ladsgroup: Backport for [[gerrit:904700|Revert "Enable hidden tag for "Edit Check" project on Wikipedias" (T324733 T333612)]] synced to the testservers: mwdebug1001.eqiad.wmnet, mwdebug1002.eqiad.wmnet, mwdebug2002.codfw.wmnet, mwdebug2001.codfw.wmnet

Mentioned in SAL (#wikimedia-operations) [2023-03-31T16:10:49Z] <ladsgroup@deploy2002> Finished scap: Backport for [[gerrit:904700|Revert "Enable hidden tag for "Edit Check" project on Wikipedias" (T324733 T333612)]] (duration: 08m 18s)

A bit more details: the issue was caused by code we deployed this week which was supposed to examine the changes made before saving, and record some data for the Edit Check project. Unfortunately it apparently fails on some kinds of changes (not all edits, but a significant number). In the en.wp VPT discussion someone suggested in happens when editing templates, but I couldn't reproduce the problem yet. For now I just disabled this code, and we will investigate it next week. Sorry about this.

Revert deployed, is it fixed now?

Yes – Before, one of these errors was logged every 2 minutes on average, and they mostly stopped after the deployment, with just 1 in the last 30 minutes. (Unfortunately the fix can't affect edit sessions that are already in progress, so there will be some late occurrences of the error.)