Page MenuHomePhabricator
Create Task
Maniphest T335030

Minerva Neue: Stop mixing variant names with language names in the language overlay
Open, Needs TriagePublic
Actions

Assigned To
None
Authored By
Winston_Sung
Apr 19 2023, 11:12 AM
Tags
Referenced Files
F37145192: image.png
Jul 21 2023, 6:15 AM
F37145188: image.png
Jul 21 2023, 6:07 AM
F37145180: image.png
Jul 21 2023, 6:05 AM
F37144488: Screenshot_2023-03-31-06-26-37-137_com.microsoft.emmx.jpg
Jul 20 2023, 11:39 AM
Subscribers
Aklapper
Ericliu1912
Func
Jdlrobson
jhsoby
Masumrezarock100
Winston_Sung

Description

Minerva Neue: Stop mixing variant names with language names in the language overlay.

Using variant names as language names were confusing, it caused issues like "Missing in 'Unconverted (language variant)' >".

We should stop mixing them.

This includes:

  • The language selection menu
    • Go to any zh wiki with MobileFrontend extension and Minerva Neue skin
    • Click the language menu icon / button where the page has interlanguage links
    • The language names and the language variant names were mixed together
  • The "Missing in <language name>" notice
    • Go to any non-zh wiki, which enabled ContentTranslation and have linked to a zh wiki, with zh-* Accept-Language header
    • Click the language menu icon / button where the page haven't linked to a zh page
    • It shows a "Missing in <language variant name>" notice

Reported by: Levi (列维劳德)

The language selection menu:

image.png (887×264 px, 26 KB)

The "Missing in <language name>" notice:

Screenshot_2023-03-31-06-26-37-137_com.microsoft.emmx.jpg (1×720 px, 49 KB)

Solution:

image.png (887×268 px, 28 KB)

QA steps

Test case 1

Visit https://zh.m.wikipedia.org/wiki/%E9%A9%AC%E4%BF%AE%C2%B7%E8%B4%B9%E6%96%AF%E6%B1%80 and click the language button

Expected: 大陆简体 appears once in list of language variants.

Actual: 大陆简体 appears in language variants AND language list

Test case 2

Go to https://zh.m.wikipedia.org/wiki/%E5%90%89%E6%9E%97%E7%9C%81%E5%8F%8B%E5%A5%BD%E5%9F%8E%E5%B8%82%E5%88%97%E8%A1%A8.

Check https://zh.m.wikipedia.org/wiki/%E5%90%89%E6%9E%97%E7%9C%81%E5%8F%8B%E5%A5%BD%E5%9F%8E%E5%B8%82%E5%88%97%E8%A1%A8 has no language versions, only variants.

Expected:

  • The language list should be empty

Actual:
The language list is not empty - it contains variants

Details

SubjectRepoBranchLines +/-
PageHTMLParser: Exclude variants from the "other languages" sectionmediawiki/extensions/MobileFrontendmaster+3 -3
Use language name instead of variant name for missing languagesmediawiki/extensions/ContentTranslationmaster+15 -8
Customize query in gerrit

Related Objects
Search...

Event Timeline

Winston_Sung created this task.Apr 19 2023, 11:12 AM
Winston_Sung moved this task from Core to Extensions/Skins on the MediaWiki-Language-converter board.
Winston_Sung added a project: Chinese-Sites.
Restricted Application added a subscriber: Ericliu1912. · View Herald TranscriptApr 19 2023, 11:12 AM
Winston_Sung moved this task from Backlog to Extensions/Skins on the Chinese-Sites board.Apr 19 2023, 11:13 AM
Jdlrobson removed a project: MinervaNeue.Jul 19 2023, 4:59 PM
Jdlrobson subscribed.

I'm not sure how this relates to Minerva. Please expand the task description as it doesn't make it clear to other people what the problem we want to solve is.

Winston_Sung renamed this task from Interlanguage: Stop mixing variant names with language names to Minerva Neue: Stop mixing variant names with language names in the interlanguage menu.Jul 20 2023, 11:39 AM
Winston_Sung added projects: MinervaNeue, ContentTranslation.
Winston_Sung updated the task description. (Show Details)
Restricted Application added a subscriber: Masumrezarock100. · View Herald TranscriptJul 20 2023, 11:39 AM
Winston_Sung updated the task description. (Show Details)Jul 20 2023, 11:40 AM
In T335030#9028988, @Jdlrobson wrote:

I'm not sure how this relates to Minerva. Please expand the task description as it doesn't make it clear to other people what the problem we want to solve is.

Done.

Jdlrobson edited projects, added MinervaNeue (Tracking); removed MinervaNeue.Jul 20 2023, 7:18 PM

I believe Minerva only provides the hook here so moving to tracking. Please let me know if I've misunderstood the task.

Winston_Sung updated the task description. (Show Details)Jul 21 2023, 6:05 AM
Winston_Sung updated the task description. (Show Details)
Winston_Sung added a comment.Jul 21 2023, 6:09 AM

Yeah, seems like MobileFrontend-only. Related: T331908: [follow up] Languages overlay does not need to use API. .

Winston_Sung added a project: MobileFrontend.Jul 21 2023, 6:11 AM
Winston_Sung updated the task description. (Show Details)Jul 21 2023, 6:15 AM
Func subscribed.Jul 21 2023, 3:44 PM

Also, it would be better if the title text under the variant name is using that variant.

Winston_Sung added a comment.Jul 21 2023, 4:26 PM

That sounds a little tech debt as I'm not sure how to "manually fix the language conversion for 'plain text title' in language variant" (not the "display title").

gerritbot added a comment.Jul 21 2023, 5:01 PM

Change 940209 had a related patch set uploaded (by Func; author: Func):

[mediawiki/extensions/ContentTranslation@master] Use language name instead of variant name for missing languages

https://gerrit.wikimedia.org/r/940209

gerritbot added a project: Patch-For-Review.Jul 21 2023, 5:01 PM
gerritbot added a comment.Jul 21 2023, 5:21 PM

Change 940210 had a related patch set uploaded (by Func; author: Func):

[mediawiki/extensions/MobileFrontend@master] PageHTMLParser: Exclude variants from the "other languages" section

https://gerrit.wikimedia.org/r/940210

Jdlrobson updated the task description. (Show Details)Jul 21 2023, 6:03 PM

Replication steps always help. I didn't fully understand what was being reported until I saw Func's patch.

Func added a comment.Jul 21 2023, 6:08 PM
In T335030#9034715, @Winston_Sung wrote:

That sounds a little tech debt as I'm not sure how to "manually fix the language conversion for 'plain text title' in language variant" (not the "display title").

I think something like varianttitles from the action=query API should be sufficient, but not ideal for all cases since it can not be aware of the -{T|}- syntax.

Winston_Sung added a comment.Jul 22 2023, 5:38 AM
In T335030#9035040, @Func wrote:

but not ideal for all cases since it can not be aware of the -{T|}- syntax.

Yeah, that's what I'm worried about.

Winston_Sung renamed this task from Minerva Neue: Stop mixing variant names with language names in the interlanguage menu to Minerva Neue: Stop mixing variant names with language names in the language overlay.Jul 22 2023, 5:49 AM
Winston_Sung updated the task description. (Show Details)
gerritbot added a comment.Jul 22 2023, 6:09 AM

Change 940209 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] Use language name instead of variant name for missing languages

https://gerrit.wikimedia.org/r/940209

ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.19; 2023-07-25).Jul 22 2023, 7:00 AM
gerritbot added a comment.Jul 22 2023, 8:12 AM

Change 940210 merged by jenkins-bot:

[mediawiki/extensions/MobileFrontend@master] PageHTMLParser: Exclude variants from the "other languages" section

https://gerrit.wikimedia.org/r/940210

Maintenance_bot removed a project: Patch-For-Review.Jul 22 2023, 8:30 AM
• Nikerabbit merged a task: T333738: SectionTranslation: Language menu show "missing in 'language variant name' instead of 'language name' in MinervaNeue skin.Aug 14 2023, 11:31 AM
• Nikerabbit added a subscriber: jhsoby.
• Nikerabbit moved this task from Needs Triage to Upstream/Other teams on the ContentTranslation board.Aug 28 2023, 11:26 AM
Winston_Sung added a subtask: T333738: SectionTranslation: Language menu show "missing in 'language variant name' instead of 'language name' in MinervaNeue skin.Aug 28 2023, 1:07 PM
Pginer-WMF closed subtask T333738: SectionTranslation: Language menu show "missing in 'language variant name' instead of 'language name' in MinervaNeue skin as Resolved.Aug 31 2023, 9:19 AM
Winston_Sung added a comment.Dec 27 2023, 6:06 PM
In T335030#9034640, @Func wrote:

Also, it would be better if the title text under the variant name is using that variant.

Should be possible: T178446: Expose display titles for a page in all available language variants through the action API .

Winston_Sung mentioned this in T366084: Update language variants localized names in the apps.May 28 2024, 3:59 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits