Page MenuHomePhabricator
Create Task
Maniphest T336256

Inconsistent use of href parameter and selflink mw-selflink classes between plain links and links in images
Open, Needs TriagePublic
Actions

Description

Standard MediaWiki behavior: When a link is rendered from wikitext and the user is on the same page that the link is referencing the [a] element is rendered without a href attribute and with the classes selflink mw-selflink. This is a sensible way and gives styling opportunities.

However if File: or Image: is used with the link-parameter the same does not apply. The link is rendered with a href attribute and without the classes selflink mw-selflink.

Could you please make the behavior consistent betweens text links and image links and use selflink mw-selflink also for File: and Image:?

Details

SubjectRepoBranchLines +/-
[WIP] Recognize selflinks in the media link optionmediawiki/coremaster+20 -7
Customize query in gerrit

Related Objects
Search...

Event Timeline

adrelanos created this task.May 9 2023, 11:59 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 9 2023, 11:59 AM
Aklapper renamed this task from Inconsistent behavior regarding plain links and links in images to Inconsistent use of href parameter and selflink mw-selflink classes between plain links and links in images.May 9 2023, 1:14 PM
Izno edited projects, added MediaWiki-Parser, Parsoid; removed MediaWiki-General.May 9 2023, 11:02 PM
Izno subscribed.
cscott added subscribers: Arlolra, cscott.EditedMay 11 2023, 2:16 PM

@Arlolra could this be addressed in your media work? This is also perhaps something that could be done in @ihurbain's redlink pass in Parsoid.

cscott added a subscriber: ihurbain.May 11 2023, 2:18 PM
Arlolra added a comment.May 11 2023, 3:34 PM
In T336256#8844793, @cscott wrote:

@Arlolra could this be addressed in your media work?

Parsoid currently doesn't add self-links at all, which is T69486. We can do it as part of that work.

Arlolra added a parent task: T69486: Links: Add support for self-links to Parsoid.May 11 2023, 3:34 PM
MSantos moved this task from Needs Triage to Missing Functionality on the Parsoid board.May 18 2023, 2:05 PM
MSantos added a project: Content-Transform-Team-WIP.Jan 22 2024, 4:14 PM
ihurbain closed this task as Declined.Jan 23 2024, 9:20 AM

My tests as of today indicate that, on the legacy parser, we do add the selflink mw-selflink classes to image pages - see for instance https://test.wikipedia.org/w/index.php?title=File:Appenzellerweg.jpg&useparsoid=0. Parsoid is not handling these right now (but T69486 is in progress), but it's also handling them consistently.
I am hence tentatively declining this issue - if more information/test cases are available, please feel free to reopen!

adrelanos reopened this task as Open.Jan 27 2024, 4:54 PM

Hi @ihurbain, thank you for your consideration! We would kindly like to take you up on your offer to reopen this issue. The test you have constructed is not the use case we are talking about.

What we would like to see - preferably in Parsoid for future use - is images with the link attribute being handled like links.

Specifically, let's assume a test page with the route /wiki/Testpage. If an internal link to /wiki/Testpage is on /wiki/Testpage itself then the link is rendered with the selflink mw-selflink classes. If on /wiki/Testpage there's an image with the link attribute pointing to /wiki/Testpage itself then the outer a-element is NOT rendered with selflink mw-selflink.

We consider this inconsistent behavior. Because while this is still primarily an image it is also wrapped inside an a-element and therefore can and - in our opinion for consistency reasons - should be treated like a link element. This would mean that the outer a-element for an image on /wiki/Testpage with the link attribute linking to this exact page /wiki/Testpage should also be treated like a link element and have the selflink mw-selflink classes.

What we are not talking about is a user visiting a File: link such as wiki/File:Somefile.

ABreault-WMF subscribed.Jan 28 2024, 4:50 PM

The syntax to test is [[File:Somefile|link=Testpage]] on Testpage

MSantos added a project: Essential-Work.Jan 29 2024, 4:04 PM
gerritbot added a comment.Jan 31 2024, 6:33 PM

Change 994801 had a related patch set uploaded (by Arlolra; author: Arlolra):

[mediawiki/core@master] [WIP] Recognize selflinks in the media link option

https://gerrit.wikimedia.org/r/994801

gerritbot added a project: Patch-For-Review.Jan 31 2024, 6:33 PM
Arlolra added a comment.Jan 31 2024, 7:43 PM

The patch above is pretty much what it would take to do this in the legacy parser. But note that the |link= option doesn't get turned into a redlink either so the problem is a bit more general.

On the Parsoid side, the current redlink / selflink post-processing pass querySelects mw:WikiLinks, which isn't applied inside the media structure. We could add it but whether that's semantically correct needs clarification. Alternatively, we could select links to apply the class based on hrefs matching a pattern.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL