UnexpectedValueException: Unknown image suggestions API kind: istype-depicts
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Description

Error

service.version: 1.41.0-wmf.9
trace.id: 10f7a41b-b1d6-4512-98ea-28d1d3f3ff53
Find trace.id in Logstash

labels.normalized_message

[{reqId}] {exception_url}   UnexpectedValueException: Unknown image suggestions API kind: istype-depicts

error.stack_trace

from /srv/mediawiki/php-1.41.0-wmf.9/extensions/GrowthExperiments/includes/NewcomerTasks/AddImage/ProductionImageRecommendationApiHandler.php(137)
#0 /srv/mediawiki/php-1.41.0-wmf.9/extensions/GrowthExperiments/includes/NewcomerTasks/AddImage/ServiceImageRecommendationProvider.php(126): GrowthExperiments\NewcomerTasks\AddImage\ProductionImageRecommendationApiHandler->getSuggestionDataFromApiResponse(array, GrowthExperiments\NewcomerTasks\TaskType\ImageRecommendationTaskType)
#1 /srv/mediawiki/php-1.41.0-wmf.9/extensions/GrowthExperiments/includes/NewcomerTasks/AddImage/CacheBackedImageRecommendationProvider.php(90): GrowthExperiments\NewcomerTasks\AddImage\ServiceImageRecommendationProvider->get(MediaWiki\Title\Title, GrowthExperiments\NewcomerTasks\TaskType\ImageRecommendationTaskType)
#2 /srv/mediawiki/php-1.41.0-wmf.9/includes/libs/objectcache/wancache/WANObjectCache.php(1752): GrowthExperiments\NewcomerTasks\AddImage\CacheBackedImageRecommendationProvider::GrowthExperiments\NewcomerTasks\AddImage\{closure}(boolean, integer, array, NULL, array)
#3 /srv/mediawiki/php-1.41.0-wmf.9/includes/libs/objectcache/wancache/WANObjectCache.php(1582): WANObjectCache->fetchOrRegenerate(string, integer, Closure, array, array)
#4 /srv/mediawiki/php-1.41.0-wmf.9/extensions/GrowthExperiments/includes/NewcomerTasks/AddImage/CacheBackedImageRecommendationProvider.php(95): WANObjectCache->getWithSetCallback(string, integer, Closure)
#5 /srv/mediawiki/php-1.41.0-wmf.9/extensions/GrowthExperiments/includes/NewcomerTasks/TaskSetListener.php(58): GrowthExperiments\NewcomerTasks\AddImage\CacheBackedImageRecommendationProvider::getWithSetCallback(WANObjectCache, GrowthExperiments\NewcomerTasks\AddImage\ServiceImageRecommendationProvider, GrowthExperiments\NewcomerTasks\TaskType\ImageRecommendationTaskType, TitleValue, string, BufferingStatsdDataFactory)
#6 /srv/mediawiki/php-1.41.0-wmf.9/includes/deferred/MWCallableUpdate.php(38): GrowthExperiments\NewcomerTasks\TaskSetListener->GrowthExperiments\NewcomerTasks\{closure}()
#7 /srv/mediawiki/php-1.41.0-wmf.9/includes/deferred/DeferredUpdates.php(473): MWCallableUpdate->doUpdate()
#8 /srv/mediawiki/php-1.41.0-wmf.9/includes/deferred/DeferredUpdates.php(398): DeferredUpdates::attemptUpdate(MWCallableUpdate, Wikimedia\Rdbms\LBFactoryMulti)
#9 /srv/mediawiki/php-1.41.0-wmf.9/includes/deferred/DeferredUpdates.php(213): DeferredUpdates::run(MWCallableUpdate, Wikimedia\Rdbms\LBFactoryMulti, Monolog\Logger, BufferingStatsdDataFactory, MediaWiki\JobQueue\JobQueueGroupFactory, string)
#10 /srv/mediawiki/php-1.41.0-wmf.9/includes/deferred/DeferredUpdatesScope.php(267): DeferredUpdates::{closure}(MWCallableUpdate, integer)
#11 /srv/mediawiki/php-1.41.0-wmf.9/includes/deferred/DeferredUpdatesScope.php(196): DeferredUpdatesScope->processStageQueue(integer, integer, Closure)
#12 /srv/mediawiki/php-1.41.0-wmf.9/includes/deferred/DeferredUpdates.php(234): DeferredUpdatesScope->processUpdates(integer, Closure)
#13 /srv/mediawiki/php-1.41.0-wmf.9/includes/MediaWiki.php(1125): DeferredUpdates::doUpdates()
#14 /srv/mediawiki/php-1.41.0-wmf.9/includes/MediaWiki.php(856): MediaWiki->restInPeace()
#15 /srv/mediawiki/php-1.41.0-wmf.9/includes/MediaWiki.php(604): MediaWiki->doPostOutputShutdown()
#16 /srv/mediawiki/php-1.41.0-wmf.9/index.php(50): MediaWiki->run()
#17 /srv/mediawiki/php-1.41.0-wmf.9/index.php(46): wfIndexMain()
#18 /srv/mediawiki/w/index.php(3): require(string)
#19 {main}

Impact

Unclear.

Notes

A bunch of these after moving T330215: 1.41.0-wmf.9 deployment blockers to group2 wikis.

Spamming the tags a bit here.

Details

Request URL: https://cs.wikipedia.org/w/index.php?namespace=*&source=*&title=*

	Subject	Repo	Branch	Lines +/-
	Silently ignore istype-depicts image suggestion type	mediawiki/extensions/GrowthExperiments	master	+2 -0
	Silently ignore istype-depicts image suggestion type	mediawiki/extensions/GrowthExperiments	wmf/1.41.0-wmf.9	+2 -0

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved	Release	brennen	T330215 1.41.0-wmf.9 deployment blockers
		Resolved	PRODUCTION ERROR	None	T336962 UnexpectedValueException: Unknown image suggestions API kind: istype-depicts

Event Timeline

brennen triaged this task as Unbreak Now! priority.May 18 2023, 6:40 PM

brennen created this task.

Restricted Application added a project: Growth-Team. · View Herald TranscriptMay 18 2023, 6:40 PM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

brennen added a parent task: T330215: 1.41.0-wmf.9 deployment blockers.May 18 2023, 6:41 PM

Novem_Linguae subscribed.May 18 2023, 7:11 PM

kostajh edited projects, added Growth-Team (Sprint 0 (Growth Team)); removed Growth-Team.May 18 2023, 7:50 PM

kostajh moved this task from Incoming to Ready for Development on the Growth-Team (Sprint 0 (Growth Team)) board.May 18 2023, 7:58 PM

I believe that this is happening because we don't have a mapping for this value in includes/NewcomerTasks/AddImage/ProductionImageRecommendationApiHandler.php. Did someone recently add istype-depicts as a new value to the kind field in the image suggestion API?

Change 921096 had a related patch set uploaded (by Gergő Tisza; author: Gergő Tisza):

[mediawiki/extensions/GrowthExperiments@master] Silently ignore istype-depicts image suggestion type

https://gerrit.wikimedia.org/r/921096

gerritbot added a project: Patch-For-Review.May 18 2023, 8:25 PM

Change 920743 had a related patch set uploaded (by Urbanecm; author: Gergő Tisza):

[mediawiki/extensions/GrowthExperiments@wmf/1.41.0-wmf.9] Silently ignore istype-depicts image suggestion type

https://gerrit.wikimedia.org/r/920743

Caused by rEGREea8f5892bff9: Section images: Log unexpected 'kind' values from API. It's just logging an unexpected value that then gets ignored. Maybe we shouldn't log it as a production error.

Change 920743 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@wmf/1.41.0-wmf.9] Silently ignore istype-depicts image suggestion type

https://gerrit.wikimedia.org/r/920743

Mentioned in SAL (#wikimedia-operations) [2023-05-18T20:53:20Z] <urbanecm@deploy1002> Started scap: Backport for [[gerrit:920743|Silently ignore istype-depicts image suggestion type (T336962)]]

Mentioned in SAL (#wikimedia-operations) [2023-05-18T20:54:49Z] <urbanecm@deploy1002> urbanecm: Backport for [[gerrit:920743|Silently ignore istype-depicts image suggestion type (T336962)]] synced to the testservers: mwdebug1002.eqiad.wmnet, mwdebug2002.codfw.wmnet, mwdebug1001.eqiad.wmnet, mwdebug2001.codfw.wmnet

ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.9; 2023-05-15).May 18 2023, 9:00 PM

Mentioned in SAL (#wikimedia-operations) [2023-05-18T21:01:30Z] <urbanecm@deploy1002> Finished scap: Backport for [[gerrit:920743|Silently ignore istype-depicts image suggestion type (T336962)]] (duration: 08m 09s)

brennen mentioned this in T336979: Error: Typed property GrowthExperiments\NewcomerTasks\AddImage\ImageRecommendationImage::$sectionNumber must not be accessed before initialization.May 18 2023, 9:39 PM

brennen closed this task as Resolved.May 18 2023, 9:45 PM

brennen claimed this task.

brennen removed brennen as the assignee of this task.

Change 921096 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Silently ignore istype-depicts image suggestion type

https://gerrit.wikimedia.org/r/921096

ReleaseTaggerBot edited projects, added MW-1.41-notes (1.41.0-wmf.10; 2023-05-23); removed MW-1.41-notes (1.41.0-wmf.9; 2023-05-15).May 19 2023, 11:00 AM

Maintenance_bot removed a project: Patch-For-Review.May 19 2023, 11:10 AM

brennen removed Release Version.May 21 2023, 5:10 AM