Page MenuHomePhabricator
Create Task
Maniphest T330215

1.41.0-wmf.9 deployment blockers
Closed, ResolvedPublic5 Estimated Story PointsRelease
Actions

Details

Backup Train Conductor
hashar
Release Version
1.41.0-wmf.9
Release Date
May 15 2023, 12:00 AM

2023 week 20 1.41-wmf.9 Changes wmf/1.41.0-wmf.9

This MediaWiki Train Deployment is scheduled for the week of Monday, May 15th:

Monday May 15thTuesday, May 16thWednesday, May 17thThursday, May 18thFriday
Backports only.Branch wmf.9 and deploy to Group 0 Wikis.Deploy wmf.9 to Group 1 Wikis.Deploy wmf.9 to all Wikis.No deployments on fridays

How this works

  • Any serious bugs affecting wmf.9 should be added as subtasks beneath this one.
  • Any open subtask(s) block the train from moving forward. This means no further deployments until the blockers are resolved.
  • If something is serious enough to warrant a rollback then you should bring it to the attention of deployers on the #wikimedia-operations IRC channel.
  • If you have a risky change in this week's train add a comment to this task using the Risky patch template
  • For more info about deployment blockers, see Holding the train.

Related Links

Other Deployments

Previous: 1.41.0-wmf.8
Next: 1.41.0-wmf.10
SubjectRepoBranchLines +/-
group2 wikis to 1.41.0-wmf.9operations/mediawiki-configmaster+871 -871
group0 wikis to 1.41.0-wmf.9operations/mediawiki-configmaster+871 -871
group2 wikis to 1.41.0-wmf.9operations/mediawiki-configmaster+327 -327
group2 wikis to 1.41.0-wmf.8operations/mediawiki-configmaster+327 -327
group2 wikis to 1.41.0-wmf.9operations/mediawiki-configmaster+327 -327
group1 wikis to 1.41.0-wmf.9operations/mediawiki-configmaster+545 -545
group0 wikis to 1.41.0-wmf.9operations/mediawiki-configmaster+131 -131
testwikis wikis to 1.41.0-wmf.9operations/mediawiki-configmaster+4 -4
Branch commit for wmf/1.41.0-wmf.9mediawiki/corewmf/1.41.0-wmf.9+991 -3
Customize query in gerrit

Related Objects
Search...

Event Timeline

thcipriani created this task.Feb 21 2023, 5:57 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 21 2023, 5:57 PM
thcipriani assigned this task to dancy.May 11 2023, 8:01 PM
thcipriani triaged this task as Medium priority.
thcipriani updated Other Assignee, added: hashar.
thcipriani set the point value for this task to 5.
thcipriani added a project: Release-Engineering-Team (They Live 🕶️🧟).
thcipriani moved this task from Backlog to Ready on the Release-Engineering-Team (They Live 🕶️🧟) board.
hashar mentioned this in T336686: Train blocker task has wrong navigation to previous train.May 15 2023, 4:23 PM
gerritbot added a comment.May 16 2023, 2:08 AM

Change 919383 had a related patch set uploaded (by TrainBranchBot; author: trainbranchbot):

[mediawiki/core@wmf/1.41.0-wmf.9] Branch commit for wmf/1.41.0-wmf.9

https://gerrit.wikimedia.org/r/919383

gerritbot added a project: Patch-For-Review.May 16 2023, 2:08 AM
gerritbot added a comment.May 16 2023, 2:24 AM

Change 919383 merged by jenkins-bot:

[mediawiki/core@wmf/1.41.0-wmf.9] Branch commit for wmf/1.41.0-wmf.9

https://gerrit.wikimedia.org/r/919383

gerritbot added a comment.May 16 2023, 3:01 AM

Change 919934 had a related patch set uploaded (by TrainBranchBot; author: MediaWiki PreSync):

[operations/mediawiki-config@master] testwikis wikis to 1.41.0-wmf.9

https://gerrit.wikimedia.org/r/919934

gerritbot added a comment.May 16 2023, 3:02 AM

Change 919934 merged by jenkins-bot:

[operations/mediawiki-config@master] testwikis wikis to 1.41.0-wmf.9

https://gerrit.wikimedia.org/r/919934

Stashbot added a comment.May 16 2023, 3:02 AM

Mentioned in SAL (#wikimedia-operations) [2023-05-16T03:02:46Z] <mwpresync@deploy1002> Started scap: testwikis wikis to 1.41.0-wmf.9 refs T330215

Stashbot added a comment.May 16 2023, 3:51 AM

Mentioned in SAL (#wikimedia-operations) [2023-05-16T03:51:34Z] <mwpresync@deploy1002> Finished scap: testwikis wikis to 1.41.0-wmf.9 refs T330215 (duration: 48m 47s)

gerritbot added a comment.May 16 2023, 6:14 PM

Change 920362 had a related patch set uploaded (by TrainBranchBot; author: Ahmon Dancy):

[operations/mediawiki-config@master] group0 wikis to 1.41.0-wmf.9

https://gerrit.wikimedia.org/r/920362

gerritbot added a comment.May 16 2023, 6:15 PM

Change 920362 merged by jenkins-bot:

[operations/mediawiki-config@master] group0 wikis to 1.41.0-wmf.9

https://gerrit.wikimedia.org/r/920362

Stashbot added a comment.May 16 2023, 6:34 PM

Mentioned in SAL (#wikimedia-operations) [2023-05-16T18:34:18Z] <dancy@deploy1002> rebuilt and synchronized wikiversions files: group0 wikis to 1.41.0-wmf.9 refs T330215

hashar subscribed.May 17 2023, 9:49 AM

I have done a bit of log triage and there is nothing new showing up in the server side error logs. That is encouraging I guess.

Stashbot added a comment.May 17 2023, 6:03 PM

Mentioned in SAL (#wikimedia-operations) [2023-05-17T18:03:36Z] <brennen> train 1.41.0-wmf.9 (T330215): no current blockers, rolling to group1 as backup-backup conductor

gerritbot added a comment.May 17 2023, 6:19 PM

Change 920763 had a related patch set uploaded (by TrainBranchBot; author: Brennen Bearnes):

[operations/mediawiki-config@master] group1 wikis to 1.41.0-wmf.9

https://gerrit.wikimedia.org/r/920763

gerritbot added a comment.May 17 2023, 6:20 PM

Change 920763 merged by jenkins-bot:

[operations/mediawiki-config@master] group1 wikis to 1.41.0-wmf.9

https://gerrit.wikimedia.org/r/920763

Stashbot added a comment.May 17 2023, 6:27 PM

Mentioned in SAL (#wikimedia-operations) [2023-05-17T18:27:44Z] <brennen@deploy1002> rebuilt and synchronized wikiversions files: group1 wikis to 1.41.0-wmf.9 refs T330215

Stashbot added a comment.May 17 2023, 6:34 PM

Mentioned in SAL (#wikimedia-operations) [2023-05-17T18:34:07Z] <brennen@deploy1002> Synchronized php: group1 wikis to 1.41.0-wmf.9 refs T330215 (duration: 06m 22s)

brennen changed the task status from Open to In Progress.May 18 2023, 3:58 PM
brennen claimed this task.
brennen added a project: User-brennen.
brennen added subscribers: dancy, brennen.

Taking over train ops for the day.

gerritbot added a comment.May 18 2023, 6:09 PM

Change 921079 had a related patch set uploaded (by TrainBranchBot; author: Brennen Bearnes):

[operations/mediawiki-config@master] group2 wikis to 1.41.0-wmf.9

https://gerrit.wikimedia.org/r/921079

gerritbot added a comment.May 18 2023, 6:10 PM

Change 921079 merged by jenkins-bot:

[operations/mediawiki-config@master] group2 wikis to 1.41.0-wmf.9

https://gerrit.wikimedia.org/r/921079

Stashbot added a comment.May 18 2023, 6:18 PM

Mentioned in SAL (#wikimedia-operations) [2023-05-18T18:18:22Z] <brennen@deploy1002> rebuilt and synchronized wikiversions files: group2 wikis to 1.41.0-wmf.9 refs T330215

brennen changed the task status from In Progress to Open.May 18 2023, 6:29 PM

Changing status back here since it messes with scap train.

gerritbot added a comment.May 18 2023, 6:30 PM

Change 921083 had a related patch set uploaded (by TrainBranchBot; author: Brennen Bearnes):

[operations/mediawiki-config@master] group2 wikis to 1.41.0-wmf.8

https://gerrit.wikimedia.org/r/921083

gerritbot added a comment.May 18 2023, 6:31 PM

Change 921083 merged by jenkins-bot:

[operations/mediawiki-config@master] group2 wikis to 1.41.0-wmf.8

https://gerrit.wikimedia.org/r/921083

brennen mentioned this in T336962: UnexpectedValueException: Unknown image suggestions API kind: istype-depicts.May 18 2023, 6:40 PM
brennen added a subtask: T336962: UnexpectedValueException: Unknown image suggestions API kind: istype-depicts.
brennen mentioned this in T336964: InvalidArgumentException: Data for lt_namespace and lt_title must be non-empty.May 18 2023, 6:47 PM
brennen added a subtask: T336964: InvalidArgumentException: Data for lt_namespace and lt_title must be non-empty.
Stashbot added a comment.May 18 2023, 6:50 PM

Mentioned in SAL (#wikimedia-operations) [2023-05-18T18:50:28Z] <brennen@deploy1002> rebuilt and synchronized wikiversions files: group2 wikis to 1.41.0-wmf.8 refs T330215

Nux subscribed.May 18 2023, 8:46 PM

Not sure if related but I see WD is on 1.41.0-wmf.9 (bacc43a)
https://www.wikidata.org/wiki/Special:Version

And T336952 looks like a Lua problem connected with WD. Our module (https://pl.wikipedia.org/wiki/Modu%C5%82:Kontrola_autorytatywna) does some mw.wikibase operations.

So possibly a blocker?

brennen added a comment.May 18 2023, 8:52 PM

So possibly a blocker?

I see the original stack trace there is for wmf.8, so I think that one is unlikely to be a result of the wmf.9 train.

brennen added a subscriber: TheresNoTime.May 18 2023, 8:53 PM

I see the original stack trace there is for wmf.8, so I think that one is unlikely to be a result of the wmf.9 train.

...oh, unless it's trickling up from a change to Wikidata. Yeah, possibly? @TheresNoTime, any thoughts?

gerritbot added a comment.May 18 2023, 9:23 PM

Change 921104 had a related patch set uploaded (by TrainBranchBot; author: Brennen Bearnes):

[operations/mediawiki-config@master] group2 wikis to 1.41.0-wmf.9

https://gerrit.wikimedia.org/r/921104

gerritbot added a comment.May 18 2023, 9:24 PM

Change 921104 merged by jenkins-bot:

[operations/mediawiki-config@master] group2 wikis to 1.41.0-wmf.9

https://gerrit.wikimedia.org/r/921104

brennen added a comment.May 18 2023, 9:25 PM

I'm going ahead with the train to group2, since that won't change the state of Wikidata, but if T336952 should in fact block, let me know and we can re-evaluate.

Stashbot added a comment.May 18 2023, 9:31 PM

Mentioned in SAL (#wikimedia-operations) [2023-05-18T21:31:15Z] <brennen@deploy1002> rebuilt and synchronized wikiversions files: group2 wikis to 1.41.0-wmf.9 refs T330215

Umherirrender closed subtask T336964: InvalidArgumentException: Data for lt_namespace and lt_title must be non-empty as Resolved.May 18 2023, 9:35 PM
brennen mentioned this in T336979: Error: Typed property GrowthExperiments\NewcomerTasks\AddImage\ImageRecommendationImage::$sectionNumber must not be accessed before initialization.May 18 2023, 9:39 PM
brennen mentioned this in T336980: InvalidArgumentException: Data for ftr_namespace and ftr_title must be non-empty.May 18 2023, 9:44 PM
brennen closed subtask T336962: UnexpectedValueException: Unknown image suggestions API kind: istype-depicts as Resolved.
brennen moved this task from Backlog to Logs/Train on the User-brennen board.May 18 2023, 9:49 PM
brennen added a subtask: T336952: Wikibase\DataModel\Services\Lookup\ReferencedEntityIdLookupException: Referenced entity id lookup failed. Tried to find a referenced entity out of Q16334295 linked from Q13406463 via P279.May 18 2023, 11:02 PM
gerritbot added a comment.May 18 2023, 11:02 PM

Change 921109 had a related patch set uploaded (by TrainBranchBot; author: Brennen Bearnes):

[operations/mediawiki-config@master] group0 wikis to 1.41.0-wmf.9

https://gerrit.wikimedia.org/r/921109

brennen added a comment.May 18 2023, 11:04 PM

Nearing end of workday here and I have obligations away from the computer, but I'm treating T336952 as a blocker and rolling back overnight. If this is an overreaction, we can correct in the morning. If nothing else it's pretty spammy.

gerritbot added a comment.May 18 2023, 11:08 PM

Change 921109 merged by jenkins-bot:

[operations/mediawiki-config@master] group0 wikis to 1.41.0-wmf.9

https://gerrit.wikimedia.org/r/921109

Stashbot added a comment.May 18 2023, 11:26 PM

Mentioned in SAL (#wikimedia-operations) [2023-05-18T23:26:44Z] <brennen@deploy1002> rebuilt and synchronized wikiversions files: group0 wikis to 1.41.0-wmf.9 refs T330215

Raymond subscribed.May 19 2023, 9:07 AM
hashar mentioned this in T336952: Wikibase\DataModel\Services\Lookup\ReferencedEntityIdLookupException: Referenced entity id lookup failed. Tried to find a referenced entity out of Q16334295 linked from Q13406463 via P279.May 19 2023, 9:27 AM
hashar removed a subtask: T336952: Wikibase\DataModel\Services\Lookup\ReferencedEntityIdLookupException: Referenced entity id lookup failed. Tried to find a referenced entity out of Q16334295 linked from Q13406463 via P279.May 19 2023, 1:03 PM

We have ruled out T336952: Wikibase\DataModel\Services\Lookup\ReferencedEntityIdLookupException: Referenced entity id lookup failed. Tried to find a referenced entity out of Q16334295 linked from Q13406463 via P279 being a blocker. The issue is Scribunto / Wikibase mishandling a double redirect which got introduced by an editor. The source of the issue has been fixed on wikis and there is a code fix pending reviews.

I am promoting all wikis back to 1.40.0-wmf.9 now.

gerritbot added a comment.May 19 2023, 1:08 PM

Change 921342 had a related patch set uploaded (by TrainBranchBot; author: Hashar):

[operations/mediawiki-config@master] group2 wikis to 1.41.0-wmf.9

https://gerrit.wikimedia.org/r/921342

gerritbot added a comment.May 19 2023, 1:10 PM

Change 921342 merged by jenkins-bot:

[operations/mediawiki-config@master] group2 wikis to 1.41.0-wmf.9

https://gerrit.wikimedia.org/r/921342

Stashbot added a comment.May 19 2023, 1:17 PM

Mentioned in SAL (#wikimedia-operations) [2023-05-19T13:17:30Z] <hashar@deploy1002> rebuilt and synchronized wikiversions files: group2 wikis to 1.41.0-wmf.9 refs T330215

brennen closed this task as Resolved.May 19 2023, 10:37 PM
thcipriani moved this task from Ready to Done on the Release-Engineering-Team (They Live 🕶️🧟) board.May 23 2023, 9:16 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits