Page MenuHomePhabricator
Create Task
Maniphest T339954

Function view: Alter the design to drop the tabs, and instead use a single-column view like other pages
Closed, ResolvedPublic
Actions

Assigned To
gengh
Authored By
Jdforrester-WMF
Jun 20 2023, 5:11 PM
Tags
Referenced Files
F41695940: Screen Shot 2024-01-17 at 10.32.36 AM.png
Jan 17 2024, 6:37 PM
F41695937: Screen Shot 2024-01-17 at 10.32.21 AM.png
Jan 17 2024, 6:37 PM
F41695931: Screen Shot 2024-01-17 at 10.24.39 AM.png
Jan 17 2024, 6:37 PM
F41691590: image.png
Jan 15 2024, 4:40 PM
F41691588: image.png
Jan 15 2024, 4:40 PM
F41668462: Screen Shot 2024-01-12 at 12.15.01 PM.png
Jan 12 2024, 11:30 PM
F41668460: Screen Shot 2024-01-12 at 12.14.42 PM.png
Jan 12 2024, 11:30 PM
F41668446: Screen Shot 2024-01-12 at 3.23.20 PM.png
Jan 12 2024, 11:30 PM
View All 16 Files
Subscribers
AAlhazwani-WMF
Etonkovidova
Jdforrester-WMF

Description

Description

We want to change the design of the view experience for Function pages to align with our new design for non-Function pages.

Desired behavior/Acceptance criteria

  • No tabs
  • Re-use the familiar About, Explorer, and Evaluate components from non-Function pages

Devices and Design (URLs or screenshots)

  • Desktop:
    image.png (2×3 px, 333 KB)
  • Small screens/mobile:
    image.png (2×640 px, 86 KB)

Figma file

Completion checklist

Details

SubjectRepoBranchLines +/-
Implement Function Viewer new design without tabsmediawiki/extensions/WikiLambdamaster+2 K -5 K
Customize query in gerrit

Related Objects
Search...

Event Timeline

Jdforrester-WMF created this task.Jun 20 2023, 5:11 PM
Jdforrester-WMF mentioned this in T303229: Create a design for having short descriptions on function pages.
AAlhazwani-WMF attached a referenced file: F37109382: image.png. (Show Details)Jun 20 2023, 5:28 PM
AAlhazwani-WMF updated the task description. (Show Details)Jun 21 2023, 9:19 AM
AAlhazwani-WMF updated the task description. (Show Details)Jun 21 2023, 9:38 AM
Jdforrester-WMF moved this task from To triage to To triage: Nice-to-haves on the Abstract Wikipedia team board.Jun 26 2023, 4:04 PM
AAlhazwani-WMF mentioned this in T317807: should we use fallback for input/output labels in the function viewer?.Jun 28 2023, 8:51 AM
DVrandecic triaged this task as Medium priority.Aug 2 2023, 4:09 PM
DVrandecic moved this task from To triage: Nice-to-haves to Needs Product/Design on the Abstract Wikipedia team board.
Jdforrester-WMF mentioned this in T317986: Function editor with the default component patterns.Aug 3 2023, 5:38 PM
Jdforrester-WMF mentioned this in T343400: Allow editing of "about" with less rights.
Jdforrester-WMF mentioned this in T343475: Enable linking directly to the Details tab.Aug 7 2023, 6:18 PM
AAlhazwani-WMF subscribed.Aug 10 2023, 8:34 AM

Worth checking this out as well while working on this task https://www.wikifunctions.org/wiki/Wikifunctions:Project_chat#Structured_data

AAlhazwani-WMF mentioned this in T345541: Digital Garden: Contemplate unifying multilingual information in the About Widget for types and functions as well.Sep 5 2023, 2:33 PM
AAlhazwani-WMF claimed this task.Nov 28 2023, 1:56 PM
gengh claimed this task.Dec 13 2023, 2:35 PM
gengh updated the task description. (Show Details)
Jdforrester-WMF changed the task status from Open to In Progress.Dec 13 2023, 2:37 PM
Jdforrester-WMF moved this task from Needs Product/Design to In Progress on the Abstract Wikipedia team board.
gerritbot added a comment.Dec 13 2023, 4:22 PM

Change 982853 had a related patch set uploaded (by Genoveva Galarza; author: Genoveva Galarza):

[mediawiki/extensions/WikiLambda@master] [WIP] Function Viewer redo, initial commit

https://gerrit.wikimedia.org/r/982853

gerritbot added a project: Patch-For-Review.Dec 13 2023, 4:22 PM
AAlhazwani-WMF updated the task description. (Show Details)Jan 11 2024, 12:22 PM
gerritbot added a comment.Jan 11 2024, 5:21 PM

Change 982853 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] Implement Function Viewer new design without tabs

https://gerrit.wikimedia.org/r/982853

Jdforrester-WMF moved this task from In Progress to To deploy on the Abstract Wikipedia team board.Jan 11 2024, 5:25 PM
Maintenance_bot removed a project: Patch-For-Review.Jan 11 2024, 5:31 PM
ReleaseTaggerBot added a project: MW-1.42-notes (1.42.0-wmf.14; 2024-01-16).Jan 11 2024, 6:00 PM
Etonkovidova mentioned this in T354978: [QA task] UI review for mobile Function view .Jan 12 2024, 11:18 PM
Etonkovidova subscribed.EditedJan 12 2024, 11:30 PM

What was checked in betalabs:

  • functionality of controls (add implementation/test, editing, buttons etc)
  • mobile view (super minor issues - filed as T354978) pinging @AAlhazwani-WMF for review and whether any follow-up tasks are needed.
  • viewing older versions from History

The screenshots below are for comparison/re-checking in production:

current production wmf.13betalabs
{F41668439}
Screen Shot 2024-01-12 at 12.39.58 PM.png (1×3 px, 400 KB)
Mobile:
Screen Shot 2024-01-12 at 12.29.04 PM.png (1×890 px, 108 KB)
Screen Shot 2024-01-12 at 12.34.59 PM.png (1×872 px, 142 KB)
Screen Shot 2024-01-12 at 3.23.20 PM.png (1×2 px, 295 KB)
Mobile:
Screen Shot 2024-01-12 at 12.14.42 PM.png (1×738 px, 115 KB)
Screen Shot 2024-01-12 at 12.15.01 PM.png (1×716 px, 114 KB)
AAlhazwani-WMF added a comment.Jan 15 2024, 4:40 PM

thank you @Etonkovidova! JFYI some of the screenshots are not visible because they are set as "restricted file".

image.png (1×938 px, 227 KB)
image.png (742×630 px, 109 KB)

Jdforrester-WMF moved this task from To deploy to Verify in production on the Abstract Wikipedia team board.Jan 16 2024, 10:15 PM
Etonkovidova attached a referenced file: F41668446: Screen Shot 2024-01-12 at 3.23.20 PM.png. (Show Details)Jan 17 2024, 6:10 PM
Etonkovidova attached a referenced file: F41668453: Screen Shot 2024-01-12 at 12.29.04 PM.png. (Show Details)
Etonkovidova attached a referenced file: F41668441: Screen Shot 2024-01-12 at 12.39.58 PM.png. (Show Details)
Etonkovidova closed this task as Resolved.Jan 17 2024, 6:37 PM
In T339954#9460312, @AAlhazwani-WMF wrote:

thank you @Etonkovidova! JFYI some of the screenshots are not visible because they are set as "restricted file".

image.png (1×938 px, 227 KB)
image.png (742×630 px, 109 KB)

Thx, @AAlhazwani-WMF! I keep forgetting to double-check whether all files are properly attached. Corrected now.

Checked in production, wmf.14 - looks/works as expected (for mobile UI adjustments see T354978)

new design - wmf.14old design - wmf.13
Screen Shot 2024-01-17 at 10.24.39 AM.png (1×3 px, 365 KB)
Mobile:
Screen Shot 2024-01-17 at 10.32.21 AM.png (1×844 px, 128 KB)
Screen Shot 2024-01-17 at 10.32.36 AM.png (1×848 px, 203 KB)
{F41668439}
Screen Shot 2024-01-12 at 12.39.58 PM.png (1×3 px, 400 KB)
Mobile:
Screen Shot 2024-01-12 at 12.29.04 PM.png (1×890 px, 108 KB)
Screen Shot 2024-01-12 at 12.34.59 PM.png (1×872 px, 142 KB)
Etonkovidova updated the task description. (Show Details)Jan 17 2024, 6:38 PM
Jdforrester-WMF closed subtask T343884: Move create implementation/test to a more prominent and contextual location as Resolved.Mar 7 2024, 5:00 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits