End session is updated to include temp name.

Could this also be done on Vector? The menu items are the same and we don't currently have a good way of changing them on a per-skin basis.

In T340152#9056397, @Jdlrobson wrote:

This is not ready. The estimation above was based on being able to make the change in Vector/Vector 2022 too: T340152#8957026
Specifically would it be acceptable to do this:

(If not we'll have to explore a CSS solution to hide the label inside Vector 2022 skin).

Hiya, I think this would be acceptable but would ask for it to be style to be less prominent and interactive looking, using the same styling as the username link but disabled. Also, if we have the temp username now, then the "End session: TempUsername" menu item can be updated to remove the username:

Secondly I wanted to check if this means Minerva sidebar is will also show the username menu item as well? If so, would ask if it can be rendered similarly where it's clear the username is not navigable.

Sorry I think I may have confused things. T

Secondly I wanted to check if this means Minerva sidebar is will also show the username menu item as well?

Deleting menu items is easy so that won't be rendered. Styling the menu item differently is difficult (but not impossible) due to the way we do the markup. Shipping different labels on Mobile/Desktop is most difficult.

Option 1) is the current rendering. No work needed if we want to keep it.

Option 2) The easiest thing to do would just be to remove the menu item on mobile and leave desktop untouched and rely on the username being in the banner. This is about an hours work:

Option 3) Alternatively we could change the label per your screenshot but this will have the side effect of also changing Vector 2022. This is about half a days work.

Option 4) would be restyling the label. We could try this but it's likely going to me more than the points we allocated for this ticket as we would need to refactor the menu code in the mobile site to support this. This would likely be around 3-5 days work.

Which is your preferred option?

In T340152#9069821, @Jdlrobson wrote:

Sorry I think I may have confused things. T

Secondly I wanted to check if this means Minerva sidebar is will also show the username menu item as well?

Deleting menu items is easy so that won't be rendered. Styling the menu item differently is difficult (but not impossible) due to the way we do the markup. Shipping different labels on Mobile/Desktop is most difficult.

Option 1) is the current rendering. No work needed if we want to keep it.

Option 2) The easiest thing to do would just be to remove the menu item on mobile and leave desktop untouched and rely on the username being in the banner. This is about an hours work:

Option 3) Alternatively we could change the label per your screenshot but this will have the side effect of also changing Vector 2022. This is about half a days work.

Styling the username in exit session different from link should be possible but I haven't checked.

Option 4) would be restyling the label. We could try this but it's likely going to me more than the points we allocated for this ticket as we would need to refactor the menu code in the mobile site to support this. This would likely be around 3-5 days work.

Which is your preferred option?

Hiya - I think Option 2 if I understand you correctly that the Username would not be in the mobile or desktop? Else Option 1 works if it is at all possible to change the styling.

Change 947878 had a related patch set uploaded (by Bernard Wang; author: Bernard Wang):

[mediawiki/skins/MinervaNeue@master] Remove user page from menu for temp users

https://gerrit.wikimedia.org/r/947878

Currently a popup notification appears over the user page link when a temp user account is created. Now that we are removing the user page link, i assume the tooltip should go over the temp account number in the toolbar? https://phabricator.wikimedia.org/F37393202

Change 947888 had a related patch set uploaded (by Bernard Wang; author: Bernard Wang):

[mediawiki/core@master] Avoid showing userpage link for temp accounts

https://gerrit.wikimedia.org/r/947888

Change 947890 had a related patch set uploaded (by Bernard Wang; author: Bernard Wang):

[mediawiki/skins/Vector@master] Remove unnecessary styles about temp user page

https://gerrit.wikimedia.org/r/947890

Change 947888 merged by jenkins-bot:

[mediawiki/core@master] Avoid showing userpage link for temp accounts

https://gerrit.wikimedia.org/r/947888

Change 947890 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Remove unnecessary styles about temp user page

https://gerrit.wikimedia.org/r/947890

Change 947878 merged by jenkins-bot:

[mediawiki/skins/MinervaNeue@master] Remove user page from menu for temp users

https://gerrit.wikimedia.org/r/947878

Status: ✅ PASS
Environment: Local
Minerva Patch 94b339d90595dad21bb6867f22f5fb530169b840, Thu Aug 10 21:45:47 2023 +0000
OS: macOS Ventura
Browser: Chrome
Device: MBP
Emulated Device:NA
Test Links:
Desktop: http://localhost:8080/w/index.php?title=Beer&mobileaction=toggle_view_desktop
Mobile: http://localhost:8080/w/index.php?title=Beer&mobileaction=toggle_view_mobile

✅AC1: Desktop- banner shows username, no additional reference of user name in menu
Temp user name does not show but "Log in" and "Create account" is switched along "Exit session" says "End session" when compared to the pic in the description

✅AC2: Mobile- banner shows username, no additional reference of user name in side menu
Temp user name does not show but the side menu has "Contribute" and "Nearby" missing compared to the pic in the description