Page MenuHomePhabricator

IP masking: Temp account user menu options
Closed, ResolvedPublic5 Estimated Story Points

Assigned To
Authored By
RHo
Apr 28 2023, 12:02 AM
Referenced Files
F37107519: Screenshot 2023-06-16 at 3.53.23 PM.png
Jun 16 2023, 10:53 PM
F37070374: image.png
May 26 2023, 1:57 PM
F37070370: image.png
May 26 2023, 1:57 PM
F37070368: image.png
May 26 2023, 1:57 PM
F37070366: image.png
May 26 2023, 1:57 PM
F36965009: image.png
Apr 28 2023, 12:02 AM
F36964983: image.png
Apr 28 2023, 12:02 AM
F36964967: image.png
Apr 28 2023, 12:02 AM

Description

NOTE: The new icon is provided in T335694 - please consult that.

As part of the IP Masking MVP, temporary accounts will have a different top menu compared to logged out and standard accounts.

Proposed design

Nav itemsDesktop user menuMinerva side menu
Existing user menu options - Temporary accounts should have the same user menu access as Anonymous users except for access to Echo notificationsTalk page, ContributionsHome, Random, Nearby, Settings, Donate
New menu options - Temporary accounts will have a new option to exit from the temporary account ('log out' of the temp account) and the temp username in place of the loginTemp account name (collapsed into menu at narrow width), Exit sessionTemp account name, Exit session
Proposed designVector2022
image.png (1×2 px, 1 MB)
Vector
image.png (246×2 px, 111 KB)
image.png (592×342 px, 23 KB)

Notes:

  • Temp account avatar icon design is not final and subject to change, final asset TBC.

Acceptance criteria

  • Remove login and create account links (as these will be in the banner)
  • Add exit session link
  • Add IP masked icon

Developer notes

Setup notes

Steps to replicate the issue (include links if applicable):

  • Enable IP masking ($wgAutoCreateTempUser['enabled'] = true;)
  • Make an edit on any page as an anonymous user
  • go to Minerva skin in desktop mode

Coding notes

The link / icon should be defined inside MediaWiki core. Minerva and Vector / Vector 2022 skins should then just work TM
It's possible some tweaks in Minerva/Vector may be needed to add icon CSS or to update their menu code to read directly from the value in core.

Menu item logic can be found here: https://github.com/wikimedia/mediawiki/blob/master/includes/skins/SkinTemplate.php#L776

Event Timeline

@ovasileva - I had a first pass filing this ticket, please update and separate as needed (maybe the Exit session could be its own task, etc).

LGoto set the point value for this task to 5.May 3 2023, 5:37 PM
ovasileva raised the priority of this task from Medium to High.May 3 2023, 5:42 PM

@RHo what should the IP masked username link to? the standard user page? e.g. in the example should it be /wiki/User:^2023-15498 ?

@RHo what should the IP masked username link to? the standard user page? e.g. in the example should it be /wiki/User:^2023-15498 ?

Hi @Jdlrobson - I originally envisioned it links to the user page, but added this comment on a related task for @Prtksxna to weigh in on whether it may be should not be a link at all since we likely don't want to encourage a temporary account to create a user page? Maybe @KStoller-WMF or @Niharika have opinions on link to userpage or not at all?

Another question @RHo, @Prtksxna - what should the temporary username link link to?

Oh good question. I had imagined it would link to their User page (since temp accounts in MVP won't have newcomer homepage), but maybe it should just not be a link at all as it is IP editors to make it less accessible for a temporary person to create a user page. One for @Prtksxna to weigh in on.

My obnoxious answer is that I think we should do whatever is simple and then make a change post MVP if there seems to be community preference for the opposite.

However, if removing the link is simple enough, it seems like we shouldn't link the username, for the following reasons:

  • We don't really want to encourage user page creation from temp accounts, temporary account editors shouldn't get too attached to temp accounts.
  • Temp accounts creating user pages creates additional moderation burden.
  • The user page link ends up being the largest link from the menu, despite it being a fairly useless link for temp accounts. (We could even question if the temp username is needed in the menu if it's shown in the un-dismissible temp banner).
  • An empty user page is actually a fairly confusing page for new editors

@Niharika and @Prtksxna should feel free to make a different call, that's just my suggestion.

It's going to be simpler for this to link somewhere, since currently all menu items are expected to link somewhere.

Perhaps it could link to a page explaining what a temporary account is and what the benefit of registering is? I think it not linking anywhere may be a confusing experience given the rest of the menu items are clickable.

It's going to be simpler for this to link somewhere, since currently all menu items are expected to link somewhere.

Perhaps it could link to a page explaining what a temporary account is and what the benefit of registering is? I think it not linking anywhere may be a confusing experience given the rest of the menu items are clickable.

If it is easier for it to be a link then it seems better for it to still point to the User page, but perhaps with an extra notice about not creating a page for a temp account.

Since we do have this temp status account bar now being implemented in T330510: IP masking: Make temporary account status and create account actions more prominent via a separate temp account status bar which has the username and message about temp, I agree with the suggestion from @KStoller-WMF that it may be easier to not show the username at all in the menu. How does that sound?

, I agree with the suggestion from @KStoller-WMF that it may be easier to not show the username at all in the menu. How does that sound?

This seems fine but I think we should mock this out. Would seeing "end session" be enough to indicate to the user they are logged in to a temporary account? Is knowing what your temporary username is having any usecase?

, I agree with the suggestion from @KStoller-WMF that it may be easier to not show the username at all in the menu. How does that sound?

This seems fine but I think we should mock this out. Would seeing "end session" be enough to indicate to the user they are logged in to a temporary account? Is knowing what your temporary username is having any usecase?

I guess the main usefulness is your point about anchoring to the "Exit session" call to action on mobile, since we currently anchor the "exit session" action on mobile below this user page link. I'm thinking this could be a copy change on the exit action to include the temp name, and we could also revise the 'status bar' on mobile to include the temp name as well. See proposal below:

Current mocksProposedNotes
Desktop
image.png (1×2 px, 1 MB)
image.png (2×2 px, 1 MB)
Removes User page link from personal tools menu to prevent creating junk user pages for temp accounts
Mobile temp status bar
image.png (270×370 px, 21 KB)
image.png (290×368 px, 22 KB)
Adds name in to message to be consistent with Desktop.
Mobile menu
image.png (592×342 px, 23 KB)
image.png (616×400 px, 26 KB)
Removes User page menu item (consistent with desktop), End session includes temp name.

Change 929405 had a related patch set uploaded (by Bernard Wang; author: Bernard Wang):

[mediawiki/core@master] Update personal tools menu for temp users

https://gerrit.wikimedia.org/r/929405

bwang removed bwang as the assignee of this task.Jun 15 2023, 4:35 PM
bwang subscribed.
Jdlrobson lowered the priority of this task from High to Medium.Jun 15 2023, 8:59 PM

Change 929405 merged by jenkins-bot:

[mediawiki/core@master] Update personal tools menu for temp users

https://gerrit.wikimedia.org/r/929405

Looks like the new icon is not showing @bwang

(I note that T338165 exists, but we should at least have the right markup here - it seems like it's trying to use userAnonymous icon but that icon has not been added to the page)

Screenshot 2023-06-16 at 3.53.23 PM.png (792×2 px, 144 KB)

Change 931644 had a related patch set uploaded (by Bernard Wang; author: Bernard Wang):

[mediawiki/skins/MinervaNeue@master] Update personal tools for temp users, add icon for temp users

https://gerrit.wikimedia.org/r/931644

Change 931644 merged by jenkins-bot:

[mediawiki/skins/MinervaNeue@master] Update personal tools for temp users, add icon for temp users

https://gerrit.wikimedia.org/r/931644

Note, display of the correct icon is blocked on T338165.