See screenshot 3 in the parent task.
APK link: https://github.com/wikimedia/apps-android-wikipedia/pull/4075/checks
Description
Description
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | JTannerWMF | T327534 [EPIC] Image Recommendations on Android Suggested Edits | |||
| Resolved | cooltey | T336502 Design for image recommendations main flow and actions | |||
| Resolved | Sharvaniharan | T340668 Onboarding screen for Image Recommendations. |
Event Timeline
Comment Actions
APK link: https://github.com/wikimedia/apps-android-wikipedia/pull/4075/checks
Hi @scblr ,
The full screen onboarding screen has left aligned text. Everywhere else that we have used onboarding screens, we have it as center aligned. Can we use the same?
Comment Actions
@Sharvaniharan, can you left align all onboarding screens? Also, make sure to use the right type sizes and colors 👇
Title:
- type: h2
- color: primary
Subtitle:
- type: p
- color: secondary
Disclaimer:
- type: list
- color: placeholder
Thanks! ✨
Comment Actions
Hi @scblr
Thank you for reviewing. I have fixed them here:
APK: https://github.com/wikimedia/apps-android-wikipedia/pull/4090/checks
Please make sure the onboarding screens look good in all places: Initial onboarding, descriptions editing onboarding and image recs and tags.
Comment Actions
@Sharvaniharan could you update the APK link it’s expired. Sorry for the late review!
Comment Actions
The latest APK (linked in the main task T336502#9081643) should have these changes, too.