Per Brion comment on bug 31913:
We should be having unit tests running all the query page queries to make sure they work.
As an example: Microsoft SQL does not support column alias in GROUP BY clause (bug 31913).
Description
Description
Details
Details
- Reference
- bz32118
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Open | None | T33913 GROUP BY clauses incorrect in SQL generated for special pages | |||
| Declined | None | T34118 Test special page SQL queries against supported Open Source DBs (sqlite, mysql, pgsql) | |||
| Declined | None | T39702 Cloned tables for unittests do not have references and constraints | |||
| Declined | None | T60189 Tests for LinksUpdate should respect PostgreSQL database constraints | |||
| Resolved | None | T60191 BlockTest should not fail under database constraints | |||
| Open | None | T230045 Input field in link label dialog is not focused on iOS |
Event Timeline
Comment Actions
sumanah wrote:
DJ Bauch and Ben Lobaugh are going to work on this, at least for Microsoft-related databases. It would be great if developers on other databases also wrote some unit tests.
From IRC discussion today:
<MaxSem> throw some test data at it, then call internally via the API? <blobaugh> without having the test know how to access the db itself you could do that. insert via api and retrieve via api, compare <blobaugh> sumanah: i can work with djbauch to make sure the MSSQL driver is fully tested <djbauch> Yeah, I can work with Ben on all the required MS SQL tests. <blobaugh> sumanah: is there no specification for test for dbs right now? <G_SabinoMullane> Nikerabbit: I don't think so. <MaxSem> blobaugh, first, you have to get normal tests to work on your backend <DJ Bauch> Special pages are working OK for me now on SQL Server. Even the GROUP BY stuff
Conclusion -- Ben & DJ to work on this - for MSSQL at least. if an abstract method can be ported to each we will try to find it
Comment Actions
For open source databases that are easy for us to maintain, that should be higher priority than proprietary databases (e.g. Oracle, MSSQL). I'd prefer this be split up into at least two bugs (non-proprietary and proprietary) with the proprietary ones taking lower priority.
Comment Actions
This is a decade old task. The intent at the time was to ensure that Special pages worked on various database. We now have a SQL interface to generate SQL and it should take care of any oddities. We are also down to only supporting Sqlite (for development), MySQL and PostgreSql.