Page MenuHomePhabricator

"View 1 notice" not working
Closed, DuplicatePublicBUG REPORT

Assigned To
None
Authored By
Novem_Linguae
Jul 19 2023, 5:44 PM
Referenced Files
F37143772: image.png
Jul 19 2023, 5:44 PM
F37143784: image.png
Jul 19 2023, 5:44 PM
F37143781: image.png
Jul 19 2023, 5:44 PM
F37143770: image.png
Jul 19 2023, 5:44 PM

Description

Steps to replicate the issue (include links if applicable):

  • log into account A
  • use account A on English Wikipedia to thank an edit by account B
  • log into account B. putting a screenshot below of how account B's notification tray on enwiki looks. leave it unread

image.png (422×1 px, 39 KB)

  • visit mediawikiwiki
  • click the notification tray to view your notifications
  • under "More notices from another wiki", click "View 1 notice" to try to view it

What happens?:

image.png (555×362 px, 15 KB)

image.png (288×452 px, 7 KB)

image.png (568×1 px, 41 KB)

What should have happened instead?:

  • clicking "View 1 notice" should result in an API query with count 1
  • the 1 notice should load in the front end in a way that the user can see it

Software version (skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):

  • mediawikiwiki is group 0. regression due to this week's train?

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

@Novem_Linguae I missed this mention in the train blocker task before I rolled the train to group1.

thcipriani triaged this task as Unbreak Now! priority.Jul 20 2023, 3:17 PM

Setting as UBN since it's added as a train blocker.

The only changes I see to echo for this train are by @Daimona and @Umherirrender but they're both changes to tests and I doubt they caused this regression—could this be caused by some other area of code and/or has it been like this for longer than this version?

Using the above repro instructions;

  • Cannot reproduce on the beta cluster
  • Cannot reproduce on mediawikiwiki

@Novem_Linguae could you try to reproduce this error on beta, and/or try reproducing it again?

FWIW, I think I noticed this on Monday, but I ignored it because I thought it was some thing on my end. Specifically, I did all these edits on idwiki on 17th and then came to mediawiki.org to do this edit, and if I remember correctly, the 1 notice from another wiki that showed on mw.org did not resolve for me then.

Unless my memory is off about the notice I clicked on Monday, I also suggest looking at patches from last train, just in case.

This has been around for quite a while, not a train blocker.

This has been around for quite a while, not a train blocker.

Fantastic. Thank you.

T223413: Broken (empty) cross-wiki notification when using $wgLocalHTTPProxy (e.g. on Kubernetes)

Could be getting more frequent, so if more people report it that's ground for concern. But I've seen it happening years ago.

ssastry lowered the priority of this task from Unbreak Now! to Needs Triage.Jul 20 2023, 6:36 PM

This has been around for quite a while, not a train blocker.

Out of curiosity, is there another task for this then?

(And you can check the missing notifications by visiting the indicated wiki, so it's annoying but not crippling.)

Confirmed that I'm still getting it using the combination of enwiki and mediawikiwiki. Confirmed on two accounts.

Sorry for the train false alarm. Since it was happening on a group 0 wiki and I'd never had a problem before, I figured it might be related to the train.

Will close this as a duplicate.