Page MenuHomePhabricator

Moroccan Arabic is shown as LTR in MobileFrontend's interlanguage links list
Closed, ResolvedPublic0 Estimated Story PointsBUG REPORT

Description

Moroccan Arabic is shown as LTR in MobileFrontend's interlanguage links list. It's probably because it's not in rtlLanguages.js.

QA Results - Prod

ACStatusDetails
1T342447#9066890

Event Timeline

Restricted Application added subscribers: alaa, Aklapper. · View Herald Transcript

Change 940385 had a related patch set uploaded (by Amire80; author: Amire80):

[mediawiki/extensions/MobileFrontend@master] Add several RTL languages: acm, ary, hno, ms-arab

https://gerrit.wikimedia.org/r/940385

Change 940385 merged by jenkins-bot:

[mediawiki/extensions/MobileFrontend@master] Add several RTL languages: acm, ary, hno, ms-arab

https://gerrit.wikimedia.org/r/940385

Why isn’t rtLanguages.js a generated package file? That’s exactly what generated files are for. The PHP code generating the file could go over the list of supported MediaWiki languages and generate the list on-the-fly, without the need for extra commits to the MF repo whenever a new language is added to core.

Jdlrobson subscribed.

Why isn’t rtLanguages.js a generated package file? That’s exactly what generated files are for. The PHP code generating the file could go over the list of supported MediaWiki languages and generate the list on-the-fly, without the need for extra commits to the MF repo whenever a new language is added to core.

This is a workaround for a performance issue in core. Ideally RTL information should be on the language links themselves but we had to revert https://gerrit.wikimedia.org/r/c/mediawiki/core/+/911367 due to a performance regression.

@Amire80 could you please add some QA steps so we can run this through QA next week?

This is a workaround for a performance issue in core. Ideally RTL information should be on the language links themselves but we had to revert https://gerrit.wikimedia.org/r/c/mediawiki/core/+/911367 due to a performance regression.

I believe using a generated package file could provide acceptable performance. Let’s continue at T342603: Generate the list of right-to-left languages automatically in MobileFrontend.

Edtadros subscribed.

Test Result - Prod

Status: ✅ PASS
Environment: enwiki
OS: macOS Ventura
Browser: Chrome
Device: MBP
Emulated Device:NA

Test Artifact(s):

QA Steps

✅ AC1: Moroccan Arabic should be shown as RTL in the language list.

Screenshot 2023-08-03 at 7.30.26 AM.png (1×1 px, 72 KB)

Jdlrobson claimed this task.

Thanks Edward!