We need to understand what changes, if any, are required in Nuke given the IP Masking changes which are coming.
The scope of this investigation should be to understand what technical changes are needed to retain currently functionality, and create tasks for each unit of work.
In T342785 we will extend Nuke's functionality, but this ticket should be scoped to current functionality - for example ensuring that Nuke will still work when a temporary account is entered.
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Restricted Task | |||||
| Resolved | kostajh | T294511 2021 Security Team wikireplicas audit | |||
| Declined | None | T284948 Raw IPs of logged-out users disclosed in wiki-replicas | |||
| In Progress | Niharika | T324492 Temporary accounts - MVP | |||
| Open | None | T326816 [Epic] Update features for temporary accounts | |||
| Open | None | T339244 Update Moderator Tools-owned products that may be affected by IP Masking | |||
| Resolved | kostajh | T326935 Prepare Nuke extension for IP Masking | |||
| Resolved | Scardenasmolinar | T342786 Investigate impact of IP Masking on Nuke | |||
| Resolved | jsn.sherman | T343143 Install Nuke locally for IP Masking work |
Here are some of my findings after a few days of investigation:
@Niharika @Tchanders, quick question: Nuke as-is looks for the IP address in the recentchanges table. Since the IP address will no longer be available via that table, how should we get the IP address? Can we link the temporary account with an IP address and show it in Nuke? If so, how?
Had a quick look - are you referring to the query built here? https://gerrit.wikimedia.org/g/mediawiki/extensions/Nuke/+/8895b95e3910e24b033886361f0e868abc03cf7c/includes/SpecialNuke.php#336
If so, it looks as though that's selecting the IP address as the user name from recentchanges.rc_user_text - i.e. it doesn't need an IP address of anyone whose name is not their IP address. Is that correct?
If so, then there won't be a problem here. Any IP actor that got created before we enabled temporary accounts (and therefore has their IP address as their name) would still have their IP address name in this table (and other tables). Any new actors created would simply have a non-IP address name in the rc_user_text field.
(Just for completeness, in case it helps: After temporary accounts are enabled, an anon user's IP address will no longer be visible as their username. Instead it will be stored in the CheckUser extension's tables (cu_changes etc), for 3 months. If an extension needs to look it up, it will need to add a dependency on CheckUser and look it up in those tables. After 3 months, the IP address will not be stored anywhere. That's already the case for looking up a registered user's IP address.)
Thanks for the quick answer! This has helped a lot. We wanted to know where to check for the IP address once IP masking was enabled. I will now create subtasks to adapt Nuke to IP masking (by searching in the cu_changes table).
I have created several tasks based on my findings and @Tchanders's help to migrate Nuke into the brave new world of IP masking. Moving this on to the Done column.