Page MenuHomePhabricator

Broken language selection button on non-article pages on Wikimedia wikis
Closed, ResolvedPublic0 Estimated Story PointsBUG REPORT

Description

The mw-lang-portlet dropdown is currently broken on a lot of production pages, e.g. on https://en.wikipedia.org/wiki/Wikipedia_talk:Questions (possibly depending on the namespace?). It appears to be interactive, but nothing happens when it's clicked, with no way for the user to understand why. There is no error in the JavaScript console.

Peek 2023-07-27 10-51.gif (327×723 px, 56 KB)

Note how the "文A ▼" button looks exactly the same as the "Tools ▼" button below (same colors, same size, same hover effects). The Tools button works as expected.

Expected behavior: The button should probably not even be there when there is no way a page can have other language versions, and no obvious way for a user to create a new one.

QA steps

With JS enabled and JS disabled check the behavior of the language button on :

QA Results - Beta

With JS enabled and JS disabled check the behavior of the language button on

QA Results - PROD

With JS enabled and JS disabled check the behavior of the language button on

ACStatusDetails
1Language box w/ JS
2Language box w/o JS

Event Timeline

Jdlrobson renamed this task from Broken language selection button on live Wikimedia wikis to Broken language selection button on non-article pages on Wikimedia wikis.Jul 27 2023, 11:01 PM
Jdlrobson added a subscriber: ovasileva.
Jdlrobson subscribed.

it works with JS disabled suggesting to me this is an issue in UniversalLanguageSelector.

I think the problem here was caused by d39b5c958a28fb5c ( T316559)

The button now has the class mw-interlanguage-selector-empty rather than mw-interlanguage-selector which means ULS's code does not kick in.

Either Vector 2022 should add both classes (mw-interlanguage-selector-empty and mw-interlanguage-selector ) or ULS should be updated to wire up the mw-interlanguage-selector-empty button here:
https://gerrit.wikimedia.org/g/mediawiki/extensions/UniversalLanguageSelector/+/ed96dabcdda9dc444290daa880a8a933d45c1c5e/resources/js/ext.uls.interface.js#211

Change 946966 had a related patch set uploaded (by Abijeet Patro; author: Abijeet Patro):

[mediawiki/skins/Vector@master] Display ULS vector-dropdown-content when on non-content pages

https://gerrit.wikimedia.org/r/946966

Change 946966 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Display ULS vector-dropdown-content when on non-content pages

https://gerrit.wikimedia.org/r/946966

Status: ✅ PASS
Environment: Beta
OS: macOS Ventura, Windows 11
Browser: Chrome 116, Firefox 115, Edge 115, Safari 16.6
Device: MBP
Emulated Device:Windows 11 Edge from BrowserStack
Test Links: See AC1-3

*Issues are separate from task as mentioned from Jdlrobson.*

With JS enabled and JS disabled check the behaviour of the language button on

✅AC1: https://en.wikipedia.beta.wmflabs.org/wiki/Wikipedia_talk:Questions
Extra padding only in Chrome when it's No JS

ChromeSafari, FireFox, Edge
T342845_LanguageSel_DisJS1.png (1×1 px, 293 KB)
T342845_LanguageSel_DisJS2.png (805×1 px, 168 KB)

The keyboard focus outline is darker and the Hover color is lighter on Wiki Talk than the other links.

Wiki TalkConflict/Language_test
T342845_LanguageSel_talk1.png (867×1 px, 206 KB)
T342845_LanguageSel_Nontalk.png (1×1 px, 241 KB)

✅AC2: https://en.wikipedia.beta.wmflabs.org/wiki/Conflict-title-0.14552623888152905-I%C3%B1t%C3%ABrn%C3%A2ti%C3%B4n%C3%A0liz%C3%A6ti%C3%B8n
✅AC3:https://en.wikipedia.beta.wmflabs.org/wiki/Language_test

When zooming in and out on Wiki Talk link, the language box just zooms in and out
When zooming in and out on Conflict and Language_test links, the language box moves all over the place

Language Box Doesn't Move (Wiki:Talk)Language Box Moves (Conflict/Language_test)
Jdlrobson added a subscriber: abi_.

@abi_ please see detailed QA. I don't think any of this relates to the originally reported bug, but you may want to create some new tickets based on the outcome?

@abi_ please see detailed QA. I don't think any of this relates to the originally reported bug, but you may want to create some new tickets based on the outcome?

Agreed, I'm inclined to close this task once QA on production is done and create other tasks for the issues identified during QA. I've created the following tasks:

  1. T344055: Language dropdown has extra padding in Chrome on non content pages
  2. T344053: Zooming in/out makes the language selector dropdown move around

Verifying this in production won't be possible until 16th on ca.wikipedia.org

@abi_ Before putting this as resolved, what do you think about the questions below?

Status: ✅ PASS
Environment: Prod
OS: macOS Ventura
Browser: Chrome 116, Firefox 115, Safari 16.6
Device: MBP
Emulated Device:: N/A
Test Links:
https://en.wikipedia.org/wiki/Wikipedia:Talk_page_stalker
https://en.wikipedia.org/wiki/Wawa_(company)
https://ja.wikipedia.org/wiki/%E9%9B%A8%E6%B0%B7
https://arz.wikipedia.org/wiki/%D8%A8%D9%88%D8%A7%D8%A8%D8%A9:%D8%AA%D9%88%D9%86%D8%B3
https://en.wikipedia.org/wiki/Air_jordan_XI

With JS enabled and JS disabled check the behavior of the language button on

✅AC1: Language Box w/JS

Wiki:TalkEnglish ArticleDifferent LanguageRTL
T342845_LanguageSel_NewArticle_WikiTalk.png (829×2 px, 424 KB)
T342845_LanguageSel_NewArticle_Prod1.png (712×2 px, 335 KB)
T342845_LanguageSel_NewArticle_Prod2.png (797×2 px, 432 KB)
T342845_LanguageSel_NewArticle_Prod3.png (641×1 px, 172 KB)

✅AC2: Language Box w/o JS

T342845_LanguageSel_NewArticle_Prod.png (1×2 px, 519 KB)

Questions: When you create a new article like in https://en.wikipedia.org/wiki/Air_jordan_XI, the language button does not open. Is it supposed too or if not, should it still be there?

T342845_LanguageSel_NewArticle_ButtonFail.png (1×2 px, 255 KB)

Different Words in Language Box between Beta (Add Links) and Prod (Edit Links) w/o JS

ProdBeta
T342845_LanguageSel_NewArticle_Prod.png (1×2 px, 519 KB)
T342845_LanguageSel_NewArticle_Beta.png (1×2 px, 337 KB)

Questions: When you create a new article like in https://en.wikipedia.org/wiki/Air_jordan_XI, the language button does not open. Is it supposed too or if not, should it still be there?

The fix is not yet deployed on the English Wikipedia. Once it is, the drop-down will appear to allow user's to change their language settings.

Different Words in Language Box between Beta (Add Links) and Prod (Edit Links) w/o JS

I think that is because the test page on beta (https://en.wikipedia.beta.wmflabs.org/wiki/Language_test) does not have a related Wikidata entry. I created the entity on Wikidata (https://wikidata.beta.wmflabs.org/wiki/Q626663) and the link now displays "Edit links" in the dropdown.

Thanks @abi_ for the responses! Everything else looks good and I'll move it to Resolved. Thanks again!

GMikesell-WMF removed GMikesell-WMF as the assignee of this task.
GMikesell-WMF claimed this task.

@thiemowmde here are the issues we talked about for reference. Thanks!

Test Link: https://en.wikipedia.beta.wmflabs.org/wiki/Wikipedia_talk:Questions

Edit Links when JS is disabled is too close to the border

2023-08-21_05-14-40.png (1×3 px, 1 MB)

The Tools blue outline is too close to the text

2023-08-21_09-04-05.png (1×3 px, 465 KB)