Page MenuHomePhabricator
Create Task
Maniphest T344066

Table of contents button goes transparent on hover
Closed, ResolvedPublic1 Estimated Story PointsBUG REPORT
Actions

Assigned To
ovasileva
Authored By
Jdlrobson
Aug 11 2023, 4:17 PM
Tags
Referenced Files
F42398492: screenshot 622.png
Mar 5 2024, 2:36 PM
F42076097: screenshot 302.mov.gif
Feb 24 2024, 3:02 AM
F37396325: Screenshot 2023-08-11 at 9.17.08 AM.png
Aug 11 2023, 4:17 PM
Subscribers
Aklapper
bwang
Edtadros
Iniquity
Izno
Jdlrobson
• Mabualruz

Description

Steps to replicate the issue (include links if applicable):

What happens?:
Transparent background

Screenshot 2023-08-11 at 9.17.08 AM.png (240×416 px, 21 KB)

What should have happened instead?:
No transparency

Software version (skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):

QA Results - Beta

ACStatusDetails
1✅T344066#9574180

QA Results - Prod

ACStatusDetails
1✅T344066#9601194

Details

Other Assignee
• Mabualruz
SubjectRepoBranchLines +/-
Table of contents button goes transparent on hovermediawiki/skins/Vectormaster+2 -2
Customize query in gerrit

Related Objects

Event Timeline

Jdlrobson created this task.Aug 11 2023, 4:17 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 11 2023, 4:17 PM
bwang subscribed.Aug 14 2023, 5:57 PM

this is due to our custom styles for handling the checkbox hack with codex styles. ideally we could fix this upstream with T333394 and delete our code, as I could imagine similar issues happening in Minerva

ovasileva triaged this task as Medium priority.Aug 28 2023, 2:06 PM
ovasileva edited projects, added Web-Team-Backlog (Web Team FY2023-24 Q1 Sprint 6); removed Web-Team-Backlog.
Jdlrobson edited projects, added Web-Team-Backlog (Web Team FY2023-24 Q2 Sprint 1); removed Web-Team-Backlog (Web Team FY2023-24 Q1 Sprint 6).Sep 11 2023, 9:48 PM
Jdlrobson moved this task from Incoming to Table of Contents on the Desktop Improvements (Vector 2022) board.Oct 2 2023, 6:40 PM
ovasileva edited projects, added Web-Team-Backlog (Web Team FY2023-24 Q2 Sprint 3); removed Web-Team-Backlog (Web Team FY2023-24 Q2 Sprint 1).Oct 11 2023, 3:46 PM
Jdlrobson edited projects, added Web-Team-Backlog (Web Team FY2023-24 Q2 Sprint 4); removed Web-Team-Backlog (Web Team FY2023-24 Q2 Sprint 3).Nov 6 2023, 6:57 PM
Jdlrobson set the point value for this task to 1.Nov 9 2023, 6:59 PM
Jdlrobson edited projects, added Web-Team-Backlog (FY2023-24 Q2 Sprint 5); removed Web-Team-Backlog (Web Team FY2023-24 Q2 Sprint 4).Nov 20 2023, 6:38 PM
Jdlrobson moved this task from Incoming to Doing on the Web-Team-Backlog (FY2023-24 Q2 Sprint 5) board.Nov 30 2023, 7:03 PM
Jdlrobson moved this task from Doing to Incoming on the Web-Team-Backlog (FY2023-24 Q2 Sprint 5) board.Nov 30 2023, 7:06 PM
Jdlrobson edited projects, added Web-Team-Backlog (FY2023-24 Q3 Sprint 1); removed Web-Team-Backlog (FY2023-24 Q2 Sprint 5).Dec 4 2023, 8:46 PM
Jdlrobson moved this task from Incoming to Ready for Development on the Web-Team-Backlog (FY2023-24 Q3 Sprint 1) board.Jan 4 2024, 12:21 AM
ovasileva moved this task from Ready for Development to Incoming on the Web-Team-Backlog (FY2023-24 Q3 Sprint 1) board.Jan 4 2024, 12:34 PM
Jdlrobson edited projects, added Web-Team-Backlog (FY2023-24 Q3 Sprint 2); removed Web-Team-Backlog (FY2023-24 Q3 Sprint 1).Jan 16 2024, 6:08 PM
Jdlrobson edited projects, added Web-Team-Backlog (FY2023-24 Q3 Sprint 3); removed Web-Team-Backlog (FY2023-24 Q3 Sprint 2).Jan 29 2024, 7:02 PM
Jdlrobson moved this task from Incoming to Ready for Development on the Web-Team-Backlog (FY2023-24 Q3 Sprint 3) board.Feb 1 2024, 7:24 PM
Jdlrobson moved this task from Ready for Development to Incoming on the Web-Team-Backlog (FY2023-24 Q3 Sprint 3) board.
Jdlrobson merged a task: T356603: Menu button becomes transparent on hover in Vector 2022.Feb 5 2024, 3:31 PM
Jdlrobson added subscribers: Iniquity, Izno.
Jdlrobson moved this task from Incoming to Ready for Development on the Web-Team-Backlog (FY2023-24 Q3 Sprint 3) board.Feb 8 2024, 12:35 AM
• Mabualruz moved this task from Ready for Development to Doing on the Web-Team-Backlog (FY2023-24 Q3 Sprint 3) board.Feb 20 2024, 5:29 PM
• Mabualruz updated Other Assignee, added: • Mabualruz.
bwang added a comment.Feb 21 2024, 7:38 PM

Can be fixed with https://phabricator.wikimedia.org/T333394

Jdlrobson added a subscriber: • Mabualruz.Feb 21 2024, 11:23 PM

The fix here should is assumed to be trivial so we should address this as planned for now (even if we remove that code later).
@Mabualruz any updates on this ticket? Please move back to todo if you are unable to commit to a patch by tomorrow.

Jdlrobson assigned this task to • Mabualruz.Feb 21 2024, 11:24 PM
• Mabualruz added a comment.Feb 22 2024, 5:17 PM

I can't Find a css solution When I set opacity the text disappears

Jdlrobson added a comment.Feb 22 2024, 5:28 PM

Can you put a background on .vector-page-titlebar-toc ?

gerritbot added a comment.Feb 22 2024, 6:19 PM

Change 1005535 had a related patch set uploaded (by Mabualruz; author: Mabualruz):

[mediawiki/skins/Vector@master] Table of contents button goes transparent on hover

https://gerrit.wikimedia.org/r/1005535

gerritbot added a project: Patch-For-Review.Feb 22 2024, 6:19 PM
• Mabualruz reassigned this task from • Mabualruz to bwang.Feb 22 2024, 6:22 PM
• Mabualruz moved this task from Doing to Code Review on the Web-Team-Backlog (FY2023-24 Q3 Sprint 3) board.
bwang reassigned this task from bwang to Edtadros.Feb 23 2024, 7:23 PM
bwang moved this task from Code Review to QA on the Web-Team-Backlog (FY2023-24 Q3 Sprint 3) board.
gerritbot added a comment.Feb 23 2024, 7:56 PM

Change 1005535 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Table of contents button goes transparent on hover

https://gerrit.wikimedia.org/r/1005535

ReleaseTaggerBot added a project: MW-1.42-notes (1.42.0-wmf.20; 2024-02-27).Feb 23 2024, 8:00 PM
Maintenance_bot removed a project: Patch-For-Review.Feb 23 2024, 8:31 PM
Edtadros removed Edtadros as the assignee of this task.Feb 24 2024, 3:02 AM
Edtadros moved this task from QA to Ready for Signoff on the Web-Team-Backlog (FY2023-24 Q3 Sprint 3) board.
Edtadros subscribed.

Test Result - Beta

Status: ✅ PASS
Environment: beta
OS: macOS Sonoma
Browser: Chrome
Device: MBA
Emulated Device:NA

Test Artifact(s):

QA Steps

Visit https://en.wikipedia.beta.wmflabs.org/wiki/Hooded_skunk?vectorzebradesign=1 on beta or https://en.wikipedia.org/wiki/Second_War_of_Scottish_Independence?vectorzebradesign=1 on production
Resize browser <1000px
Make sure table of contents is docked
Hover over TOC button
✅ AC1: There should be no transparency

screenshot 302.mov.gif (916×778 px, 688 KB)

Edtadros updated the task description. (Show Details)Feb 24 2024, 3:08 AM
ovasileva closed this task as Resolved.Feb 26 2024, 10:21 AM
ovasileva claimed this task.
Edtadros added a project: Verified.Mar 5 2024, 2:36 PM

Test Result - Prod

Status: ✅ PASS
Environment: enwiki
OS: macOS Sonoma
Browser: Chrome
Device: MBA
Emulated Device:NA

Test Artifact(s):

QA Steps

Visit https://en.wikipedia.beta.wmflabs.org/wiki/Hooded_skunk?vectorzebradesign=1 on beta or https://en.wikipedia.org/wiki/Second_War_of_Scottish_Independence?vectorzebradesign=1 on production
Resize browser <1000px
Make sure table of contents is docked
Hover over TOC button
✅ AC1: There should be no transparency

screenshot 622.png (369×979 px, 129 KB)

Edtadros updated the task description. (Show Details)Mar 5 2024, 2:36 PM
Edtadros mentioned this in T358383: Verify 1.42.0-wmf.20 deployment.Mar 5 2024, 2:52 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits