Page MenuHomePhabricator

Migrate metrics-platform repo to GitLab
Open, LowPublic8 Estimated Story Points

Description

Details

ReferenceSource BranchDest BranchAuthorTitle
repos/data-engineering/metrics-platform!2gitlab-urlsmainphuedxReplace Gerrit URLs with GitLab URLs
Customize query in GitLab

Event Timeline

thcipriani triaged this task as Medium priority.Tue, Sep 5, 3:13 PM

Looks like we're running a series of test entrypoints (npm, composer, maven, and swift). Release-Engineering-Team can help with translating these from Gerrit/Zuul → GitLab. We'd need some support and consulting time to ensure they're working as they were before.

VirginiaPoundstone lowered the priority of this task from Medium to Low.Tue, Sep 12, 1:47 PM

Change 958901 had a related patch set uploaded (by Phuedx; author: Phuedx):

[mediawiki/extensions/EventLogging@master] modules/lib: Use GitLab URL for lib/metrics-platform

https://gerrit.wikimedia.org/r/958901

The wikimedia/metrics-platform Packagist project is now being published to from GitLab. Thanks, @Reedy!

@thcipriani: Is there anything to be done with the mirror on GitHub?

@thcipriani: Is there anything to be done with the mirror on GitHub?

It's an interesting question more widely too...

Do we want to keep them? Have we got ways to make the replication work currently (ideally gitlab -> github, without going via gerrit)?

I've reconfigured the wikimedia/metrics-platform package at https://packagist.org/packages/wikimedia/metrics-platform back from GitLab to github.com because it seems one of GitLab and Composer doesn'tt support the other to produce a dist package, and thus rebuilding mediawiki-bendor became a mess even for older versions.

https://gerrit.wikimedia.org/r/c/mediawiki/vendor/+/960127/1

Afaik we're not supposed to use GitLab for production MediaWiki platform repositories yet, which libraries are a part of. In any event, this one didn't work. Maybe there's a way it can work. I've reverted it in order to unbreak mediawiki-vendor.

@thcipriani: Is there anything to be done with the mirror on GitHub?

It's an interesting question more widely too...

Do we want to keep them? Have we got ways to make the replication work currently (ideally gitlab -> github, without going via gerrit)?

We do want to keep them. For visibility and internet points purposes.

There are ways to make it work in GitLab (owners can mirror under https://gitlab.wikimedia.org/repos/data-engineering/metrics-platform/-/settings/repository ). But, as part of archiving, we have to change the phabricator remote to stop mirroring gerrit, having that as a central place to mirror seems like an easier path.


I've reconfigured the wikimedia/metrics-platform package at https://packagist.org/packages/wikimedia/metrics-platform back from GitLab to github.com because it seems one of GitLab and Composer doesn'tt support the other to produce a dist package, and thus rebuilding mediawiki-bendor became a mess even for older versions.

https://gerrit.wikimedia.org/r/c/mediawiki/vendor/+/960127/1

Afaik we're not supposed to use GitLab for production MediaWiki platform repositories yet, which libraries are a part of. In any event, this one didn't work. Maybe there's a way it can work. I've reverted it in order to unbreak mediawiki-vendor.

Odd. GitLab can produce a zip (in this case: https://gitlab.wikimedia.org/api/v4/projects/1618/repository/archive.zip?sha=main )

This might have something to do with the gitlab-domains variable. Looking at the source code it seems to know how to handle github.com and gitlab.com based on the host url, but with self-hosted gitlab installs it seems to need that config (see updateDistReference in composer source)

But, as part of archiving, we have to change the phabricator remote to stop mirroring gerrit, having that as a central place to mirror seems like an easier path.

This should be done now. Phabricator is observing GitLab and mirroring to GitHub (or, at least, that's how it's now configured—I'll keep an eye on it to see if it works).

I've reconfigured the wikimedia/metrics-platform package at https://packagist.org/packages/wikimedia/metrics-platform back from GitLab to github.com because it seems one of GitLab and Composer doesn'tt support the other to produce a dist package, and thus rebuilding mediawiki-bendor became a mess even for older versions.

Thanks.

Afaik we're not supposed to use GitLab for production MediaWiki platform repositories yet…

Is this policy documented somewhere I can reference? Also, does it cover development? If so, then we'll revert back to using Gerrit quickly and easily.