Page MenuHomePhabricator

Participants tab - notify organisers of data retention policy
Closed, ResolvedPublic

Description

Acceptance criteria
  • Given an organiser is viewing the participants tab
  • And participant responses are shown in the participants table
  • Then a button with the "info" icon will be visible
  • And its label should be "Data retention information"
  • And when the button is clicked, a popup is shown containing this text:

Individual participants' responses displayed on the table will be aggregated and then deleted, either 90 days after submission or at the end of the event (whichever comes first). The aggregated responses will be available in the "Response statistics" tab, which will become visible after the event ends.

Design

Design specs

Screenshot 2023-07-27 at 13.32.30.png (1×2 px, 432 KB)

Event Timeline

Current copy:
Individual participants’ responses shown on the table will be aggregated and then deleted 90 days after they were submitted or at the end of the event whichever comes first. The aggregated responses will be available on Response statistics tab.

Modified to specify that the Response statistics tab becomes visible at the end of the event though it makes the copy longer:
Individual participants' responses displayed on the table will be aggregated and then deleted either 90 days after submission or at the end of the event, whichever comes first. The aggregated responses will be available in the 'Response statistics' tab, which will become visible after the event has ended.

cc @ifried

@gonyeahialam: I think the modified version is more clear, and I generally like it. I just made a few tweaks. What do you think? See below:

Individual participants' responses displayed on the table will be aggregated and then deleted, either 90 days after submission or at the end of the event (whichever comes first). The aggregated responses will be available in the Response statistics tab, which will become visible after the event ends.

@gonyeahialam: I think the modified version is more clear, and I generally like it. I just made a few tweaks. What do you think? See below:

Individual participants' responses displayed on the table will be aggregated and then deleted, either 90 days after submission or at the end of the event (whichever comes first). The aggregated responses will be available in the Response statistics tab, which will become visible after the event ends.

It is good. We can go ahead with it.

@ifried One minor question about the copy. If "Response statistics" is meant to be the same as the tab name, should it be in quotes? And if not, I assume the "R" should not be capitalised, right?

Also: we need a label for the info button that describes what the button is for.

Change 957777 had a related patch set uploaded (by Daimona Eaytoy; author: Daimona Eaytoy):

[mediawiki/extensions/CampaignEvents@master] [WIP] PQ retention info for organizers

https://gerrit.wikimedia.org/r/957777

Also: we need a label for the info button that describes what the button is for.

Response statistics can be in quotes. The R should be capitalized since it relates to a specific title.
The label for the info button will be: Data retention information

Also: we need a label for the info button that describes what the button is for.

Response statistics can be in quotes. The R should be capitalized since it relates to a specific title.
The label for the info button will be: Data retention information

Thanks, SGTM! @ifried may I update the AC with this?

@Daimona, thanks for this heads-up! I have updated the AC.

Daimona changed the task status from Stalled to Open.Sep 28 2023, 12:58 PM

(Blocked on r951979 which introduces some code needed for this task)

Change 957777 merged by jenkins-bot:

[mediawiki/extensions/CampaignEvents@master] Show data retention info in the participants tab

https://gerrit.wikimedia.org/r/957777

Given an organiser is viewing the participants tab
✅ A button with the "info" icon will be visible

Screenshot 2023-10-17 at 3.08.29 PM.png (656×1 px, 63 KB)

Note: Arabic wikipedia uses a different info icon.

Screenshot 2023-10-17 at 3.20.54 PM.png (372×734 px, 30 KB)


✅ And its label should be "Data retention information"

Screenshot 2023-10-17 at 2.27.29 PM.png (814×1 px, 193 KB)


✅ And when the button is clicked, a popup is shown containing this text:

Individual participants' responses displayed on the table will be aggregated and then deleted, either 90 days after submission or at the end of the event (whichever comes first). The aggregated responses will be available in the "Response statistics" tab, which will become visible after the event ends.

Screenshot 2023-10-17 at 3.09.54 PM.png (514×878 px, 95 KB)

❓ This is not displaying for events that already exist. I think this is likely fine since participant questions is not in prod yet, but checking here to make sure: an example here @Daimona.

Screenshot 2023-10-17 at 2.08.50 PM.png (652×1 px, 65 KB)


❓ One more note, Data retention information icon is in focus (see outline around the element) any time the user clicks on the Participants tab from another tab. I don't feel that it should be, but was this intentional? See below gif of this example :

Screen Recording 2023-10-17 at 3.14.00 PM.gif (1×2 px, 812 KB)

This is not displaying for events that already exist.

Yes, indeed, the AC are not very accurate. The information is only shown if the participant questions feature is enabled, the event has questions enabled, the event has not ended, and you can see the non-PII responses in the table. IOW, the notice is shown iff we also display participant answers in the table below. This is not written explicitly in the AC, so let me update them.

Data retention information icon is in focus (see outline around the element) any time the user clicks on the Participants tab from another tab

That's the default behaviour in OOUI where it auto-focuses the first clickable element of each tab when you select that tab. We can disable that if we want to.

Data retention information icon is in focus (see outline around the element) any time the user clicks on the Participants tab from another tab

That's the default behaviour in OOUI where it auto-focuses the first clickable element of each tab when you select that tab. We can disable that if we want to.

I don't think this is needed.

Data retention information icon is in focus (see outline around the element) any time the user clicks on the Participants tab from another tab

That's the default behaviour in OOUI where it auto-focuses the first clickable element of each tab when you select that tab. We can disable that if we want to.

I don't think this is needed.

Just to confirm, you mean that we don't need to auto-focus the first element in each tab, right? If so, this should be a separate task.

✅ Icon is displaying correctly when the participant questions feature is enabled, the event has questions enabled, the event has not ended, and you can see the non-PII responses in the table.

before ended T345353 .png (1×2 px, 335 KB)

✅ Icon not displaying after the event ended, but before the event is aggregated:

after ended.png (1×2 px, 265 KB)

✅ Icon not displaying after the event ended, and after the event is aggregated:

Screenshot 2023-10-18 at 8.07.53 AM.png (358×1 px, 50 KB)


I created T349218 to deal with the autofocus in the tabs. Sending to design sign off

OK, thanks, task created: T349217.

Ah I think we did this at the same time! I will close T349218 and we can use T349217

OK, thanks, task created: T349217.

Ah I think we did this at the same time! I will close T349218 and we can use T349217

Jinx :D Thank you!