Disambig previews not working when a summary cannot be generated
Closed, ResolvedPublic2 Estimated Story PointsBUG REPORT
Actions

Assigned To

Authored By

	Nux
	Sep 18 2023, 7:33 PM

Description

NOTE: this can be worked around by adding a paragraph of text at the top of impacted disambiguation pages but given this is never used this seems like an annoying constraint to have.

Steps to replicate the issue (include links if applicable):

Open https://pl.wikipedia.org/wiki/Karykatura
Hover "(deformacja)" (disamb page).

What happens?:

The disambiguation doesn't show because no summary exists for the preview.

What should have happened instead?:

A preview should be generated as the summary is not needed. For example:

e.g. https://en.wikipedia.org/wiki/Samuel_H._Smith

Screenshot 2023-09-20 at 5.38.33 PM.png (603×1 px, 170 KB)

Other information (browser name/version, screenshots, etc.):

User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:109.0) Gecko/20100101 Firefox/118.0

Nav Popups render:

Core preview (no preview error):

API: https://pl.wikipedia.org/api/rest_v1/page/summary/Deformacja

{"type":"disambiguation","title":"Deformacja","displaytitle":"<span class=\"mw-page-title-main\">Deformacja</span>","namespace":{"id":0,"text":""},"wikibase_item":"Q1182738","titles":{"canonical":"Deformacja","normalized":"Deformacja","display":"<span class=\"mw-page-title-main\">Deformacja</span>"},"pageid":651493,"lang":"pl","dir":"ltr","revision":"62805664","tid":"30c628a0-1284-11ee-a40b-0f7eb079083b","timestamp":"2021-03-26T20:41:20Z","description":"strona ujednoznaczniająca","description_source":"central","content_urls":{"desktop":{"page":"https://pl.wikipedia.org/wiki/Deformacja","revisions":"https://pl.wikipedia.org/wiki/Deformacja?action=history","edit":"https://pl.wikipedia.org/wiki/Deformacja?action=edit","talk":"https://pl.wikipedia.org/wiki/Dyskusja:Deformacja"},"mobile":{"page":"https://pl.m.wikipedia.org/wiki/Deformacja","revisions":"https://pl.m.wikipedia.org/wiki/Special:History/Deformacja","edit":"https://pl.m.wikipedia.org/wiki/Deformacja?action=edit","talk":"https://pl.m.wikipedia.org/wiki/Dyskusja:Deformacja"}}
,"extract":""
,"extract_html":""
}

QA Results - Beta

AC	Status	Details
1	✅	T346686#9339674

QA Results - Prod

AC	Status	Details
1	✅	T346686#9343355

Details

	Subject	Repo	Branch	Lines +/-
	Allow disambiguation previews to render when no summary found	mediawiki/extensions/Popups	master	+32 -10

Customize query in gerrit

Related Objects

Mentioned In: T300996: Disambiguation pages with empty string summary don't generate the correct Page Previews snippets
T350416: Verify 1.42.0-wmf.5 deployment
Mentioned Here: T272394: PagePreviews show unexpected error message for non-empty pages
T345829: Regression: Setting icon in ReferencePreview popups does nothing

Event Timeline

Nux created this task.Sep 18 2023, 7:33 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 18 2023, 7:34 PM

Note, the JS error "Page previews: No settings button found in preview." is unrelated.
The error preview is showing because a summary cannot be generated for the https://pl.wikipedia.org/wiki/Deformacja page. I imagine {{Ujednoznacznienie}} is causing problems. https://www.mediawiki.org/wiki/Recommendations_for_mobile_friendly_articles_on_Wikimedia_wikis might be helpful

Reopening after further troubleshooting with @Nux as this turns out to be slightly different from T272394.

Jdlrobson updated the task description. (Show Details)Sep 21 2023, 12:42 AM

Jdlrobson moved this task from Incoming to Web Team FY2023-24 Q2 Sprint 1 on the Web-Team-Backlog board.Sep 25 2023, 5:40 PM

Jdlrobson edited projects, added Web-Team-Backlog (Web Team FY2023-24 Q2 Sprint 1); removed Web-Team-Backlog.

ovasileva triaged this task as High priority.Oct 10 2023, 8:59 AM

ovasileva lowered the priority of this task from High to Medium.Oct 12 2023, 5:28 PM

ovasileva edited projects, added Web-Team-Backlog (Web Team FY2023-24 Q2 Sprint 2); removed Web-Team-Backlog (Web Team FY2023-24 Q2 Sprint 1).

ovasileva set the point value for this task to 2.

ovasileva moved this task from Incoming to Ready for Development on the Web-Team-Backlog (Web Team FY2023-24 Q2 Sprint 2) board.Oct 12 2023, 5:48 PM

ovasileva edited projects, added Web-Team-Backlog (Web Team FY2023-24 Q2 Sprint 3); removed Web-Team-Backlog (Web Team FY2023-24 Q2 Sprint 2).Oct 23 2023, 2:59 PM

ovasileva moved this task from Incoming to Ready for Development on the Web-Team-Backlog (Web Team FY2023-24 Q2 Sprint 3) board.Nov 2 2023, 12:10 PM

Jdlrobson claimed this task.Nov 9 2023, 7:21 PM

Jdlrobson moved this task from Ready for Development to Doing on the Web-Team-Backlog (Web Team FY2023-24 Q2 Sprint 3) board.

Change 973229 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/extensions/Popups@master] Allow disambiguation previews to render when no summary found

https://gerrit.wikimedia.org/r/973229

gerritbot added a project: Patch-For-Review.Nov 9 2023, 7:43 PM

For code review / testing I used the following configuration:

wfLoadExtension('Popups');
$wgPopupsGateway = 'restbaseHTML';
$wgMFMwApiContentProviderBaseUri = "https://pl.wikipedia.org/w/api.php";
$wgPopupsRestGatewayEndpoint = 'https://pl.wikipedia.org/api/rest_v1/page/summary/';
$wgArticlePath = "/wiki/$1";

Jdlrobson assigned this task to Mabualruz.Nov 9 2023, 10:58 PM

Mabualruz moved this task from Code Review to QA on the Web-Team-Backlog (Web Team FY2023-24 Q2 Sprint 3) board.Nov 10 2023, 8:12 AM

Change 973229 merged by jenkins-bot:

[mediawiki/extensions/Popups@master] Allow disambiguation previews to render when no summary found

https://gerrit.wikimedia.org/r/973229

Maintenance_bot removed a project: Patch-For-Review.Nov 10 2023, 8:30 AM

ReleaseTaggerBot added a project: MW-1.42-notes (1.42.0-wmf.5; 2023-11-14).Nov 10 2023, 9:00 AM

Mabualruz removed Mabualruz as the assignee of this task.Nov 13 2023, 4:17 PM

Mabualruz subscribed.

Jdlrobson assigned this task to Edtadros.Nov 13 2023, 5:34 PM

Test Result - Beta

Status: ✅ PASS
Environment: beta
OS: macOS Sonoma
Browser: Chrome
Device: MBA
Emulated Device:NA

Test Artifact(s):

QA Steps

Open https://pl.wikipedia.org/wiki/Karykatura
Hover "(deformacja)" (disamb page).
✅ AC1: A preview should be generated as the summary is not needed. See task description example.

Edtadros updated the task description. (Show Details)Nov 17 2023, 2:44 AM

Looks like the fix is working

Test Result - Prod

Status: ✅ PASS
Environment: plwiki
OS: macOS Sonoma
Browser: Chrome
Device: MBA
Emulated Device:NA

Test Artifact(s):

QA Steps

Open https://pl.wikipedia.org/wiki/Karykatura
Hover "(deformacja)" (disamb page).
✅ AC1: A preview should be generated as the summary is not needed. See task description example.

Edtadros updated the task description. (Show Details)Nov 19 2023, 9:04 PM

Edtadros mentioned this in T350416: Verify 1.42.0-wmf.5 deployment.Nov 19 2023, 9:26 PM

Titore mentioned this in T300996: Disambiguation pages with empty string summary don't generate the correct Page Previews snippets.Wed, Apr 17, 6:43 PM

	F37744250: Screenshot 2023-09-20 at 5.38.33 PM.png
	Sep 21 2023, 12:41 AM

	F41520750: screenshot 264.png
	Nov 19 2023, 9:02 PM

	F41520749: screenshot 263.png
	Nov 19 2023, 9:02 PM

	F41512956: screenshot 217.png
	Nov 17 2023, 2:43 AM

Disambig previews not working when a summary cannot be generatedClosed, ResolvedPublic2 Estimated Story PointsBUG REPORTActions

Description

QA Results - Beta

QA Results - Prod

Details

Related Objects

Event Timeline

Test Result - Beta

QA Steps

Test Result - Prod

QA Steps

Disambig previews not working when a summary cannot be generated
Closed, ResolvedPublic2 Estimated Story PointsBUG REPORT
Actions