Move page view language detection logic / functions out of LanguageConverter class and stop using global state
Open, Needs TriagePublic
Actions

Assigned To

None

Authored By

	Winston_Sung
	Sep 21 2023, 5:59 AM

Description

Move page view language detection logic out of LanguageConverter class

Currently, the page view language detection logic were inside the LanguageConverter class.

This was caused by the ZhConverter was initially written as an extension.

We should make them parser options and move the detection logic out of language converter.

LanguageConverter::getPreferredVariant should be deprecated and be replaced
LanguageConverter::getURLVariant should be deprecated and be replaced
LanguageConverter::getUserVariant should be deprecated and be replaced
LanguageConverter::getHeaderVariant should be deprecated and be replaced
LanguageConverter::autoConvert should be deprecated and replaced with LanguageConverter::autoConvertTo
LanguageConverter::convert should be deprecated and replaced with LanguageConverter::convertTo
LanguageConverter::getExtraHashOptions should be deprecated and replaced

Related Objects
Search...

Status	Assigned	Task
Open	None	T267067 Make language variant a parser option
Open	None	T346996 Move page view language detection logic / functions out of LanguageConverter class and stop using global state
Resolved	Krinkle	T299369 Consider removing global $userLang from onPageContentLanguage hook
Resolved	Krinkle	T341244 ParserOptions and Title::getPageViewLanguage may disagree on the lang/dir
Resolved	DAlangi_WMF	T350806 Phase out Title::getPageViewLanguage in favour of ParserOutput metadata

Event Timeline

Winston_Sung created this task.Sep 21 2023, 5:59 AM

Winston_Sung moved this task from Backlog to Core on the MediaWiki-Language-converter board.

We will track the parent task in the main boards and move this to the feature request column, please let me know if I'm missing anything else.

I'm not sure exactly what you mean here. Could you explain further? The parent task seems to be much more concrete.

I vaguely recall we had a conversation (probably in gerrit, on a different patch?) about the concept of "page view language" and I think there were some issues there, but I don't recall precisely what/where that discussion was.

Can this bug be resolved as a duplicate of its parent?

Krinkle unsubscribed.Sep 21 2023, 3:34 PM

matmarex added a subtask: T299369: Consider removing global $userLang from onPageContentLanguage hook.Sep 23 2023, 4:11 PM

Winston_Sung renamed this task from Move page view language detection logic / functions out of LanguageConverter class to Move page view language detection logic / functions out of LanguageConverter class and stop using global state.Sep 29 2023, 3:28 AM

Winston_Sung added a project: Technical-Debt (Deprecation process).

Winston_Sung updated the task description. (Show Details)

Krinkle changed the status of subtask T299369: Consider removing global $userLang from onPageContentLanguage hook from Open to Stalled.Nov 13 2023, 5:42 PM

matmarex mentioned this in T350806: Phase out Title::getPageViewLanguage in favour of ParserOutput metadata .Dec 13 2023, 6:21 PM

matmarex changed the status of subtask T299369: Consider removing global $userLang from onPageContentLanguage hook from Stalled to Open.Jan 9 2024, 9:42 PM

matmarex closed subtask T299369: Consider removing global $userLang from onPageContentLanguage hook as Resolved.Jan 15 2024, 9:15 PM

(MediaWiki-Platform-Team has been doing related work recently in the subtasks, so we should consider whether we want to do this too, even if we may not end up working on it)

larissagaulia moved this task from Inbox, needs triage to Backlog: non-prioritized on the MediaWiki-Platform-Team board.Jan 24 2024, 12:29 PM

Krinkle edited projects, added Technical-Debt; removed Technical-Debt (Deprecation process).Mar 27 2024, 6:46 PM

Krinkle moved this task from Unsorted to Needs research on the Technical-Debt board.

Move page view language detection logic / functions out of LanguageConverter class and stop using global stateOpen, Needs TriagePublicActions

Description

Related ObjectsSearch...

Event Timeline

Move page view language detection logic / functions out of LanguageConverter class and stop using global state
Open, Needs TriagePublic
Actions

Related Objects
Search...