Update iOS app to handle multilingual campaign using new apps campaign config
Closed, ResolvedPublic
Actions

Assigned To

None

Authored By

	Tsevener
	Sep 25 2023, 8:24 PM

Description

(See parent task)

Config page:

Production: https://donate.wikimedia.org/wiki/MediaWiki:AppsCampaignConfig.json?action=raw
Staging: https://test.wikipedia.org/wiki/MediaWiki:AppsCampaignConfig.json?action=raw

Testing Notes

This can be tested starting in Wikipedia TestFlight 7.4.3 (2809) build.

Testing tips:
All new donor experience work (in-app web view, new campaign modals with maybe later, multilingual campaign support, Apple Pay native donation) are set up to become available in the app only once the Netherlands or Italy Oct/Nov 2023 campaigns become valid.

Device iOS Settings > Language & Region > Region needs to be set to either the Netherlands or Italy
Device date & time needs to be set on or after the campaign start date (change device date to 10/17)
After fresh install, you must background and foreground the app, then pull to refresh on the Explore feed to trigger a force refresh of the campaign data.
Visit an article. Campaign text is set up to display in a language dependent on the article wiki (EN wiki article will display English, NL wiki article will display Dutch, IT wiki article will display in Italian).

Related Objects
Search...

Status	Assigned	Task
Open	None	T344004 [Main Epic] Improve Donor experiences in the apps
Resolved	Tsevener	T344024 Streamline updating fundraising banner content while accommodating multilingual campaigns
Resolved	None	T347352 Update iOS app to handle multilingual campaign using new apps campaign config

Event Timeline

Tsevener claimed this task.Sep 25 2023, 8:24 PM

Tsevener triaged this task as High priority.

Tsevener created this task.

Tsevener removed a project: Wikipedia-Android-App-Backlog (Android Release - FY2023-24).

Tsevener added a project: iOS Release FY2023-24 (Archive).

Tsevener moved this task from Tasks from Product Backlog to Doing on the iOS Release FY2023-24 (Archive) board.

Tsevener added a subscriber: Dbrant.

Sync notes:

I think easiest would be to build PR off of https://github.com/wikimedia/wikipedia-ios/pull/4619, and add the ability to fetch the campaign config in WKDonateDataController's fetchConfigs method. We can save it to another static property in that class for access later. We should also cache it after fetching. We can reference the way WKWatchlistDataController uses the sharedCacheStore and/or userDefaultsStore for tips on how to do this.

Then in ArticleViewController+Announcements.swift, reference this config (load if from cache if necessary). Filter down to valid campaigns and campaign text based on countryCode (maybe based on Locale.current.regionCode, or GeoIP cookie), config asset language code (based on article wiki language code, with possibly default fallback), start / end dates, and whether or not they already dismissed the campaign ID or not. Then display announcement as we did before via wmf_showAnnouncementPanel or build a new Component based on the onboarding component.

You'll also need to persist flags per campaign ID when they dismiss so that we don't present to them again.

Tsevener updated the task description. (Show Details)Sep 25 2023, 8:54 PM

Tsevener updated the task description. (Show Details)

JTannerWMF moved this task from Needs Triage to Engineering Backlog on the Wikipedia-iOS-App-Backlog board.Sep 25 2023, 10:49 PM

Tsevener mentioned this in T346823: Implement app donation banner that allows users more control over what they see and select for iOS.Sep 26 2023, 4:22 PM

Tsevener merged a task: T346904: Start pulling campaign announcements from new donatewiki page..Sep 26 2023, 4:45 PM

Data-side PR: https://github.com/wikimedia/wikipedia-ios/pull/4645

Assigning to @Mazevedo for campaign modal UI. Please build PR off of PR above.

Tsevener reassigned this task from Tsevener to Mazevedo.Sep 29 2023, 5:41 PM

@Mazevedo seems like https://phabricator.wikimedia.org/T346823 covers the UI-portion of this (which you already have in doing), so I'm going to move this into Needs Code Review.

Tsevener removed Mazevedo as the assignee of this task.Sep 29 2023, 5:44 PM

Tsevener moved this task from Doing to Needs Code Review on the iOS Release FY2023-24 (Archive) board.

Tsevener claimed this task.Oct 2 2023, 4:44 PM

Tsevener moved this task from Needs Code Review to Waiting for Build on the iOS Release FY2023-24 (Archive) board.Oct 4 2023, 8:18 PM

Tsevener moved this task from Waiting for Build to Needs Design Review on the iOS Release FY2023-24 (Archive) board.Oct 4 2023, 8:44 PM

Tsevener moved this task from Needs Design Review to Waiting for Build on the iOS Release FY2023-24 (Archive) board.

Tsevener moved this task from Waiting for Build to Needs Code Review on the iOS Release FY2023-24 (Archive) board.Oct 11 2023, 2:21 PM

Tsevener moved this task from Needs Code Review to Waiting for Build on the iOS Release FY2023-24 (Archive) board.Oct 11 2023, 2:50 PM

Tsevener updated the task description. (Show Details)Oct 12 2023, 1:43 PM

Tsevener removed Tsevener as the assignee of this task.Oct 12 2023, 1:51 PM

Tsevener updated the task description. (Show Details)

Tsevener moved this task from Waiting for Build to Needs QA on the iOS Release FY2023-24 (Archive) board.Oct 12 2023, 1:53 PM