Special:GlobalRenameQueue should not use mediawiki ui, should use tabs
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To

Authored By

	Jdlrobson
	Sep 27 2023, 5:11 PM

Description

https://en.wikipedia.org/wiki/Special:GlobalRenameQueue/open incorrectly uses mw-ui-button-group to create a set of tabs at the top of the page.

Screenshot 2023-09-27 at 10.06.46 AM.png (134×423 px, 12 KB)

SpecialPage's support tabs natively (See https://gerrit.wikimedia.org/r/c/mediawiki/extensions/CentralNotice/+/934428 as an example of how to implement this)

Details

	Subject	Repo	Branch	Lines +/-
	SpecialGlobalRenameQueue: Swap 'mw-ui-button-group' nav to tabs/breadcrumbs	mediawiki/extensions/CentralAuth	master	+38 -35

Customize query in gerrit

Related Objects
Search...

Status	Subtype	Assigned	Task
Open		Jdlrobson	T182050 Remove all mediawiki.ui components and libraries in favor of Codex
Resolved		matmarex	T212095 CentralAuth and Flow should not use mediawiki.ui utilities classes
Resolved	BUG REPORT	matmarex	T347514 Special:GlobalRenameQueue should not use mediawiki ui, should use tabs

Event Timeline

Jdlrobson created this task.Sep 27 2023, 5:11 PM

Umherirrender edited projects, added MediaWiki-extensions-CentralAuth; removed MW-1.41-notes (1.41.0-wmf.17; 2023-07-11), MW-1.32-notes (WMF-deploy-2018-05-01 (1.32.0-wmf.2)).Sep 27 2023, 5:32 PM

Restricted Application added a project: MediaWiki-Platform-Team. · View Herald TranscriptSep 27 2023, 5:32 PM

Jdlrobson mentioned this in T182050: Remove all mediawiki.ui components and libraries in favor of Codex.Sep 27 2023, 8:23 PM

larissagaulia moved this task from Inbox, needs triage to Backlog: non-prioritized on the MediaWiki-Platform-Team board.Sep 28 2023, 7:18 AM

matmarex edited parent tasks, added: T212095: CentralAuth and Flow should not use mediawiki.ui utilities classes; removed: T182050: Remove all mediawiki.ui components and libraries in favor of Codex.Sep 30 2023, 12:01 AM

Change 962100 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/CentralAuth@master] SpecialGlobalRenameQueue: Swap 'mw-ui-button-group' nav to tabs/breadcrumbs

https://gerrit.wikimedia.org/r/962100

gerritbot added a project: Patch-For-Review.Sep 30 2023, 12:28 AM

matmarex claimed this task.Sep 30 2023, 12:29 AM

Change 962100 merged by jenkins-bot:

[mediawiki/extensions/CentralAuth@master] SpecialGlobalRenameQueue: Swap 'mw-ui-button-group' nav to tabs/breadcrumbs

https://gerrit.wikimedia.org/r/962100

Maintenance_bot removed a project: Patch-For-Review.Oct 2 2023, 11:30 PM

Thanks for the patch @matmarex, here's some notes from my testing - note the blue/gray buttons in Timeless, legacy Vector are now regular links which do not display the selected tab but they are using the standard mechanism for registering these types of pages. A future patch if needed could restore the styling for this page and other pages but I'm going to assume YAGNI unless told otherwise.

Before:

http://localhost:8888/wiki/Special:GlobalRenameQueue/closed?useskin=vector-2022

Screenshot 2023-10-02 at 4.20.49 PM.png (226×719 px, 29 KB)

http://localhost:8888/wiki/Special:GlobalRenameQueue/closed?useskin=timeless

Screenshot 2023-10-02 at 4.21.49 PM.png (440×1 px, 97 KB)

After patch

Screenshot 2023-10-02 at 4.22.31 PM.png (430×1 px, 93 KB)

Jdlrobson closed this task as Resolved.Oct 2 2023, 11:39 PM

	F37922120: Screenshot 2023-10-02 at 4.22.31 PM.png
	Oct 2 2023, 11:39 PM

	F37922123: Screenshot 2023-10-02 at 4.23.07 PM.png
	Oct 2 2023, 11:39 PM

	F37922115: Screenshot 2023-10-02 at 4.21.49 PM.png
	Oct 2 2023, 11:39 PM

	F37922112: Screenshot 2023-10-02 at 4.20.49 PM.png
	Oct 2 2023, 11:39 PM

	F37817697: Screenshot 2023-09-27 at 10.06.55 AM.png
	Sep 27 2023, 5:11 PM

	F37817695: Screenshot 2023-09-27 at 10.06.46 AM.png
	Sep 27 2023, 5:11 PM

Special:GlobalRenameQueue should not use mediawiki ui, should use tabsClosed, ResolvedPublicBUG REPORTActions