Page MenuHomePhabricator

[M] Redesign entering the author of the file for someone else's work
Closed, ResolvedPublic

Description

Context
As part of improving the release rights step of Upload Wizard on Commons T347298, we will make UX improvements to the licensing step for not own/ someone else's work.

This ticket is a subtask for T347598

Check latest prototype for estimation only (check link to UI below for implementation)

Link to UI

Acceptance Criteria

  • Input field to enter the author of the media.
  • Add the checkbox for users to indicate that they do not know the author
  • If the checkbox is selected it is not required to add anything in the input box
  • If the user clicks on the Next button without answering this question (i.e. either not having entered the author name or not selected the checkbox) then show the error message under the question as shown in this UI
  • The error message disappears at the moment the user meets the requirements i.e. enters the name in the input or selects the checkbox
  • Move this as a third question in the form after new licensing question in T347749 is added as the first question.

AI attribution

  • If the user has selected the checkbox suggesting that the media was generated using AI in the source question, change the author question to what is shown in this UI.
    • Input field to enter the AI attribution
    • Examples below the input field
    • Checkbox for users to indicate that they do not have this information
    • If the above checkbox is selected it is not required to add anything in the input box
    • If the user clicks on the next button without answer this question follow the usual flow as suggested above for original question.

Event Timeline

MarkTraceur renamed this task from Redesign entering the author of the file for someone else's work to [M] Redesign entering the author of the file for someone else's work.Oct 18 2023, 4:14 PM

Change 969382 had a related patch set uploaded (by Cparle; author: Cparle):

[mediawiki/extensions/UploadWizard@master] Update "source" and "author" ields for 3rd party licenses

https://gerrit.wikimedia.org/r/969382

@Sneha @mfossati raised the point that the error messages for the "source" and "author" in my patch are different to what's in your mockup. I can change the text of messages easily, but I also note that your error text appears below the checkbox while mine appears below the text input field.

image.png (326×795 px, 33 KB)

Validation for these text input fields is setup within the inputs themselves, and ooui has a default way of displaying them. It'd be quite a bit of work to untangle that so that we can display the errors somewhere else. If you think this is important then I can dig into it, but it would take some time so I think it'd probably be better moved to a separate ticket. In the meantime I think the original error message ("this field is required") makes more sense when it's directly below the input rather than below the checkbox

@Cparle yes it will be good to match the copy in the mocks because it is more accurate on what is required. You could chose to not enter in the field if you select the checkbox. And for that reason we should also have the error message below the checkbox as in the mock up.

@Sneha myself and @matthiasmullie have been talking about the checkboxes. If I click the "The is AI generated media" checkbox

image.png (115×762 px, 14 KB)

is it still necessary to enter a source? We think it probably should be, because if there's no source that probably means it should go in "own work", but the ACs are a bit unclear

When the user clicks on the AI checkbox in the source question, the author question changes to this where you are able to enter the source and author information together in a format proposed by community. So it is okay if the user did not enter source info in the source question when AI checkbox is checked, as that should be captured in the next question which would be mandatory (unless the user says "I do not have this information"). Also if someone still wants to enter something in the source field they can do so.

Sorry for confusion, after the discussion I realized that we do need to have the source as mandatory because it is about where the image came from and not necessarily the AI engine/prompt info that is captured in the next question.

Change 974192 had a related patch set uploaded (by Matthias Mullie; author: Matthias Mullie):

[mediawiki/extensions/UploadWizard@master] Make source input required in any case

https://gerrit.wikimedia.org/r/974192

Change 969382 merged by jenkins-bot:

[mediawiki/extensions/UploadWizard@master] Update "source" and "author" fields for 3rd party licenses

https://gerrit.wikimedia.org/r/969382

Change 974192 merged by jenkins-bot:

[mediawiki/extensions/UploadWizard@master] Make source input required in any case

https://gerrit.wikimedia.org/r/974192

Etonkovidova subscribed.

Checked in beta - all specs are in place.

Update: Adding new screenshots from betalabs.

mockupupdated betalabsold_betalabs
Screen Shot 2023-11-22 at 6.11.38 PM.png (1×1 px, 269 KB)
Screen Shot 2023-11-29 at 2.55.57 PM.png (852×1 px, 135 KB)
Screen Shot 2023-11-22 at 6.09.17 PM.png (1×1 px, 286 KB)
This comment was removed by Sneha.

Sorry for the confusion with the previous comment. Here we need to update the question to say "work" instead of "media".
The word "media" is used only in places where we are referring to more than one image or a collection since the word "media" is plural.

With the same logic I am updating the checkbox to say "This work is AI-generated". Can we capture these changes in your UI adjustment ticket T352477?

Sorry for the confusion with the previous comment. Here we need to update the question to say "work" instead of "media".
The word "media" is used only in places where we are referring to more than one image or a collection since the word "media" is plural.

With the same logic I am updating the checkbox to say "This work is AI-generated". Can we capture these changes in your UI adjustment ticket T352477?

Checked in production -commons wmf.9 - "This work is AI-generated" is present there.