Page MenuHomePhabricator
Create Task
Maniphest T348530

Less_Exception_Compiler: variable @min-width-desktop-wide is undefined in file /srv/mediawiki/php-1.41.0-wmf.30/skins/Vector/skinStyles/ext.echo.styles.alert.less in ext.echo.styles.alert.less on line 22, column 2320
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Assigned To
Jdlrobson
Authored By
hashar
Oct 10 2023, 12:26 PM
Tags
Referenced Files
F38190657: Screenshot 2023-10-10 at 12.03.35 PM.png
Oct 10 2023, 7:05 PM
F38190656: Screenshot 2023-10-10 at 12.03.30 PM.png
Oct 10 2023, 7:05 PM
Subscribers
Aklapper
hashar
Jdlrobson
ovasileva
TheresNoTime

Description

NOTE: Caused by T345766
Error
labels.normalized_message
[1c996f933eac40cde5d84a80] [no req]   Less_Exception_Compiler: variable @min-width-desktop-wide is undefined in file /srv/mediawiki/php-1.41.0-wmf.30/skins/Vector/skinStyles/ext.echo.styles.alert.less in ext.echo.styles.alert.less on line 22, column 23
20
error.stack_trace
from /srv/mediawiki/php-1.41.0-wmf.30/vendor/wikimedia/less.php/lib/Less/Tree/Variable.php(53)
#0 /srv/mediawiki/php-1.41.0-wmf.30/vendor/wikimedia/less.php/lib/Less/Tree/Expression.php(46): Less_Tree_Variable->compile(Less_Environment)
#1 /srv/mediawiki/php-1.41.0-wmf.30/vendor/wikimedia/less.php/lib/Less/Tree/Value.php(25): Less_Tree_Expression->compile(Less_Environment)
#2 /srv/mediawiki/php-1.41.0-wmf.30/vendor/wikimedia/less.php/lib/Less/Tree/Rule.php(83): Less_Tree_Value->compile(Less_Environment)
#3 /srv/mediawiki/php-1.41.0-wmf.30/vendor/wikimedia/less.php/lib/Less/Tree/Paren.php(32): Less_Tree_Rule->compile(Less_Environment)
#4 /srv/mediawiki/php-1.41.0-wmf.30/vendor/wikimedia/less.php/lib/Less/Tree/Expression.php(46): Less_Tree_Paren->compile(Less_Environment)
#5 /srv/mediawiki/php-1.41.0-wmf.30/vendor/wikimedia/less.php/lib/Less/Tree/Value.php(25): Less_Tree_Expression->compile(Less_Environment)
#6 /srv/mediawiki/php-1.41.0-wmf.30/vendor/wikimedia/less.php/lib/Less/Tree/Media.php(54): Less_Tree_Value->compile(Less_Environment)
#7 /srv/mediawiki/php-1.41.0-wmf.30/vendor/wikimedia/less.php/lib/Less/Tree/Ruleset.php(95): Less_Tree_Media->compile(Less_Environment)
#8 /srv/mediawiki/php-1.41.0-wmf.30/vendor/wikimedia/less.php/lib/Less/Tree/Ruleset.php(95): Less_Tree_Ruleset->compile(Less_Environment)
#9 /srv/mediawiki/php-1.41.0-wmf.30/vendor/wikimedia/less.php/lib/Less/Tree/Ruleset.php(95): Less_Tree_Ruleset->compile(Less_Environment)
#10 /srv/mediawiki/php-1.41.0-wmf.30/vendor/wikimedia/less.php/lib/Less/Parser.php(181): Less_Tree_Ruleset->compile(Less_Environment)
#11 /srv/mediawiki/php-1.41.0-wmf.30/includes/ResourceLoader/FileModule.php(1130): Less_Parser->getCss()
#12 /srv/mediawiki/php-1.41.0-wmf.30/includes/ResourceLoader/FileModule.php(1013): MediaWiki\ResourceLoader\FileModule->compileLessString(string, string, MediaWiki\ResourceLoader\DerivativeContext)
#13 /srv/mediawiki/php-1.41.0-wmf.30/includes/ResourceLoader/FileModule.php(989): MediaWiki\ResourceLoader\FileModule->processStyle(string, string, MediaWiki\ResourceLoader\FilePath, MediaWiki\ResourceLoader\DerivativeContext)
#14 /srv/mediawiki/php-1.41.0-wmf.30/includes/ResourceLoader/FileModule.php(967): MediaWiki\ResourceLoader\FileModule->readStyleFile(MediaWiki\ResourceLoader\FilePath, MediaWiki\ResourceLoader\DerivativeContext)
#15 /srv/mediawiki/php-1.41.0-wmf.30/includes/ResourceLoader/FileModule.php(406): MediaWiki\ResourceLoader\FileModule->readStyleFiles(array, MediaWiki\ResourceLoader\DerivativeContext)
#16 /srv/mediawiki/php-1.41.0-wmf.30/includes/ResourceLoader/Module.php(860): MediaWiki\ResourceLoader\FileModule->getStyles(MediaWiki\ResourceLoader\DerivativeContext)
#17 /srv/mediawiki/php-1.41.0-wmf.30/includes/ResourceLoader/Module.php(819): MediaWiki\ResourceLoader\Module->buildContent(MediaWiki\ResourceLoader\DerivativeContext)
#18 /srv/mediawiki/php-1.41.0-wmf.30/includes/ResourceLoader/ResourceLoader.php(1258): MediaWiki\ResourceLoader\Module->getModuleContent(MediaWiki\ResourceLoader\DerivativeContext)
#19 /srv/mediawiki/php-1.41.0-wmf.30/includes/ResourceLoader/ResourceLoader.php(1178): MediaWiki\ResourceLoader\ResourceLoader->addOneModuleResponse(MediaWiki\ResourceLoader\DerivativeContext, Wikimedia\Minify\IdentityMinifierState, string, MediaWiki\ResourceLoader\FileModule, array)
#20 /srv/mediawiki/php-1.41.0-wmf.30/includes/ResourceLoader/ResourceLoader.php(1111): MediaWiki\ResourceLoader\ResourceLoader->getOneModuleResponse(MediaWiki\ResourceLoader\DerivativeContext, string, MediaWiki\ResourceLoader\FileModule)
#21 /srv/mediawiki/php-1.41.0-wmf.30/extensions/WikimediaMaintenance/blameStartupRegistry.php(141): MediaWiki\ResourceLoader\ResourceLoader->makeModuleResponse(MediaWiki\ResourceLoader\DerivativeContext, array)
#22 /srv/mediawiki/php-1.41.0-wmf.30/maintenance/includes/MaintenanceRunner.php(703): BlameStartupRegistry->execute()
#23 /srv/mediawiki/php-1.41.0-wmf.30/maintenance/run.php(51): MediaWiki\Maintenance\MaintenanceRunner->run()
#24 /srv/mediawiki/multiversion/MWScript.php(159): require_once(string)
#25 {main}
Impact
Notes

Two log errors which originate from mwmaint2002 when running MediaWiki-extensions-WikimediaMaintenance script blameStartupRegistry.php.

I don't know how the less variable @min-width-desktop-wide ends up not being defined, but that looks like something that should be caught by CI ahead of time?

Details

SubjectRepoBranchLines +/-
Fixes Echo skin style for user message barmediawiki/skins/VectorREL1_41+1 -1
Fixes Echo skin style for user message barmediawiki/skins/Vectormaster+1 -1
Fixes Echo skin style for user message barmediawiki/skins/Vectorwmf/1.41.0-wmf.30+1 -1
Customize query in gerrit

Related Objects
Search...

Event Timeline

hashar created this task.Oct 10 2023, 12:26 PM
Restricted Application added a project: Growth-Team. · View Herald TranscriptOct 10 2023, 12:26 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
hashar mentioned this in T347081: 1.41.0-wmf.30 deployment blockers.Oct 10 2023, 12:29 PM
hashar updated the task description. (Show Details)
TheresNoTime subscribed.Oct 10 2023, 12:51 PM

Introduced in rSVEC8a88f61e89f9: Introduce media query breakpoint variables and replace all media query usage… (T310536: Fix inconsistent media query usage to avoid 1px viewport bugs), though probably caused by rSVECfd046f3258b9: Use skin variables instead of local variables where possible?

diff --git a/skinStyles/ext.echo.styles.alert.less b/skinStyles/ext.echo.styles.alert.less
index c0326d8..a9303a9 100644
--- a/skinStyles/ext.echo.styles.alert.less
+++ b/skinStyles/ext.echo.styles.alert.less
@@ -1,4 +1,4 @@
-@import '../resources/common/variables.less';
+@import 'mediawiki.skin.variables.less';
 
 /** Mixin for collapsing the Echo new messages alert */
 .echo-alert-collapse() {
TheresNoTime added a subscriber: Jdlrobson.Oct 10 2023, 12:52 PM
Jdlrobson added a project: Web-Team-Backlog (Web Team FY2023-24 Q2 Sprint 1).Oct 10 2023, 6:53 PM
Jdlrobson updated the task description. (Show Details)
gerritbot added a comment.Oct 10 2023, 6:58 PM

Change 964966 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/Vector@master] Fixes Echo skin style for user message bar

https://gerrit.wikimedia.org/r/964966

gerritbot added a project: Patch-For-Review.Oct 10 2023, 6:58 PM
Jdlrobson triaged this task as Unbreak Now! priority.Oct 10 2023, 6:59 PM
Jdlrobson added a parent task: T347081: 1.41.0-wmf.30 deployment blockers.

Presumably this would be a deployment blocker given the warnings and the fact it breaks the yellow bar of doom (you have new messages alert).

ovasileva subscribed.Oct 10 2023, 7:02 PM
Jdlrobson added a comment.Oct 10 2023, 7:05 PM

How it should look and how it's looking:

Screenshot 2023-10-10 at 12.03.30 PM.png (417×887 px, 63 KB)

Screenshot 2023-10-10 at 12.03.35 PM.png (210×887 px, 38 KB)

Jdlrobson moved this task from Incoming to Code Review on the Web-Team-Backlog (Web Team FY2023-24 Q2 Sprint 1) board.Oct 10 2023, 7:05 PM
gerritbot added a comment.Oct 10 2023, 7:22 PM

Change 964966 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Fixes Echo skin style for user message bar

https://gerrit.wikimedia.org/r/964966

Ammarpad mentioned this in T348572: Wrong font size in OOUI dropdowns in Vector.Oct 10 2023, 7:30 PM
Maintenance_bot removed a project: Patch-For-Review.Oct 10 2023, 7:30 PM
ReleaseTaggerBot added a project: MW-1.42-notes (1.42.0-wmf.1; 2023-10-17).Oct 10 2023, 8:00 PM
Jdlrobson moved this task from Code Review to QA on the Web-Team-Backlog (Web Team FY2023-24 Q2 Sprint 1) board.Oct 10 2023, 8:23 PM
gerritbot added a comment.Oct 10 2023, 8:24 PM

Change 964600 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/Vector@wmf/1.41.0-wmf.30] Fixes Echo skin style for user message bar

https://gerrit.wikimedia.org/r/964600

gerritbot added a project: Patch-For-Review.Oct 10 2023, 8:24 PM
Jdlrobson claimed this task.Oct 10 2023, 8:25 PM
Jdlrobson moved this task from QA to Ready for Signoff on the Web-Team-Backlog (Web Team FY2023-24 Q2 Sprint 1) board.

I can confirm this no longer fatals: https://en.m.wikipedia.beta.wmflabs.org/w/load.php?modules=ext.echo.styles.alert&debug=true&only=styles&skin=vector-2022

We'll need to backport this now.

Jdlrobson added a comment.Oct 10 2023, 9:35 PM

This was caught by Pixel regression tests, but presumably missed because of yesterday's holiday:
https://pixel.wmcloud.org/reports/echo/index.html

hashar added a comment.Oct 11 2023, 7:10 AM

I am wondering why that was not caught by CI tests when the patch got proposed? MediaWiki core has a structure test suite which runs for all extensions and skins and should probably have caught it, most probably via tests/phpunit/structure/ResourcesTest.php. Then it doesn't look like any test triggers a Less compilation which is unfortunate.

hashar renamed this task from [1c996f933eac40cde5d84a80] [no req] Less_Exception_Compiler: variable @min-width-desktop-wide is undefined in file /srv/mediawiki/php-1.41.0-wmf.30/skins/Vector/skinStyles/ext.echo.styles.alert.less in ext.echo.styles.alert.less on line 22, column 2320 to Less_Exception_Compiler: variable @min-width-desktop-wide is undefined in file /srv/mediawiki/php-1.41.0-wmf.30/skins/Vector/skinStyles/ext.echo.styles.alert.less in ext.echo.styles.alert.less on line 22, column 2320.Oct 11 2023, 7:15 AM
gerritbot added a comment.Oct 11 2023, 7:50 AM

Change 964600 merged by jenkins-bot:

[mediawiki/skins/Vector@wmf/1.41.0-wmf.30] Fixes Echo skin style for user message bar

https://gerrit.wikimedia.org/r/964600

Stashbot added a comment.Oct 11 2023, 8:00 AM

Mentioned in SAL (#wikimedia-operations) [2023-10-11T08:00:02Z] <hashar@deploy2002> Synchronized php-1.41.0-wmf.30/skins/Vector: Backports for Vector styling issues T348572 T348530 (duration: 06m 16s)

ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.30; 2023-10-10).Oct 11 2023, 8:00 AM
Maintenance_bot removed a project: Patch-For-Review.Oct 11 2023, 8:10 AM
Jdlrobson closed this task as Resolved.Oct 11 2023, 5:04 PM

Thanks @hashar

hashar added a comment.Oct 11 2023, 5:22 PM

@Jdlrobson as a follow up can you check why the missing variable in less hasn't been caught by tests/CI? I thought we had a structure tests in mediawiki/core to compile the less files provided by the ResourceLoader. But maybe I misremember :)

Jdlrobson mentioned this in T348676: Our structure tests should consider skin styles.Oct 11 2023, 6:13 PM

@hashar > T348676

hashar added a comment.Oct 11 2023, 8:57 PM
In T348530#9243976, @Jdlrobson wrote:

@hashar > T348676

As another task of course! Thank you :]

Edtadros mentioned this in T346851: Verify 1.41.0-wmf.30 deployment.Oct 16 2023, 5:15 PM
Jdlrobson added a project: Verified.Oct 16 2023, 5:21 PM
gerritbot added a comment.Feb 6 2024, 2:30 PM

Change 997866 had a related patch set uploaded (by Paladox; author: Jdlrobson):

[mediawiki/skins/Vector@REL1_41] Fixes Echo skin style for user message bar

https://gerrit.wikimedia.org/r/997866

gerritbot added a project: Patch-For-Review.Feb 6 2024, 2:30 PM
gerritbot added a comment.Feb 6 2024, 6:05 PM

Change 997866 merged by jenkins-bot:

[mediawiki/skins/Vector@REL1_41] Fixes Echo skin style for user message bar

https://gerrit.wikimedia.org/r/997866

Maintenance_bot removed a project: Patch-For-Review.Feb 6 2024, 6:30 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL