Page MenuHomePhabricator
Create Task
Maniphest T347081

1.41.0-wmf.30 deployment blockers
Closed, ResolvedPublic5 Estimated Story PointsRelease
Actions

Details

Backup Train Conductor
jeena
Release Version
1.41.0-wmf.30
Release Date
Oct 9 2023, 12:00 AM

2023 week 41 1.41-wmf.30 Changes wmf/1.41.0-wmf.30

This MediaWiki Train Deployment is scheduled for the week of Monday, October 9th:

Monday October 9thTuesday, October 10thWednesday, October 11thThursday, October 12thFriday
Backports only.Branch wmf.30 and deploy to Group 0 Wikis.Deploy wmf.30 to Group 1 Wikis.Deploy wmf.30 to all Wikis.No deployments on fridays

How this works

  • Any serious bugs affecting wmf.30 should be added as subtasks beneath this one.
  • Any open subtask(s) block the train from moving forward. This means no further deployments until the blockers are resolved.
  • If something is serious enough to warrant a rollback then you should bring it to the attention of deployers on the #wikimedia-operations IRC channel.
  • If you have a risky change in this week's train add a comment to this task using the Risky patch template
  • For more info about deployment blockers, see Holding the train.

Related Links

Other Deployments

Previous: 1.41.0-wmf.29
Next: 1.42.0-wmf.1
SubjectRepoBranchLines +/-
group2 wikis to 1.41.0-wmf.30operations/mediawiki-configmaster+330 -330
Revert "group2 wikis to 1.41.0-wmf.30"operations/mediawiki-configmaster+330 -330
group2 wikis to 1.41.0-wmf.30operations/mediawiki-configmaster+330 -330
group1 wikis to 1.41.0-wmf.30operations/mediawiki-configmaster+548 -548
group0 wikis to 1.41.0-wmf.30operations/mediawiki-configmaster+132 -132
testwikis wikis to 1.41.0-wmf.30operations/mediawiki-configmaster+4 -4
Branch commit for wmf/1.41.0-wmf.30mediawiki/corewmf/1.41.0-wmf.30+996 -3
Customize query in gerrit

Related Objects
Search...

Event Timeline

thcipriani created this task.Sep 21 2023, 3:43 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 21 2023, 3:43 PM
Jdlrobson mentioned this in T346851: Verify 1.41.0-wmf.30 deployment.Sep 25 2023, 5:13 PM
thcipriani assigned this task to hashar.Sep 28 2023, 11:10 PM
thcipriani triaged this task as Medium priority.
thcipriani updated Other Assignee, added: jeena.
thcipriani set the point value for this task to 5.
thcipriani added a project: Release-Engineering-Team (Priority Backlog 📥).
Jdforrester-WMF subscribed.Sep 29 2023, 12:40 AM
Jdlrobson mentioned this in T348357: Verify 1.42.0-wmf.1 deployment.Oct 6 2023, 8:54 PM
Jdlrobson mentioned this in T348358: Verify 1.41.0-wmf.29 deployment.Oct 6 2023, 9:00 PM
gerritbot added a comment.Oct 10 2023, 2:07 AM

Change 964626 had a related patch set uploaded (by TrainBranchBot; author: trainbranchbot):

[mediawiki/core@wmf/1.41.0-wmf.30] Branch commit for wmf/1.41.0-wmf.30

https://gerrit.wikimedia.org/r/964626

gerritbot added a project: Patch-For-Review.Oct 10 2023, 2:07 AM
gerritbot added a comment.Oct 10 2023, 2:22 AM

Change 964626 merged by jenkins-bot:

[mediawiki/core@wmf/1.41.0-wmf.30] Branch commit for wmf/1.41.0-wmf.30

https://gerrit.wikimedia.org/r/964626

gerritbot added a comment.Oct 10 2023, 3:01 AM

Change 964620 had a related patch set uploaded (by TrainBranchBot; author: MediaWiki PreSync):

[operations/mediawiki-config@master] testwikis wikis to 1.41.0-wmf.30

https://gerrit.wikimedia.org/r/964620

gerritbot added a comment.Oct 10 2023, 3:02 AM

Change 964620 merged by jenkins-bot:

[operations/mediawiki-config@master] testwikis wikis to 1.41.0-wmf.30

https://gerrit.wikimedia.org/r/964620

Stashbot added a comment.Oct 10 2023, 3:02 AM

Mentioned in SAL (#wikimedia-operations) [2023-10-10T03:02:42Z] <mwpresync@deploy2002> Started scap: testwikis wikis to 1.41.0-wmf.30 refs T347081

Stashbot added a comment.Oct 10 2023, 3:52 AM

Mentioned in SAL (#wikimedia-operations) [2023-10-10T03:52:38Z] <mwpresync@deploy2002> Finished scap: testwikis wikis to 1.41.0-wmf.30 refs T347081 (duration: 49m 56s)

gerritbot added a comment.Oct 10 2023, 8:27 AM

Change 964853 had a related patch set uploaded (by TrainBranchBot; author: Hashar):

[operations/mediawiki-config@master] group0 wikis to 1.41.0-wmf.30

https://gerrit.wikimedia.org/r/964853

gerritbot added a comment.Oct 10 2023, 8:28 AM

Change 964853 merged by jenkins-bot:

[operations/mediawiki-config@master] group0 wikis to 1.41.0-wmf.30

https://gerrit.wikimedia.org/r/964853

Stashbot added a comment.Oct 10 2023, 8:35 AM

Mentioned in SAL (#wikimedia-operations) [2023-10-10T08:35:19Z] <hashar@deploy2002> rebuilt and synchronized wikiversions files: group0 wikis to 1.41.0-wmf.30 refs T347081

hashar added a comment.Oct 10 2023, 12:29 PM

There is one for which I don't know whether it is a blocker of it is a maintenance script misbehaving. In Vector skin, the ext.echo.styles.alert.less file has an undefined @min-width-desktop-wide variable. Filed as T348530

Jdlrobson added a subtask: T348530: Less_Exception_Compiler: variable @min-width-desktop-wide is undefined in file /srv/mediawiki/php-1.41.0-wmf.30/skins/Vector/skinStyles/ext.echo.styles.alert.less in ext.echo.styles.alert.less on line 22, column 2320.Oct 10 2023, 6:59 PM
matmarex added a subtask: T348572: Wrong font size in OOUI dropdowns in Vector.Oct 10 2023, 7:10 PM
hashar closed subtask T348572: Wrong font size in OOUI dropdowns in Vector as Resolved.Oct 11 2023, 8:03 AM
gerritbot added a comment.Oct 11 2023, 8:30 AM

Change 965053 had a related patch set uploaded (by TrainBranchBot; author: Hashar):

[operations/mediawiki-config@master] group1 wikis to 1.41.0-wmf.30

https://gerrit.wikimedia.org/r/965053

gerritbot added a comment.Oct 11 2023, 8:31 AM

Change 965053 merged by jenkins-bot:

[operations/mediawiki-config@master] group1 wikis to 1.41.0-wmf.30

https://gerrit.wikimedia.org/r/965053

Stashbot added a comment.Oct 11 2023, 8:38 AM

Mentioned in SAL (#wikimedia-operations) [2023-10-11T08:38:23Z] <hashar@deploy2002> rebuilt and synchronized wikiversions files: group1 wikis to 1.41.0-wmf.30 refs T347081

Stashbot added a comment.Oct 11 2023, 8:44 AM

Mentioned in SAL (#wikimedia-operations) [2023-10-11T08:44:23Z] <hashar@deploy2002> Synchronized php: group1 wikis to 1.41.0-wmf.30 refs T347081 (duration: 06m 00s)

taavi subscribed.Oct 11 2023, 4:21 PM

T348669: GlobalBlocking navigation bar is double-escaped is a regression in this train, although it only affects group1.

Jdlrobson closed subtask T348530: Less_Exception_Compiler: variable @min-width-desktop-wide is undefined in file /srv/mediawiki/php-1.41.0-wmf.30/skins/Vector/skinStyles/ext.echo.styles.alert.less in ext.echo.styles.alert.less on line 22, column 2320 as Resolved.Oct 11 2023, 5:04 PM
hashar added a subtask: T348669: GlobalBlocking navigation bar is double-escaped.Oct 11 2023, 5:24 PM
In T347081#9243632, @taavi wrote:

T348669: GlobalBlocking navigation bar is double-escaped is a regression in this train, although it only affects group1.

Although resolved (thanks!) I have attached it as a sub task for tracking purposes.

gerritbot added a comment.Oct 12 2023, 8:21 AM

Change 965465 had a related patch set uploaded (by TrainBranchBot; author: Hashar):

[operations/mediawiki-config@master] group2 wikis to 1.41.0-wmf.30

https://gerrit.wikimedia.org/r/965465

gerritbot added a comment.Oct 12 2023, 8:21 AM

Change 965465 merged by jenkins-bot:

[operations/mediawiki-config@master] group2 wikis to 1.41.0-wmf.30

https://gerrit.wikimedia.org/r/965465

Stashbot added a comment.Oct 12 2023, 8:28 AM

Mentioned in SAL (#wikimedia-operations) [2023-10-12T08:28:39Z] <hashar@deploy2002> rebuilt and synchronized wikiversions files: group2 wikis to 1.41.0-wmf.30 refs T347081

gerritbot added a comment.Oct 12 2023, 8:40 AM

Change 965467 had a related patch set uploaded (by Hashar; author: Hashar):

[operations/mediawiki-config@master] Revert "group2 wikis to 1.41.0-wmf.30"

https://gerrit.wikimedia.org/r/965467

gerritbot added a comment.Oct 12 2023, 8:41 AM

Change 965467 merged by jenkins-bot:

[operations/mediawiki-config@master] Revert "group2 wikis to 1.41.0-wmf.30"

https://gerrit.wikimedia.org/r/965467

Stashbot added a comment.Oct 12 2023, 8:53 AM

Mentioned in SAL (#wikimedia-operations) [2023-10-12T08:53:12Z] <hashar@deploy2002> rebuilt and synchronized wikiversions files: Revert "group2 wikis to 1.41.0-wmf.30" # T347081

gerritbot added a comment.Oct 12 2023, 1:56 PM

Change 965518 had a related patch set uploaded (by TrainBranchBot; author: Hashar):

[operations/mediawiki-config@master] group2 wikis to 1.41.0-wmf.30

https://gerrit.wikimedia.org/r/965518

gerritbot added a comment.Oct 12 2023, 1:57 PM

Change 965518 merged by jenkins-bot:

[operations/mediawiki-config@master] group2 wikis to 1.41.0-wmf.30

https://gerrit.wikimedia.org/r/965518

Stashbot added a comment.Oct 12 2023, 2:03 PM

Mentioned in SAL (#wikimedia-operations) [2023-10-12T14:03:52Z] <hashar@deploy2002> rebuilt and synchronized wikiversions files: group2 wikis to 1.41.0-wmf.30 refs T347081

hashar closed subtask T348719: Error: Typed property GrowthExperiments\NewcomerTasks\AddLink\LinkRecommendationUpdater::$linkRecommendationTaskType must not be accessed before initialization as Resolved.Oct 12 2023, 2:37 PM
hashar added a comment.Oct 12 2023, 4:07 PM

I have filed a few more tasks that are not worth blocking the train (known issue patterns, exception raised instead of merely logging the info eg T348753, some rare occurrences probably caused by race conditions etc).

What I have noticed though is there is there are a lot of new JavaScript errors reported by the end users browser on mw-client-NEW-errors (private). I have raised awareness of it on our internal engineering discussion channel to attract some attention.

Overall the version looks stable. I am keeping it open until tomorrow in case issues are found over the next few hours. If all is fine tomorrow, I will mark the task resolved and claims 1.41.0-wmf.30 to have successfully rolled out.

hashar added a comment.Oct 13 2023, 8:53 AM

I have looked at the error log this morning nothing new surfaced since yesterday evening \o/ I am claiming 1.41.0-wmf.30 to be a success.

hashar closed this task as Resolved.Oct 13 2023, 8:53 AM
Jdforrester-WMF added a subtask: T348753: [026f63a8-bebd-49dd-a536-746796d71575] /w/api.php Exception: Errors saving HLS playlist LL-Q8097_(tel)-V_Bhavya-క్రొ.wav.m3u8.Oct 16 2023, 1:31 PM
hashar added a comment.Oct 16 2023, 6:25 PM

I have deployed a backport fix for TimedMediaHandler ( T348753 ) earlier today (~ 8 UTC)

hashar mentioned this in T349086: MediaWiki normalized_message field has placeholders replaced since October 12th.Oct 17 2023, 12:16 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits