Page MenuHomePhabricator

Reply and new topic tools fail to load
Closed, ResolvedPublicPRODUCTION ERROR

Description

NOTE: This issue will be fixed on Monday (16 Oct 2023). In the meantime, you can regain access to the Reply and New Topic Tools by turning on the Enable editing tools in source mode preference in Special:Preferences#mw-prefsection-editing.

Error
message
jQuery.Deferred exception: ve.ui is undefined
trace
ReplyWidget@https://www.wikidata.org/w/load.php?debug=1&lang=hu&modules=ext.confirmEdit.CaptchaInputWidget%7Cext.discussionTools.ReplyWidget%2CReplyWidgetPlain%7Cjquery.lengthLimit%7Cmediawiki.widgets.AbandonEditDialog%2CvisibleLengthLimit%7Coojs-ui.styles.icons-editing-core&skin=timeless&version=ztntf:174:1
ReplyWidgetPlain@https://www.wikidata.org/w/load.php?debug=1&lang=hu&modules=ext.confirmEdit.CaptchaInputWidget%7Cext.discussionTools.ReplyWidget%2CReplyWidgetPlain%7Cjquery.lengthLimit%7Cmediawiki.widgets.AbandonEditDialog%2CvisibleLengthLimit%7Coojs-ui.styles.icons-editing-core&skin=timeless&version=ztntf:1226:25
CommentController.js/CommentController.prototype.createReplyWidget/<@https://www.wikidata.org/w/load.php?debug=1&lang=hu&modules=ext.centralNotice.geoIP%7Cext.centralauth.ForeignApi%7Cext.centralauth.centralautologin.clearcookie%7Cext.checkUser.clientHints%7Cext.discussionTools.init%2Cminervaicons%7Cext.echo.api%2Cinit%7Cext.eventLogging%2CnavigationTiming%2Cthanks%2CwikimediaEvents%7Cext.thanks.corethank%7Cext.uls.common%2Ccompactlinks%2Cinterface%2Cpreferences%2Cwebfonts%7Cext.urlShortener.toolbar%7Cext.wikimediaEvents.specialPages%2Cwikibase%7Cjquery%2Cmoment%2Coojs%2Coojs-ui%2Coojs-ui-core%2Coojs-ui-toolbars%2Coojs-ui-widgets%2Coojs-ui-windows%2Crangefix%2Csite%7Cjquery.client%2Cconfirmable%2Ci18n%2Cspinner%2CtextSelection%2Cui%7Cjquery.event.special.eachchange%7Cjquery.spinner.styles%7Cjquery.ui.suggester%7Cjquery.uls.data%7Cjquery.wikibase.entityselector%7Cmediawiki.ForeignApi%2CString%2CTitle%2CUri%2Capi%2Cbase%2Ccldr%2Ccookie%2Cdiff%2Cexperiments%2CjqueryMsg%2Clanguage%2Cstorage%2Cuser%2Cutil%2CvisibleTimeout%7Cmediawiki.ForeignApi.core%7Cmediawiki.editfont.styles%7Cmediawiki.libs.pluralruleparser%7Cmediawiki.page.ready%7Cmediawiki.page.watch.ajax%7Coojs-ui-toolbars.icons%7Coojs-ui-widgets.icons%7Coojs-ui-windows.icons%7Cskins.timeless.js%7Cutil.inherit%7Cwikibase.ui.entitysearch&skin=timeless&version=ztntf:2957:10
mightThrow@https://www.wikidata.org/w/resources/lib/jquery/jquery.js?12e87:3489:29
Deferred/then/resolve/</process<@https://www.wikidata.org/w/resources/lib/jquery/jquery.js?12e87:3557:12
setTimeout handler*Deferred/then/resolve/<@https://www.wikidata.org/w/resources/lib/jquery/jquery.js?12e87:3602:16
fire@https://www.wikidata.org/w/resources/lib/jquery/jquery.js?12e87:3223:31
fireWith@https://www.wikidata.org/w/resources/lib/jquery/jquery.js?12e87:3353:7
fire@https://www.wikidata.org/w/resources/lib/jquery/jquery.js?12e87:3361:10
fire@https://www.wikidata.org/w/resources/lib/jquery/jquery.js?12e87:3223:31
fireWith@https://www.wikidata.org/w/resources/lib/jquery/jquery.js?12e87:3353:7
mightThrow@https://www.wikidata.org/w/resources/lib/jquery/jquery.js?12e87:3548:46
Deferred/then/resolve/</process<@https://www.wikidata.org/w/resources/lib/jquery/jquery.js?12e87:3557:12
setTimeout handler*Deferred/then/resolve/<@https://www.wikidata.org/w/resources/lib/jquery/jquery.js?12e87:3602:16
fire@https://www.wikidata.org/w/resources/lib/jquery/jquery.js?12e87:3223:31
fireWith@https://www.wikidata.org/w/resources/lib/jquery/jquery.js?12e87:3353:7
fire@https://www.wikidata.org/w/resources/lib/jquery/jquery.js?12e87:3361:10
fire@https://www.wikidata.org/w/resources/lib/jquery/jquery.js?12e87:3223:31
fireWith@https://www.wikidata.org/w/resources/lib/jquery/jquery.js?12e87:3353:7
Deferred/</deferred[tuple[0]]@https://www.wikidata.org/w/resources/lib/jquery/jquery.js?12e87:3698:36
mediawiki.base.js/mw.loader.using/<@https://www.wikidata.org/w/load.php?debug=1&lang=hu&modules=ext.centralNotice.geoIP%7Cext.centralauth.ForeignApi%7Cext.centralauth.centralautologin.clearcookie%7Cext.checkUser.clientHints%7Cext.discussionTools.init%2Cminervaicons%7Cext.echo.api%2Cinit%7Cext.eventLogging%2CnavigationTiming%2Cthanks%2CwikimediaEvents%7Cext.thanks.corethank%7Cext.uls.common%2Ccompactlinks%2Cinterface%2Cpreferences%2Cwebfonts%7Cext.urlShortener.toolbar%7Cext.wikimediaEvents.specialPages%2Cwikibase%7Cjquery%2Cmoment%2Coojs%2Coojs-ui%2Coojs-ui-core%2Coojs-ui-toolbars%2Coojs-ui-widgets%2Coojs-ui-windows%2Crangefix%2Csite%7Cjquery.client%2Cconfirmable%2Ci18n%2Cspinner%2CtextSelection%2Cui%7Cjquery.event.special.eachchange%7Cjquery.spinner.styles%7Cjquery.ui.suggester%7Cjquery.uls.data%7Cjquery.wikibase.entityselector%7Cmediawiki.ForeignApi%2CString%2CTitle%2CUri%2Capi%2Cbase%2Ccldr%2Ccookie%2Cdiff%2Cexperiments%2CjqueryMsg%2Clanguage%2Cstorage%2Cuser%2Cutil%2CvisibleTimeout%7Cmediawiki.ForeignApi.core%7Cmediawiki.editfont.styles%7Cmediawiki.libs.pluralruleparser%7Cmediawiki.page.ready%7Cmediawiki.page.watch.ajax%7Coojs-ui-toolbars.icons%7Coojs-ui-widgets.icons%7Coojs-ui-windows.icons%7Cskins.timeless.js%7Cutil.inherit%7Cwikibase.ui.entitysearch&skin=timeless&version=ztntf:18052:26
doPropagation@https://www.wikidata.org/w/load.php?debug=1&lang=hu&modules=startup&only=scripts&raw=1&skin=timeless:756:12
Async*setAndPropagate@https://www.wikidata.org/w/load.php?debug=1&lang=hu&modules=startup&only=scripts&raw=1&skin=timeless:813:6
markModuleReady@https://www.wikidata.org/w/load.php?debug=1&lang=hu&modules=startup&only=scripts&raw=1&skin=timeless:1226:20
nestedAddScript@https://www.wikidata.org/w/load.php?debug=1&lang=hu&modules=startup&only=scripts&raw=1&skin=timeless:1233:6
execute/runScript/nestedAddScript/<@https://www.wikidata.org/w/load.php?debug=1&lang=hu&modules=startup&only=scripts&raw=1&skin=timeless:1238:21
queueModuleScript/</<@https://www.wikidata.org/w/load.php?debug=1&lang=hu&modules=startup&only=scripts&raw=1&skin=timeless:1075:5
onComplete@https://www.wikidata.org/w/load.php?debug=1&lang=hu&modules=startup&only=scripts&raw=1&skin=timeless:1036:5
EventHandlerNonNull*addScript@https://www.wikidata.org/w/load.php?debug=1&lang=hu&modules=startup&only=scripts&raw=1&skin=timeless:1040:3
queueModuleScript/<@https://www.wikidata.org/w/load.php?debug=1&lang=hu&modules=startup&only=scripts&raw=1&skin=timeless:1070:13
queueModuleScript/</<@https://www.wikidata.org/w/load.php?debug=1&lang=hu&modules=startup&only=scripts&raw=1&skin=timeless:1078:29
onComplete@https://www.wikidata.org/w/load.php?debug=1&lang=hu&modules=startup&only=scripts&raw=1&skin=timeless:1036:5
EventHandlerNonNull*addScript@https://www.wikidata.org/w/load.php?debug=1&lang=hu&modules=startup&only=scripts&raw=1&skin=timeless:1040:3
queueModuleScript/<@https://www.wikidata.org/w/load.php?debug=1&lang=hu&modules=startup&only=scripts&raw=1&skin=timeless:1070:13
queueModuleScript/</<@https://www.wikidata.org/w/load.php?debug=1&lang=hu&modules=startup&only=scripts&raw=1&skin=timeless:1078:29
onComplete@https://www.wikidata.org/w/load.php?debug=1&lang=hu&modules=startup&only=scripts&raw=1&skin=timeless:1036:5
EventHandlerNonNull*addScript@https://www.wikidata.org/w/load.php?debug=1&lang=hu&modules=startup&only=scripts&raw=1&skin=timeless:1040:3
queueModuleScript/<@https://www.wikidata.org/w/load.php?debug=1&lang=hu&modules=startup&only=scripts&raw=1&skin=timeless:1070:13
queueModuleScript/</<@https://www.wikidata.org/w/load.php?debug=1&lang=hu&modules=startup&only=scripts&raw=1&skin=timeless:1078:29
onComplete@https://www.wikidata.org/w/load.php?debug=1&lang=hu&modules=startup&only=scripts&raw=1&skin=timeless:1036:5
EventHandlerNonNull*addScript@https://www.wikidata.org/w/load.php?debug=1&lang=hu&modules=startup&only=scripts&raw=1&skin=timeless:1040:3
queueModuleScript/<@https://www.wikidata.org/w/load.php?debug=1&lang=hu&modules=startup&only=scripts&raw=1&skin=timeless:1070:13
queueModuleScript/</<@https://www.wikidata.org/w/load.php?debug=1&lang=hu&modules=startup&only=scripts&raw=1&skin=timeless:1078:29
onComplete@https://www.wikidata.org/w/load.php?debug=1&lang=hu&modules=startup&only=scripts&raw=1&skin=timeless:1036:5
EventHandlerNonNull*addScript@https://www.wikidata.org/w/load.php?debug=1&lang=hu&modules=startup&only=scripts&raw=1&skin=timeless:1040:3
queueModuleScript/<@https://www.wikidata.org/w/load.php?debug=1&lang=hu&modules=startup&only=scripts&raw=1&skin=timeless:1070:13
queueModuleScript/</<@https://www.wikidata.org/w/load.php?debug=1&lang=hu&modules=startup&only=scripts&raw=1&skin=timeless:1078:29
onComplete@https://www.wikidata.org/w/load.php?debug=1&lang=hu&modules=startup&only=scripts&raw=1&skin=timeless:1036:5
EventHandlerNonNull*addScript@https://www.wikidata.org/w/load.php?debug=1&lang=hu&modules=startup&only=scripts&raw=1&skin=timeless:1040:3
queueModuleScript/<@https://www.wikidata.org/w/load.php?debug=1&lang=hu&modules=startup&only=scripts&raw=1&skin=timeless:1070:13
queueModuleScript/</<@https://www.wikidata.org/w/load.php?debug=1&lang=hu&modules=startup&only=scripts&raw=1&skin=timeless:1078:29
Impact

Unable to use the reply tool or the new topic tool. It works when being logged out, so I’m not sure how many people are affected by this (but those who do, are quite severely).

Notes
  • Tried to reply my 07:23 comment and to start a new topic on that page. The stack trace is from the reply attempt. (The error message is the same when trying to start a new topic; I didn’t compare the stack traces.)
  • Happened logged-in, I was unable to reproduce it logged-out with the very same URL. Preferences that might be interesting (that I know are different from the defaults):
    • UI language: Hungarian (hu)
    • Skin: Timeless
    • All DiscussionTools preferences are on, except for automatic topic subscriptions and source mode toolbar. Adding &dtenable=1 to the URL while logged out didn’t make the issue reproducible.
  • The URL contains &debug=true, but that’s only to get an easier-to-understand stack trace, it’s broken without &debug=true as well.

Details

Request URL
https://www.wikidata.org/w/index.php?title=Talk:Q1445491&diff=0&oldid=776678890&debug=true

Event Timeline

I found the culprit: the source mode toolbar. I turned it on, and the reply tool was fixed. I very much hope that this doesn’t mean the end of the <textarea>-based discussion tools.

Yes, probably, despite the quite different stack trace. (Probably RoySmith uses a Chromium-based browser? I use Firefox.)

This maintenance & testing burden is why we should remove the <textarea> reply tool (T276607).

Change 965714 had a related patch set uploaded (by Esanders; author: Esanders):

[mediawiki/extensions/DiscussionTools@master] Merge ReplyWidget[Plain/Visual] modules

https://gerrit.wikimedia.org/r/965714

Agreed that it's probably backport-worthy, though there's no window on the calendar until Monday.

Would it be accurate for me to think the following?

Who is impacted?: People who attempt to use the Reply and/or New Topic Tool and who do NOT have the Enable editing tools in source mode setting enabled

What can people who are impacted do to regain use of the Reply and New Topic Tools?: They can turn on the Enable editing tools in source mode preference, as @Tacsipacsi described in T348834#9248908.

ppelberg moved this task from Incoming to Code Review on the Editing-team (Kanban Board) board.
ppelberg updated the task description. (Show Details)
ppelberg updated the task description. (Show Details)
ppelberg updated the task description. (Show Details)

Change 965714 merged by jenkins-bot:

[mediawiki/extensions/DiscussionTools@master] Merge ReplyWidget[Plain/Visual] modules

https://gerrit.wikimedia.org/r/965714

Change 965904 had a related patch set uploaded (by DLynch; author: Esanders):

[mediawiki/extensions/DiscussionTools@wmf/1.41.0-wmf.30] Merge ReplyWidget[Plain/Visual] modules

https://gerrit.wikimedia.org/r/965904

Change 965904 merged by jenkins-bot:

[mediawiki/extensions/DiscussionTools@wmf/1.41.0-wmf.30] Merge ReplyWidget[Plain/Visual] modules

https://gerrit.wikimedia.org/r/965904

Mentioned in SAL (#wikimedia-operations) [2023-10-16T20:19:13Z] <cjming@deploy2002> Started scap: Backport for [[gerrit:965904|Merge ReplyWidget[Plain/Visual] modules (T348834)]]

Mentioned in SAL (#wikimedia-operations) [2023-10-16T20:20:32Z] <cjming@deploy2002> kemayo and cjming: Backport for [[gerrit:965904|Merge ReplyWidget[Plain/Visual] modules (T348834)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Mentioned in SAL (#wikimedia-operations) [2023-10-16T20:26:37Z] <cjming@deploy2002> Finished scap: Backport for [[gerrit:965904|Merge ReplyWidget[Plain/Visual] modules (T348834)]] (duration: 07m 23s)

After a few hard page reloads to clear my cache, it works for me. Thanks for fixing it!

EAkinloose subscribed.

Confirmed fix in prod on hu.wiki

Screenshot 2023-10-19 at 22.47.47.png (1×2 px, 249 KB)

ppelberg claimed this task.