TypeError: Argument 9 passed to ContentTranslation\DTO\CXDraftTranslationDTO::__construct() must be of the type array or null, string given
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Assigned To

Authored By

	brennen
	Oct 19 2023, 3:30 PM

Description

Error

service.version: 1.42.0-wmf.1
trace.id: 9c5769ef-eedb-4391-8084-0b6e01f8bf3d
Find trace.id in Logstash

labels.normalized_message

[{reqId}] {exception_url}   TypeError: Argument 9 passed to ContentTranslation\DTO\CXDraftTranslationDTO::__construct() must be of the type array or null, string given, called in /srv/mediawiki/php-1.42.0-wmf.1/extensions/ContentTranslation/includes/DTO/C

error.stack_trace

from /srv/mediawiki/php-1.42.0-wmf.1/extensions/ContentTranslation/includes/DTO/CXDraftTranslationDTO.php(26)
#0 /srv/mediawiki/php-1.42.0-wmf.1/extensions/ContentTranslation/includes/DTO/CXDraftTranslationDTO.php(60): ContentTranslation\DTO\CXDraftTranslationDTO->__construct(integer, string, string, string, string, string, string, array, string)
#1 /srv/mediawiki/php-1.42.0-wmf.1/extensions/ContentTranslation/includes/ActionApi/ApiQueryContentTranslation.php(221): ContentTranslation\DTO\CXDraftTranslationDTO::createFromTranslation(ContentTranslation\Translation)
#2 /srv/mediawiki/php-1.42.0-wmf.1/extensions/ContentTranslation/includes/ActionApi/ApiQueryContentTranslation.php(108): ContentTranslation\ActionApi\ApiQueryContentTranslation->serveDesktopEditorDraft(array)
#3 /srv/mediawiki/php-1.42.0-wmf.1/extensions/ContentTranslation/includes/ActionApi/ApiQueryContentTranslation.php(61): ContentTranslation\ActionApi\ApiQueryContentTranslation->run()
#4 /srv/mediawiki/php-1.42.0-wmf.1/includes/api/ApiQuery.php(695): ContentTranslation\ActionApi\ApiQueryContentTranslation->execute()
#5 /srv/mediawiki/php-1.42.0-wmf.1/includes/api/ApiMain.php(1931): ApiQuery->execute()
#6 /srv/mediawiki/php-1.42.0-wmf.1/includes/api/ApiMain.php(908): ApiMain->executeAction()
#7 /srv/mediawiki/php-1.42.0-wmf.1/includes/api/ApiMain.php(879): ApiMain->executeActionWithErrorHandling()
#8 /srv/mediawiki/php-1.42.0-wmf.1/api.php(95): ApiMain->execute()
#9 /srv/mediawiki/php-1.42.0-wmf.1/api.php(48): wfApiMain()
#10 /srv/mediawiki/w/api.php(3): require(string)
#11 {main}

Impact

Unclear.

Notes

16 of these in 1.42.0-wmf.1 (T348354).

Details

Request URL: https://he.wikipedia.org/w/api.php?action=query&format=*&from=*&list=*&sourcetitle=*&to=*&usecase=*

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	CXDraftTranslationDTO: Fix targetCategories type	mediawiki/extensions/ContentTranslation	master	+3 -3

Customize query in gerrit

Related Objects

Mentioned In: T349992: Error message while using the content translation tool: Unable to fetch draft information
T348797: Translation stopped saving while translating an article
T349893: Not able to restore saved translations
T349343: TypeError: Argument 2 passed to ContentTranslation\Store\TranslationStore::findTranslationsByTitles() must be of the type string, null given
Mentioned Here: rECTX8f4e571bc0fb: CX: Add DTO classes for draft translation payload for desktop editor
T348354: 1.42.0-wmf.1 deployment blockers

Event Timeline

brennen created this task.Oct 19 2023, 3:30 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 19 2023, 3:30 PM

brennen renamed this task from TypeError: Argument 9 passed to ContentTranslation\DTO\CXDraftTranslationDTO::__construct() must be of the type array or null, string given, called in /srv/mediawiki/php-1.42.0-wmf.1/extensions/ContentTranslation/includes/DTO/C to TypeError: Argument 9 passed to ContentTranslation\DTO\CXDraftTranslationDTO::__construct() must be of the type array or null, string given.Oct 19 2023, 3:31 PM

brennen updated the task description. (Show Details)

KartikMistry added a subscriber: ngkountas.Oct 19 2023, 5:14 PM

KartikMistry subscribed.

brennen mentioned this in T349343: TypeError: Argument 2 passed to ContentTranslation\Store\TranslationStore::findTranslationsByTitles() must be of the type string, null given.Oct 19 2023, 7:33 PM

Guessing fallout from 8f4e571bc / https://gerrit.wikimedia.org/r/c/mediawiki/extensions/ContentTranslation/+/964866

Change 967395 had a related patch set uploaded (by Nik Gkountas; author: Nik Gkountas):

[mediawiki/extensions/ContentTranslation@master] CXDraftTranslationDTO: Fix targetCategories type

https://gerrit.wikimedia.org/r/967395

gerritbot added a project: Patch-For-Review.Oct 20 2023, 8:08 AM

Nikerabbit edited projects, added Language-Team (Language-2023-October-December), Unplanned-Sprint-Work; removed Language-Team.Oct 21 2023, 7:55 AM

Nikerabbit moved this task from Quarter Backlog to In Progress on the Language-Team (Language-2023-October-December) board.

Change 967395 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] CXDraftTranslationDTO: Fix targetCategories type

https://gerrit.wikimedia.org/r/967395

ReleaseTaggerBot added a project: MW-1.42-notes (1.42.0-wmf.3; 2023-10-31).Oct 25 2023, 2:00 AM

Maintenance_bot removed a project: Patch-For-Review.Oct 25 2023, 2:10 AM

Nikerabbit assigned this task to ngkountas.Oct 25 2023, 12:00 PM

Nikerabbit triaged this task as High priority.

brennen moved this task from Backlog to Logs/Train on the User-brennen board.Oct 25 2023, 4:06 PM

thcipriani moved this task from Untriaged to October 2023 on the Wikimedia-production-error board.Oct 26 2023, 3:16 PM

ngkountas mentioned this in T349893: Not able to restore saved translations.Oct 30 2023, 10:06 AM

ngkountas mentioned this in T348797: Translation stopped saving while translating an article.Oct 30 2023, 11:55 AM

Ranveig subscribed.Oct 30 2023, 2:19 PM

ngkountas moved this task from In Progress to Check after deployment on the Language-Team (Language-2023-October-December) board.Oct 31 2023, 5:38 PM

Here is an example of the error being thrown in production:

The same translation can now be restored as the issue has been resolved in production:

Thus, this task can be considered as done.

ngkountas moved this task from Check after deployment to Done on the Language-Team (Language-2023-October-December) board.Nov 6 2023, 7:56 AM

ngkountas mentioned this in T349992: Error message while using the content translation tool: Unable to fetch draft information.

Nikerabbit moved this task from Needs Triage to Bugs on the ContentTranslation board.Nov 6 2023, 11:30 AM

Pginer-WMF closed this task as Resolved.Nov 21 2023, 11:34 AM

	F41456034: image.png
	Nov 6 2023, 7:55 AM

	F41456030: image.png
	Nov 6 2023, 7:55 AM

TypeError: Argument 9 passed to ContentTranslation\DTO\CXDraftTranslationDTO::__construct() must be of the type array or null, string givenClosed, ResolvedPublicPRODUCTION ERRORActions