Can't see anything past table.diff (including patrol links)
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To

Authored By

	MJL
	Nov 3 2023, 4:00 AM

Description

Steps to replicate the issue (include links if applicable):

Option 1: Go to this page on a mobile device
Option 2: Go to this page on desktop and zoom in approximately 150%.

What happens?: Nothing appears past halfway within "Statement by Tamzin".

What should have happened instead?: The rest of the comments show

Other information:

I think it has to do with the following code (simplified):

@media (max-width: 1000px) table.diff ~ * {display: none !important;}

QA Results - Prod

AC	Status	Details
1	✅	T350454#9343321

Details

	Subject	Repo	Branch	Lines +/-
	Mobile diffs default to diff only view	mediawiki/extensions/MobileFrontend	master	+10 -3
	Restore content below diff	mediawiki/skins/MinervaNeue	master	+0 -1

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved	BUG REPORT	Jdlrobson	T350454 Can't see anything past table.diff (including patrol links)
		Duplicate	BUG REPORT	Jdlrobson	T350650 Patrol link on diff pages disappeared on Persian Wikipedia

Event Timeline

MJL created this task.Nov 3 2023, 4:00 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 3 2023, 4:00 AM

Which screen width in pixels? Which browser(s)? Does that also happen in a private browser window when you are logged out?

Aklapper changed the task status from Open to Stalled.Nov 5 2023, 9:07 AM

In T350454#9304252, @Aklapper wrote:

Which screen width in pixels? Which browser(s)? Does that also happen in a private browser window when you are logged out?

For option 2, my screen resolution was 1280 x 720. The browser was Chrome, and it still happened when I was logged out and incognito.

I'm afraid I still cannot reproduce :(

I can reproduce. Looking at https://en.m.wikipedia.org/w/index.php?title=Wikipedia:Arbitration/Requests/Clarification_and_Amendment&oldid=1183235045#Statement_by_Tamzin with different browser widths:

I think this is the same problem as T350515. mediawiki.diff.styles is loaded on this page as a dependency of ext.visualEditor.mwsave, which is loaded as an indirect dependency of DiscussionTools.

T350596

Jdlrobson mentioned this in T350637: Cannot access the footer on Minerva diff pages as no way to target styles specific to this page.Nov 6 2023, 11:21 PM

Izno subscribed.Nov 7 2023, 2:41 AM

Johannnes89 subscribed.Nov 7 2023, 10:19 PM

Jdlrobson added a project: MediaWiki-Page-diffs.Nov 7 2023, 11:21 PM

Jdlrobson renamed this task from Can't see anything past table.diff to Can't see anything past table.diff (including patrol links).Nov 8 2023, 6:41 PM

Jdlrobson added a subtask: T350650: Patrol link on diff pages disappeared on Persian Wikipedia.

Jdlrobson merged a task: T350650: Patrol link on diff pages disappeared on Persian Wikipedia.Nov 8 2023, 6:45 PM

Jdlrobson added subscribers: Jeeputer, Arian_Ar, Ladsgroup and 2 others.

Change 972872 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/MinervaNeue@master] Restore content below diff

https://gerrit.wikimedia.org/r/972872

gerritbot added a project: Patch-For-Review.Nov 8 2023, 6:45 PM

Change 972873 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/extensions/MobileFrontend@master] Mobile diffs default to diff only view

https://gerrit.wikimedia.org/r/972873

Jdlrobson added a project: Web-Team-Backlog (Needs Prioritization (Tech)).Nov 8 2023, 7:37 PM

Change 972872 merged by jenkins-bot:

[mediawiki/skins/MinervaNeue@master] Restore content below diff

https://gerrit.wikimedia.org/r/972872

Change 972873 merged by jenkins-bot:

[mediawiki/extensions/MobileFrontend@master] Mobile diffs default to diff only view

https://gerrit.wikimedia.org/r/972873

ReleaseTaggerBot added a project: MW-1.42-notes (1.42.0-wmf.5; 2023-11-14).Nov 13 2023, 4:00 PM

Maintenance_bot removed a project: Patch-For-Review.Nov 13 2023, 4:11 PM

I verified that the patrol link is now restored on https://fa.m.wikipedia.org/wiki/%D9%88%DB%8C%DA%98%D9%87:%D8%AA%D9%81%D8%A7%D9%88%D8%AA_%DA%AF%D9%88%D8%B4%DB%8C_%D9%87%D9%85%D8%B1%D8%A7%D9%87/38207072

Jeeputer mentioned this in T350650: Patrol link on diff pages disappeared on Persian Wikipedia.Nov 19 2023, 7:40 AM

Test Result - Prod

Status: ✅ PASS
Environment: enwiki
OS: macOS Sonoma
Browser: Chrome
Device: MBA
Emulated Device:NA

Test Artifact(s):

QA Steps

Option 1: Go to this page on a mobile device
Option 2: Go to this page on desktop and zoom in approximately 150%.
✅ AC1: The rest of the comments show past the diff table.

Option 1	Option 2

Edtadros updated the task description. (Show Details)Nov 19 2023, 8:20 PM

Edtadros mentioned this in T350416: Verify 1.42.0-wmf.5 deployment.Nov 19 2023, 9:26 PM

	F41520641: screenshot 257.png
	Nov 19 2023, 8:10 PM

	F41520642: screenshot 256.png
	Nov 19 2023, 8:10 PM

	F41459534: image.png
	Nov 6 2023, 6:40 PM

	F41459532: image.png
	Nov 6 2023, 6:40 PM

Can't see anything past table.diff (including patrol links)Closed, ResolvedPublicBUG REPORTActions