Structured Data on Wikimedia Commons is not longer available
Description
Details
Status | Subtype | Assigned | Task | ||
---|---|---|---|---|---|
Resolved | Release | jnuche | T350080 1.42.0-wmf.4 deployment blockers | ||
Resolved | BUG REPORT | Cparle | T350777 1.42.0-wmf.4: Structured Data on Wikimedia Commons not longer available |
Event Timeline
@Raymond This bug was filed while the train was being deployed to group1, which includes commons. Can you please verify the problem wasn't transient?
Also, do you have any captures/errors/logs that show the problem?
I can see a few recent low-frequency errors referencing Wikibase in the client logs, but they also affect wmf.3 and I couldn't see any references to the missing MediaInfo tabs/view. Nothing in the backend logs that I can see.
However I can confirm the problem and consider this warrants a rollback. Also tagging the bug with WikibaseMediaInfo.
The only recent change to the extension that went in wmf.4 is: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/WikibaseMediaInfo/+/971246
Pinging here the folks from that patch: @Esanders @Jdforrester-WMF
Change 972714 had a related patch set uploaded (by Jforrester; author: Jforrester):
[mediawiki/extensions/WikibaseMediaInfo@master] Revert "Fix remaining uses of 'parent'->'super'"
Change 972715 had a related patch set uploaded (by Jforrester; author: Jforrester):
[mediawiki/extensions/WikibaseMediaInfo@wmf/1.42.0-wmf.4] Revert "Fix remaining uses of 'parent'->'super'"
Yeah, it's possible the bug is in WBMI rather than Wikibase itself; there's nothing in the WB commits that looks suspicious.
Have speculatively pushed a revert; if that fixes things, please go ahead.
Note that the mediainfoview does not exist error is still present in the console on commons after rolling back the train, even though the bug described by this ticket is gone
Looks like it's this commit in mediawiki-core that causes the problem d0a96db0f94fafa65ff693288d4ad6bf034378a3 @Krinkle any ideas what might be going awry?
You can see the issue on Beta Cluster Commons, e.g. https://commons.wikimedia.beta.wmflabs.org/wiki/File:Icon_for_char_%E8%B0%AB_midnightblue_mediumaquamarine_32x32.png – but nothing in the console, and I've just spotted that Beta Cluster's logstash entries dropped dead two days ago. Filing…
Oh! Yeah, WBMI hacks in its contents using a fragile regex, and that regex probably broke with the change to the DOM. Easy to fix.
Change 972846 had a related patch set uploaded (by Cparle; author: Cparle):
[mediawiki/extensions/WikibaseMediaInfo@master] Modify regex to reflect updated DOM
Change 972846 merged by jenkins-bot:
[mediawiki/extensions/WikibaseMediaInfo@master] Modify regex to reflect updated DOM
Change 972720 had a related patch set uploaded (by Jforrester; author: Cparle):
[mediawiki/extensions/WikibaseMediaInfo@wmf/1.42.0-wmf.4] Modify regex to reflect updated DOM
Change 972714 abandoned by Jforrester:
[mediawiki/extensions/WikibaseMediaInfo@master] Revert "Fix remaining uses of 'parent'->'super'"
Reason:
Change 972715 abandoned by Jforrester:
[mediawiki/extensions/WikibaseMediaInfo@wmf/1.42.0-wmf.4] Revert "Fix remaining uses of 'parent'->'super'"
Reason:
Change 972720 merged by jenkins-bot:
[mediawiki/extensions/WikibaseMediaInfo@wmf/1.42.0-wmf.4] Modify regex to reflect updated DOM
Mentioned in SAL (#wikimedia-operations) [2023-11-08T16:39:33Z] <jforrester@deploy2002> Started scap: Backport for [[gerrit:972721|Skip PerformanceBudgetTest::testTotalModulesSize (T350338)]], [[gerrit:972720|Modify regex to reflect updated DOM (T350777)]]
Mentioned in SAL (#wikimedia-operations) [2023-11-08T16:40:56Z] <jforrester@deploy2002> jforrester: Backport for [[gerrit:972721|Skip PerformanceBudgetTest::testTotalModulesSize (T350338)]], [[gerrit:972720|Modify regex to reflect updated DOM (T350777)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)
Mentioned in SAL (#wikimedia-operations) [2023-11-08T16:47:03Z] <jforrester@deploy2002> Finished scap: Backport for [[gerrit:972721|Skip PerformanceBudgetTest::testTotalModulesSize (T350338)]], [[gerrit:972720|Modify regex to reflect updated DOM (T350777)]] (duration: 07m 29s)