LandingCheck uses geoip_country_code_by_name which uses the sunset geoip1 database that isn't updated since April 2022, so it's likely to return invalid results. It should move to use the geoip 2 interface or at least remove the call:
Description
Description
Details
Details
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Remove calls to GeoIP 1 in Extension:LandingCheck | mediawiki/extensions/LandingCheck | master | +1 -9 |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | PRODUCTION ERROR | jijiki | T352156 PHP Warning: geoip_country_code_by_name(): Required database not available at /usr/share/GeoIP/GeoIP.dat. | ||
| Resolved | None | T352247 Remove calls to GeoIP 1 in Extension:LandingCheck |
Event Timeline
Comment Actions
Raising the priority because at best Special:landingcheck is using data from 1 year and a half ago. Given we're entering our main fundraiser, this should probably be solved?
Comment Actions
Oops, we did this last March for Special:FundraiserLandingPage in T301485: PHP Warning: geoip_country_code_by_name(): Required database not available at /usr/share/GeoIP/GeoIP.dat. but didn't notice that LandingCheck had it too.
Both are first consulting the GeoIP cookie that varnish adds to the request. When that's missing we aren't likely to get any better results from a PHP-level lookup, so we can just remove the code to fall back to geoip_country_code_by_name as we did with FundraiserLandingPage.
Comment Actions
Change 981327 had a related patch set uploaded (by Damilare Adedoyin; author: Damilare Adedoyin):
[mediawiki/extensions/LandingCheck@master] Remove calls to GeoIP 1 in Extension:LandingCheck
Comment Actions
Change 981327 merged by jenkins-bot:
[mediawiki/extensions/LandingCheck@master] Remove calls to GeoIP 1 in Extension:LandingCheck