Page MenuHomePhabricator

Add block and block_target tables in production
Closed, ResolvedPublic

Description

  • Patch to run: fd9c7c2d3e44c23aa5117f0b2545b5472160fcf9 maintenance/archives/patch-block_target.sql
  • Where: deployment-prep, all.dblist.
  • When: now
  • Backwards compatible: yes
  • Has been tested in beta/production: gated by config flag, final QA will be done after table creation.
  • Private data: eventually yes. There will be a WMCS patch prior to activation in config.
  • Is blocking a feature rollout: no. Eventually it will be required for T194697 but this is not yet ready.

Event Timeline

FWIW, there has been some misunderstandings (and sorta my fault), table creations needs to be signed off by DBAs but don't need to be done by DBAs (I thought it's adding columns as it was in the original plan IIRC and that's a schema change). Since I knew the work and the design well, I signed off on it and went ahead and created it anyway. So this is done.

Random DBA notes:

  • This won't take much space but since block info will be read basically on every interaction with the site, please make sure reads don't break the site (as something to keep in mind)
  • As you said, before writing to the table, the view rules need to be written, merged and deployed (via running maintain-views on every cloud db), let me know if you need a hand for that. This is important as if deployment doesn't happen, it might leak private data.