Page MenuHomePhabricator
Create Task
Maniphest T355521

Gerrit Zuul plugin does not show Depends-On/Needed-By since Gerrit 3.7
Closed, ResolvedPublic
Actions

Description

Given a change that depends on another one, the Depends-On/Needed-By section titles do show up on the side of the commit message but remain empty. The browser console shows a stacktrace:

stacktrace
TypeError: Gerrit.Nav is undefined
    _computeDependencyUrl https://gerrit.wikimedia.org/r/plugins/zuul/static/zuul.js:143
    jt https://gerrit.wikimedia.org/r/elements/gr-app.js:1
    _evaluateBinding https://gerrit.wikimedia.org/r/elements/gr-app.js:1
    Ft https://gerrit.wikimedia.org/r/elements/gr-app.js:1
    St https://gerrit.wikimedia.org/r/elements/gr-app.js:1
    o https://gerrit.wikimedia.org/r/elements/gr-app.js:1
    _runEffectsForTemplate https://gerrit.wikimedia.org/r/elements/gr-app.js:1
    _propagatePropertyChanges https://gerrit.wikimedia.org/r/elements/gr-app.js:1
    _propertiesChanged https://gerrit.wikimedia.org/r/elements/gr-app.js:1
    _flushProperties https://gerrit.wikimedia.org/r/elements/gr-app.js:1
    ready https://gerrit.wikimedia.org/r/elements/gr-app.js:1
    _enableProperties https://gerrit.wikimedia.org/r/elements/gr-app.js:1
    Vr https://gerrit.wikimedia.org/r/elements/gr-app.js:1
    o https://gerrit.wikimedia.org/r/elements/gr-app.js:1
    s https://gerrit.wikimedia.org/r/elements/gr-app.js:1
    __stampInstance https://gerrit.wikimedia.org/r/elements/gr-app.js:1
    __insertInstance https://gerrit.wikimedia.org/r/elements/gr-app.js:1
    __updateInstances https://gerrit.wikimedia.org/r/elements/gr-app.js:1
    __render https://gerrit.wikimedia.org/r/elements/gr-app.js:1
    _timer https://gerrit.wikimedia.org/r/elements/gr-app.js:1
    <anonymous> https://gerrit.wikimedia.org/r/elements/gr-app.js:1

Plugin documentation https://gerrit.wikimedia.org/r/plugins/zuul/Documentation/index.html

The server side REST API works so that querying the info for https://gerrit.wikimedia.org/r/c/translatewiki/+/991281/2 gives some info:

$ curl -sSf https://gerrit.wikimedia.org/r/changes/991281/revisions/a4b8b30507fedfe62c22d527c19a92ab3107a02a/crd|tail -n1|jq 
{
  "depends_on_found": [
    {
      "id": "mediawiki%2Fextensions%2FTranslate~master~Id5cfc06468c45f537221e94d3dc651188647ed6e",
      "project": "mediawiki/extensions/Translate",
...
      "change_id": "Id5cfc06468c45f537221e94d3dc651188647ed6e",
      "subject": "Deprecate use of Translate:GettextFFS:headerFields hook.",...

  "depends_on_missing": [],
  "needed_by": [],
  "cycle": false
}

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Update Zuul plugin for Gerrit 3.7operations/software/gerritdeploy/wmf/stable-3.7+2 -2
Update Zuul plugin for Gerrit 3.7operations/software/gerritwmf/stable-3.7+2 -1
Customize query in gerrit

Related Objects

Event Timeline

hashar created this task.Jan 22 2024, 10:53 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 22 2024, 10:53 AM
hashar added a project: Upstream.EditedJan 22 2024, 10:58 AM

Caused by 54934debee842065a9716c88db4a1ff441dfd188 / https://gerrit-review.googlesource.com/c/gerrit/+/346479 Replace GerritNav.navigateToRelativeUrl() by new setUrl() service which removes the Gerrit.Nav alias:

--- a/polygerrit-ui/app/elements/shared/gr-js-api-interface/gr-gerrit.ts
+++ b/polygerrit-ui/app/elements/shared/gr-js-api-interface/gr-gerrit.ts
 class GerritImpl implements GerritInternal {
   _customStyleSheet?: CSSStyleSheet;
 
-  public readonly Nav = GerritNav;
-

And Iabb10c / https://gerrit-review.googlesource.com/c/gerrit/+/345677 removes GerritNav.getUrlForSearchQuery in favor of a createSearchUrl which I have no idea how to invoke.

Stashbot added a comment.Jan 22 2024, 11:05 AM

Mentioned in SAL (#wikimedia-releng) [2024-01-22T11:05:06Z] <hashar> Branched stable-3.7 on upstream https://gerrit.googlesource.com/plugins/zuul # T355521

Michael subscribed.Jan 22 2024, 11:56 AM
hashar added a comment.Jan 22 2024, 2:24 PM

I have send a patch Upstream https://gerrit-review.googlesource.com/c/plugins/zuul/+/404117 Inline removal of Gerrit.Nav in Gerrit 3.7

gerritbot added a comment.Jan 22 2024, 2:39 PM

Change 992191 had a related patch set uploaded (by Hashar; author: Hashar):

[operations/software/gerrit@wmf/stable-3.7] Update Zuul plugin for Gerrit 3.7

https://gerrit.wikimedia.org/r/992191

gerritbot added a project: Patch-For-Review.Jan 22 2024, 2:39 PM
gerritbot added a comment.Jan 22 2024, 2:48 PM

Change 992193 had a related patch set uploaded (by Hashar; author: Hashar):

[operations/software/gerrit@deploy/wmf/stable-3.7] Update Zuul plugin for Gerrit 3.7

https://gerrit.wikimedia.org/r/992193

gerritbot added a comment.Jan 22 2024, 2:53 PM

Change 992191 merged by jenkins-bot:

[operations/software/gerrit@wmf/stable-3.7] Update Zuul plugin for Gerrit 3.7

https://gerrit.wikimedia.org/r/992191

gerritbot added a comment.Jan 22 2024, 2:53 PM

Change 992193 merged by jenkins-bot:

[operations/software/gerrit@deploy/wmf/stable-3.7] Update Zuul plugin for Gerrit 3.7

https://gerrit.wikimedia.org/r/992193

Stashbot added a comment.Jan 22 2024, 2:54 PM

Mentioned in SAL (#wikimedia-operations) [2024-01-22T14:54:55Z] <hashar@deploy2002> Started deploy [gerrit/gerrit@6257faa]: Update Zuul plugin for Gerrit 3.7 - T355521

Stashbot added a comment.Jan 22 2024, 2:55 PM

Mentioned in SAL (#wikimedia-operations) [2024-01-22T14:55:02Z] <hashar@deploy2002> Finished deploy [gerrit/gerrit@6257faa]: Update Zuul plugin for Gerrit 3.7 - T355521 (duration: 00m 07s)

hashar closed this task as Resolved.Jan 22 2024, 3:07 PM
hashar claimed this task.

That is fixed! Thank you @ihurbain for the report.

Maintenance_bot removed a project: Patch-For-Review.Jan 22 2024, 3:30 PM
Lucas_Werkmeister_WMDE mentioned this in T355635: Gerrit "Depends on" / "Needed by" display broken by 3.7 upgrade.Jan 23 2024, 9:38 AM
hashar merged a task: T355635: Gerrit "Depends on" / "Needed by" display broken by 3.7 upgrade.Jan 23 2024, 11:15 AM
hashar added subscribers: Tgr, Lucas_Werkmeister_WMDE, Winston_Sung, kostajh.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits