Page MenuHomePhabricator

SX: Refactor SFCs to use <script setup> syntax
Open, In Progress, MediumPublic

Description

<script setup> syntax is preferable as it's the officially recommended syntax when using both SFCs and Composition API, which SX does.

Update

The following SFCs inside SectionTranslation codebase should be refactored to use <script setup> syntax:

  • CXFavoriteList.vue
  • CXHelpPanel.vue
  • CXStatsPanel.vue
  • CXTranslationSuggestion.vue
  • CXTranslationWork.vue
  • ExperimentalSupportBanner.vue
  • SXConfirmTranslationDeletionDialog.vue
  • MWLanguageSelector.vue
  • ArticleSuggestionsCard.vue
  • SearchResultsCard.vue
  • SXSearchArticleSuggestion.vue
  • NewSectionPlaceholder.vue
  • SourceVsTargetSelector.vue
  • SXContentComparator.vue
  • SXContentComparatorContentHeader.vue
  • SXContentComparatorHeader.vue
  • SXContentComparatorHeaderMappedSection.vue
  • SXContentComparatorHeaderNavigation.vue
  • EditCompleteFeedback.vue
  • SXEditor.vue
  • SXEditorOriginalContent.vue
  • SXPublisherAnimationDialog.vue
  • SXSectionSelector.vue
  • SXSectionSelectorSectionListPresent.vue
  • BlockTemplateStatusIndicator.vue
  • SubSection.vue
  • SXBlockTemplateStatusDialog.vue
  • SXSentenceSelectorContentHeader.vue
  • SXTranslationSelector.vue
  • TranslatedSegmentCardHeader.vue
  • SXArticleLanguageSelector.vue
  • MWBottomNavigation.vue

All the remaining SFCs (32 in total) have been successfully refactored.

Acceptance criteria

No results with this search: https://codesearch.wmcloud.org/search/?q=%3Cscript%3E&files=app%2Fsrc%2Fcomponents.*vue%24&excludeFiles=&repos=Extension%3AContentTranslation

Details

SubjectRepoBranchLines +/-
mediawiki/extensions/ContentTranslationmaster+28 -39
mediawiki/extensions/ContentTranslationmaster+18 -27
mediawiki/extensions/ContentTranslationmaster+123 -153
mediawiki/extensions/ContentTranslationmaster+51 -64
mediawiki/extensions/ContentTranslationmaster+32 -37
mediawiki/extensions/ContentTranslationmaster+64 -73
mediawiki/extensions/ContentTranslationmaster+30 -38
mediawiki/extensions/ContentTranslationmaster+26 -42
mediawiki/extensions/ContentTranslationmaster+59 -66
mediawiki/extensions/ContentTranslationmaster+43 -58
mediawiki/extensions/ContentTranslationmaster+30 -38
mediawiki/extensions/ContentTranslationmaster+95 -120
mediawiki/extensions/ContentTranslationmaster+69 -96
mediawiki/extensions/ContentTranslationmaster+16 -31
mediawiki/extensions/ContentTranslationmaster+97 -114
mediawiki/extensions/ContentTranslationmaster+49 -70
mediawiki/extensions/ContentTranslationmaster+2 K -2 K
mediawiki/extensions/ContentTranslationmaster+24 -26
mediawiki/extensions/ContentTranslationmaster+7 K -7 K
mediawiki/extensions/ContentTranslationmaster+44 -59
mediawiki/extensions/ContentTranslationmaster+73 -102
mediawiki/extensions/ContentTranslationwmf/1.43.0-wmf.24+7 K -7 K
mediawiki/extensions/ContentTranslationmaster+7 K -7 K
mediawiki/extensions/ContentTranslationmaster+7 K -7 K
mediawiki/extensions/ContentTranslationmaster+53 -64
mediawiki/extensions/ContentTranslationmaster+4 K -4 K
mediawiki/extensions/ContentTranslationmaster+65 -85
mediawiki/extensions/ContentTranslationmaster+6 K -12 K
mediawiki/extensions/ContentTranslationmaster+150 -190
mediawiki/extensions/ContentTranslationmaster+25 -41
mediawiki/extensions/ContentTranslationmaster+17 -25
mediawiki/extensions/ContentTranslationmaster+70 -92
mediawiki/extensions/ContentTranslationmaster+93 -123
mediawiki/extensions/ContentTranslationmaster+32 -35
mediawiki/extensions/ContentTranslationmaster+189 -235
mediawiki/extensions/ContentTranslationmaster+81 -117
mediawiki/extensions/ContentTranslationmaster+76 -104
mediawiki/extensions/ContentTranslationmaster+23 -35
Show related patches Customize query in gerrit

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes
Nikerabbit subscribed.

@ngkountas Can you update this task with a summary of the current status (what has been done, what remains to be done)?

I updated the task description to reflect the current status of this task.

Change #1054616 had a related patch set uploaded (by Nik Gkountas; author: Nik Gkountas):

[mediawiki/extensions/ContentTranslation@master] CXTranslationSuggestion: Migrate to use <script setup> syntax

https://gerrit.wikimedia.org/r/1054616

Change #1054616 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] CXTranslationSuggestion: Migrate to use <script setup> syntax

https://gerrit.wikimedia.org/r/1054616

Change #1055889 had a related patch set uploaded (by Nik Gkountas; author: Nik Gkountas):

[mediawiki/extensions/ContentTranslation@master] CX3 Build 0.2.0+20240722

https://gerrit.wikimedia.org/r/1055889

Change #1055889 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] CX3 Build 0.2.0+20240722

https://gerrit.wikimedia.org/r/1055889

Change #1072263 had a related patch set uploaded (by Nik Gkountas; author: Nik Gkountas):

[mediawiki/extensions/ContentTranslation@master] SXEditor: Migrate to use <script setup> syntax

https://gerrit.wikimedia.org/r/1072263

Change #1074150 had a related patch set uploaded (by Nik Gkountas; author: Nik Gkountas):

[mediawiki/extensions/ContentTranslation@master] SXSentenceSelectorContentHeader: Migrate to use <script setup> syntax

https://gerrit.wikimedia.org/r/1074150

Change #1074150 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] SXSentenceSelectorContentHeader: Migrate to use <script setup> syntax

https://gerrit.wikimedia.org/r/1074150

Change #1075030 had a related patch set uploaded (by Nik Gkountas; author: Nik Gkountas):

[mediawiki/extensions/ContentTranslation@master] CX3 Build 0.2.0+20240923

https://gerrit.wikimedia.org/r/1075030

Change #1075231 had a related patch set uploaded (by Nik Gkountas; author: Nik Gkountas):

[mediawiki/extensions/ContentTranslation@master] CX3 Build 0.2.0+20240923

https://gerrit.wikimedia.org/r/1075231

Change #1075030 abandoned by Nik Gkountas:

[mediawiki/extensions/ContentTranslation@master] CX3 Build 0.2.0+20240923

Reason:

Abandoned in favor of Iac0466a3d2bd906a33c1c6052a92b3be98f5b028

https://gerrit.wikimedia.org/r/1075030

Change #1075231 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] CX3 Build 0.2.0+20240925

https://gerrit.wikimedia.org/r/1075231

Change #1075567 had a related patch set uploaded (by Sbisson; author: Nik Gkountas):

[mediawiki/extensions/ContentTranslation@wmf/1.43.0-wmf.24] CX3 Build 0.2.0+20240925

https://gerrit.wikimedia.org/r/1075567

Change #1075567 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@wmf/1.43.0-wmf.24] CX3 Build 0.2.0+20240925

https://gerrit.wikimedia.org/r/1075567

Mentioned in SAL (#wikimedia-operations) [2024-09-25T14:22:59Z] <kartik@deploy1003> Finished scap sync-world: Backport for [[gerrit:1075567|CX3 Build 0.2.0+20240925 (T374387 T370746 T368422 T374567 T355780 T374559 T374886 T375410)]] (duration: 14m 06s)

Change #1072263 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] SXEditor: Migrate to use <script setup> syntax

https://gerrit.wikimedia.org/r/1072263

Change #1079550 had a related patch set uploaded (by Nik Gkountas; author: Nik Gkountas):

[mediawiki/extensions/ContentTranslation@master] CX3 Build 0.2.0+20241011

https://gerrit.wikimedia.org/r/1079550

Change #1081091 had a related patch set uploaded (by Nik Gkountas; author: Nik Gkountas):

[mediawiki/extensions/ContentTranslation@master] SXArticleLanguageSelector: Migrate to use <script setup> syntax

https://gerrit.wikimedia.org/r/1081091

Change #1081091 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] SXArticleLanguageSelector: Migrate to use <script setup> syntax

https://gerrit.wikimedia.org/r/1081091

Change #1079550 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] CX3 Build 0.2.0+20241018

https://gerrit.wikimedia.org/r/1079550

Change #1082831 had a related patch set uploaded (by Eamedina; author: Eamedina):

[mediawiki/extensions/ContentTranslation@master] MWBottomNavigation: Migrate to use <script setup> syntax

https://gerrit.wikimedia.org/r/1082831

Change #1082831 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] MWBottomNavigation: Migrate to use <script setup> syntax

https://gerrit.wikimedia.org/r/1082831

Change #1085612 had a related patch set uploaded (by Nik Gkountas; author: Nik Gkountas):

[mediawiki/extensions/ContentTranslation@master] CX3 Build 0.2.0+20241101

https://gerrit.wikimedia.org/r/1085612

Change #1085612 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] CX3 Build 0.2.0+20241101

https://gerrit.wikimedia.org/r/1085612

Change #1090943 had a related patch set uploaded (by Eamedina; author: Eamedina):

[mediawiki/extensions/ContentTranslation@master] SXSectionSelectorSectionListPresent: Migrate to use <script setup> syntax

https://gerrit.wikimedia.org/r/1090943

Change #1090949 had a related patch set uploaded (by Eamedina; author: Eamedina):

[mediawiki/extensions/ContentTranslation@master] SXSectionSelector: Migrate to use <script setup> syntax

https://gerrit.wikimedia.org/r/1090949

Change #1090950 had a related patch set uploaded (by Eamedina; author: Eamedina):

[mediawiki/extensions/ContentTranslation@master] SxContentComparatorContentHeader: Migrate to use <script setup> syntax

https://gerrit.wikimedia.org/r/1090950

Change #1090951 had a related patch set uploaded (by Eamedina; author: Eamedina):

[mediawiki/extensions/ContentTranslation@master] SxContentComparator: Migrate to use <script setup> syntax

https://gerrit.wikimedia.org/r/1090951

Change #1090956 had a related patch set uploaded (by Eamedina; author: Eamedina):

[mediawiki/extensions/ContentTranslation@master] SXContentComparatorHeader: Migrate to use <script setup> syntax

https://gerrit.wikimedia.org/r/1090956

Change #1090956 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] SXContentComparatorHeader: Migrate to use <script setup> syntax

https://gerrit.wikimedia.org/r/1090956

Change #1090950 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] SxContentComparatorContentHeader: Migrate to use <script setup> syntax

https://gerrit.wikimedia.org/r/1090950

Change #1090943 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] SXSectionSelectorSectionListPresent: Migrate to use <script setup> syntax

https://gerrit.wikimedia.org/r/1090943

Change #1090949 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] SXSectionSelector: Migrate to use <script setup> syntax

https://gerrit.wikimedia.org/r/1090949

Change #1090951 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] SxContentComparator: Migrate to use <script setup> syntax

https://gerrit.wikimedia.org/r/1090951

Change #1091287 had a related patch set uploaded (by Eamedina; author: Eamedina):

[mediawiki/extensions/ContentTranslation@master] SXContentComparatorHeaderNavigation: Migrate to use <script setup> syntax

https://gerrit.wikimedia.org/r/1091287

Change #1091294 had a related patch set uploaded (by Eamedina; author: Eamedina):

[mediawiki/extensions/ContentTranslation@master] SXContentComparatorHeaderMappedSection: Migrate to use <script setup> syntax

https://gerrit.wikimedia.org/r/1091294

Change #1091304 had a related patch set uploaded (by Eamedina; author: Eamedina):

[mediawiki/extensions/ContentTranslation@master] CXFavoriteList: Migrate to use <script setup> syntax

https://gerrit.wikimedia.org/r/1091304

Change #1091305 had a related patch set uploaded (by Eamedina; author: Eamedina):

[mediawiki/extensions/ContentTranslation@master] CXHelpPanel: Migrate to use <script setup> syntax

https://gerrit.wikimedia.org/r/1091305

Change #1091305 abandoned by Eamedina:

[mediawiki/extensions/ContentTranslation@master] CXHelpPanel: Migrate to use <script setup> syntax

https://gerrit.wikimedia.org/r/1091305

Change #1091307 had a related patch set uploaded (by Eamedina; author: Eamedina):

[mediawiki/extensions/ContentTranslation@master] CXHelpPanel: Migrate to use <script setup> syntax

https://gerrit.wikimedia.org/r/1091307

Change #1091312 had a related patch set uploaded (by Eamedina; author: Eamedina):

[mediawiki/extensions/ContentTranslation@master] CXStatsPanel: Migrate to use <script setup> syntax

https://gerrit.wikimedia.org/r/1091312

Change #1091287 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] SXContentComparatorHeaderNavigation: Migrate to use <script setup> syntax

https://gerrit.wikimedia.org/r/1091287

Change #1091294 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] SXContentComparatorHeaderMappedSection: Migrate to use <script setup> syntax

https://gerrit.wikimedia.org/r/1091294

Change #1091304 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] CXFavoriteList: Migrate to use <script setup> syntax

https://gerrit.wikimedia.org/r/1091304

Change #1091331 had a related patch set uploaded (by Eamedina; author: Eamedina):

[mediawiki/extensions/ContentTranslation@master] CXTranslationWork: Migrate to use <script setup> syntax

https://gerrit.wikimedia.org/r/1091331

Change #1091333 had a related patch set uploaded (by Eamedina; author: Eamedina):

[mediawiki/extensions/ContentTranslation@master] SXConfirmTranslationDeletionDialog: Migrate to use <script setup> syntax

https://gerrit.wikimedia.org/r/1091333

Change #1091307 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] CXHelpPanel: Migrate to use <script setup> syntax

https://gerrit.wikimedia.org/r/1091307

Change #1091339 had a related patch set uploaded (by Eamedina; author: Eamedina):

[mediawiki/extensions/ContentTranslation@master] MWLanguageSelector: Refactor to use <script setup> syntax

https://gerrit.wikimedia.org/r/1091339

Change #1091312 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] CXStatsPanel: Migrate to use <script setup> syntax

https://gerrit.wikimedia.org/r/1091312

Change #1091333 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] SXConfirmTranslationDeletionDialog: Migrate to use <script setup> syntax

https://gerrit.wikimedia.org/r/1091333

Change #1091331 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] CXTranslationWork: Migrate to use <script setup> syntax

https://gerrit.wikimedia.org/r/1091331

Change #1091339 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] MWLanguageSelector: Refactor to use <script setup> syntax

https://gerrit.wikimedia.org/r/1091339

Change #1093410 had a related patch set uploaded (by Eamedina; author: Eamedina):

[mediawiki/extensions/ContentTranslation@master] ArticleSuggestionsCard: Migrate to use <script setup> syntax

https://gerrit.wikimedia.org/r/1093410

Change #1093410 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] ArticleSuggestionsCard: Migrate to use <script setup> syntax

https://gerrit.wikimedia.org/r/1093410

Change #1093477 had a related patch set uploaded (by Eamedina; author: Eamedina):

[mediawiki/extensions/ContentTranslation@master] SearchResultsCard: Migrate to use <script-setup> syntax

https://gerrit.wikimedia.org/r/1093477