Page MenuHomePhabricator

H3s on Minerva have too much vertical space above them
Closed, DuplicatePublicBUG REPORT

Description

The new paragraph spacing in Minerva looks great for the most part, but it introduces too much vertical space around our h3/4 elements. These values need to be adjusted so that they're proportional.

Screenshot 2024-02-08 at 7.46.14 PM.png (1×778 px, 183 KB)

Event Timeline

JScherer-WMF renamed this task from Tweak paragraph spacing for h3/4s on Minerva with new font sizes to Tweak paragraph spacing for h3s on Minerva with new font sizes.Feb 29 2024, 2:19 PM
JScherer-WMF reopened this task as Open.

I looked into this again, and it seems to me like it's only the h3s that are an issue, but I can't quite figure out where the extra spacing is coming from on those. @bwang Do you want to pair on this again next sprint and figure out a solution?

It seems to only be an issue when a <p> element precedes it. In this example, an image precedes an h3 and it's fine, but then the spacing on the second h3 is too large.

Screenshot 2024-02-29 at 10.21.26 AM.png (1×748 px, 299 KB)

Example where it's ok for h4s but h3s are too big.

Screenshot 2024-02-29 at 10.21.43 AM.png (1×752 px, 217 KB)

JScherer-WMF raised the priority of this task from Medium to Needs Triage.
JScherer-WMF changed the subtype of this task from "Design" to "Bug Report".
JScherer-WMF added a subscriber: ovasileva.

related to T358808 and T358893.

Moving back to incoming so @ovasileva can triage the bug fix.

JScherer-WMF renamed this task from Tweak paragraph spacing for h3s on Minerva with new font sizes to H3s on Minerva have too much vertical space above them.Mar 18 2024, 4:53 PM
Jdlrobson subscribed.

Justin to create a new ticket with a revised design spec of how the text should behave.