| JScherer-WMF | |
| Feb 29 2024, 8:52 PM |
| F44417174: screenshot 174.png | |
| Thu, Apr 4, 2:43 AM |
| F44417173: screenshot 176.png | |
| Thu, Apr 4, 2:43 AM |
| F44417172: screenshot 175.png | |
| Thu, Apr 4, 2:43 AM |
| F43343654: Screenshot 2024-03-25 at 10.13.11 AM.png | |
| Mar 25 2024, 4:15 PM |
| F42263313: Screenshot 2024-02-29 at 1.37.20 PM.png | |
| Feb 29 2024, 8:52 PM |
Go to https://en.m.wikipedia.org/wiki/Dog
Scroll to Ecology > Range
Margins above and below the list should be equivalent.
It seems to have something to do with:
.content li:last-child {
margin-bottom: inherit;
}I'm not sure where it's inheriting that 0px bottom-margin from, but if the margin-bottom is set to 16px the correct behaviour is present.
| AC | Status | Details |
|---|---|---|
| 1 | ✅ | T358808#9686738 |
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Update padding on <p> elements | mediawiki/skins/MinervaNeue | master | +2 -1 |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Open | Jdrewniak | T341631 [EPIC] Q1 Main hypothesis: Typographical and palette customizations | |||
| Open | Jdrewniak | T313828 [EPIC] Typography: improve typography and allow for variable typography settings | |||
| Duplicate | BUG REPORT | JScherer-WMF | T358808 [Bug] Bottom margin on lists in Minerva are too short |
Change 1012422 had a related patch set uploaded (by Bernard Wang; author: Bernard Wang):
[mediawiki/skins/MinervaNeue@master] Update padding on <p> elements
Test wiki created on Patch demo by BWang (WMF) using patch(es) linked to this task:
https://patchdemo.wmflabs.org/wikis/26e5a3c635/w
https://patchdemo.wmflabs.org/wikis/26e5a3c635/wiki/Main_Page
https://patchdemo.wmflabs.org/wikis/26e5a3c635/wiki/The_Hitchhiker%27s_Guide_to_the_Galaxy#The_More_Than_Complete_Hitchhiker.27s_Guide
@JScherer-WMF I put together these patch demo links for you to review. I basically used the same fix as in Vector, where now <p> elements have .5em spacing on top and bottom, but using a mix of margin and padding so that adjacent <p> elements still have a total of 1em spacing. However just like in Vector, this impacts spacing of text overall because the <p> element is used next to so many different elements. Please take a look and let me know if its ok
@bwang Sorry for the delay in replying to this ticket. I'm not sure if this is one of the tradeoffs you mention above, but the subheading directly after a list doesn't have enough vertical spacing.
I merged the other vertical spacing tasks in T360917. Left this one because it's already in progress.
Change #1012422 merged by jenkins-bot:
[mediawiki/skins/MinervaNeue@master] Update padding on <p> elements
Status: ✅ PASS
Environment: enwiki
OS: macOS Sonoma
Browser: Chrome
Device: MBA
Emulated Device:NA
Test Artifact(s):
Go to https://en.m.wikipedia.org/wiki/Dog
Scroll to Ecology > Range
✅ AC1: Margins above and below the list should be equivalent.
