Page MenuHomePhabricator

Vector 2022 dynamic table of contents broken on Parsoid
Closed, ResolvedPublic3 Estimated Story PointsBUG REPORT

Description

NOTE: As noted in T337286 there is no stable API for accessing headings but given this regression we might want to re-prioritize that ticket.

Steps to replicate the issue (include links if applicable):

  • Enable Parsoid read views using ParserMigration (or office.wikimedia.org which is the only production site using this)
  • Visit a long page with many sections
  • Scroll down

What happens?:
Table of contents does not change at all

What should have happened instead?:
Table of contents should bold and expand the section you're currently on

Software version (skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):
If the current URL has an anchor, that section does get highlighted, althought that too does not get updated when scrolling (unless you scroll to the very top).

QA Results - Beta

ACStatusDetails
1T358452#9979201

QA Results - PROD

ACStatusDetails
1T358452#9979215

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes
Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Web team discussed this in our grooming meeting and it seems like it would be best if we schedule a quick meeting to decide on next steps together. @ovasileva will look for some time and schedule something.

Jdlrobson lowered the priority of this task from High to Medium.Apr 3 2024, 6:26 AM

I realized that the same problem is affecting my work on T13555. I hope you won't mind if I write the patch.

Change #860583 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/skins/Vector@master] Compatibility with new heading HTML (table of contents)

https://gerrit.wikimedia.org/r/860583

Change #1022398 had a related patch set uploaded (by Subramanya Sastry; author: Subramanya Sastry):

[integration/visualdiff@master] Revert "Force lazy elements to be loaded"

https://gerrit.wikimedia.org/r/1022398

Change #1022398 merged by jenkins-bot:

[integration/visualdiff@master] Revert "Force lazy elements to be loaded"

https://gerrit.wikimedia.org/r/1022398

Jdlrobson set the point value for this task to 3.Apr 25 2024, 5:55 PM

(@matmarex We'll move this to code review when we lock in the sprint - it's just in todo now so we have an idea of capacity)

ovasileva raised the priority of this task from Low to Medium.May 16 2024, 6:15 PM

Increasing the priority on this one so we don't forget to take a look. @matmarex - we've triaged this for our Sprint +1 (starting in two weeks and two days).

Jdlrobson raised the priority of this task from Medium to High.May 31 2024, 1:26 AM
Jdlrobson lowered the priority of this task from High to Medium.Jun 3 2024, 5:21 PM

Change #860583 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Compatibility with new heading HTML (table of contents)

https://gerrit.wikimedia.org/r/860583

Test Result - Beta

Status: ✅ PASS
Environment: Beta
OS: macOS Sonoma 14.5
Browser: Chrome 126
Device: MBA
Emulated Device: NA

Test Artifact(s):

Test Steps
  1. Enable Parsoid read views using ParserMigration (or office.wikimedia.org which is the only production site using this)
  2. Visit a long page with many sections (ex. https://en.m.wikipedia.beta.wmflabs.org/wiki/World_of_Warcraft)
  3. Scroll down
DesktopMobile
2024-07-13_09-01-48.mp4.gif (728×958 px, 2 MB)
2024-07-13_08-57-38.mp4.gif (726×966 px, 3 MB)
GMikesell-WMF assigned this task to ovasileva.
GMikesell-WMF updated the task description. (Show Details)
GMikesell-WMF subscribed.

Test Result - PROD

Status: ✅ PASS
Environment: PROD
OS: macOS Sonoma 14.5
Browser: Chrome 126
Device: MBA
Emulated Device: NA

Test Artifact(s):

Test Steps
  1. Enable Parsoid read views using ParserMigration in Preferences
  2. Visit a long page with many sections (ex. https://en.m.wikipedia.beta.wmflabs.org/wiki/World_of_Warcraft)
  3. Scroll down
DesktopMobile
2024-07-13_09-08-11.mp4.gif (730×968 px, 2 MB)
2024-07-13_09-11-00.mp4.gif (732×966 px, 2 MB)