Page MenuHomePhabricator

Display expired temporary account names differently
Closed, ResolvedPublic2 Estimated Story Points

Description

Aim

Similar to T345251: [Non-MVP] Decide a lexical prefix for displaying in front of temporary usernames and T347209: Investigate: Grey background for temporary usernames in signatures, mentions etc, it would be useful to have expired temporary accounts appear differently. E.g. instead of ~2024-681 we might see ~2024-681 (expired) or ~2024-681 (disabled). That way, editors won't waste time pinging temp users or e.g. attempting to block temp user accounts that aren't in use anymore.

Design

If temp account has expired:

  • Strikethrough temporary account name
  • Use tooltip to display text on hover: Temporary account has expired

Expired temp account-3.png (361×1 px, 47 KB)

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
mediawiki/coremaster+1 -1
mediawiki/extensions/PageTriagemaster+97 -12
mediawiki/extensions/CheckUsermaster+101 -12
mediawiki/coremaster+12 -13
mediawiki/coremaster+2 -2
mediawiki/extensions/AbuseFiltermaster+6 -6
mediawiki/extensions/AbuseFiltermaster+104 -78
mediawiki/coremaster+158 -11
mediawiki/coremaster+308 -13
mediawiki/coremaster+101 -13
mediawiki/coremaster+276 -0
mediawiki/coremaster+349 -39
mediawiki/extensions/CentralAuthmaster+0 -2
mediawiki/extensions/FlaggedRevsmaster+2 -0
mediawiki/extensions/AbuseFiltermaster+2 -0
mediawiki/extensions/CheckUsermaster+8 -2
mediawiki/extensions/GlobalBlockingmaster+1 -0
mediawiki/extensions/CampaignEventsmaster+9 -2
mediawiki/coremaster+44 -8
mediawiki/extensions/CentralAuthmaster+329 -1
mediawiki/coremaster+143 -36
mediawiki/coremaster+338 -57
Show related patches Customize query in gerrit

Related Objects

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes
kostajh set the point value for this task to 2.Oct 28 2024, 10:57 AM

Removing the specific sprint tag. We'll add another one once we know when we'll do this work.

mszabo changed the task status from Open to In Progress.Feb 11 2025, 1:17 PM
mszabo claimed this task.

Change #1118847 had a related patch set uploaded (by Máté Szabó; author: Máté Szabó):

[mediawiki/core@master] linker: Introduce UserLinkRenderer service

https://gerrit.wikimedia.org/r/1118847

Change #1118848 had a related patch set uploaded (by Máté Szabó; author: Máté Szabó):

[mediawiki/core@master] user: Introduce TempUserCache service

https://gerrit.wikimedia.org/r/1118848

Change #1118849 had a related patch set uploaded (by Máté Szabó; author: Máté Szabó):

[mediawiki/core@master] linker: Render expired temporary account names differently

https://gerrit.wikimedia.org/r/1118849

Change #1119496 had a related patch set uploaded (by Máté Szabó; author: Máté Szabó):

[mediawiki/core@master] Add mediawiki.interface.helpers module to pages with user links

https://gerrit.wikimedia.org/r/1119496

Change #1118847 merged by jenkins-bot:

[mediawiki/core@master] linker: Introduce UserLinkRenderer service

https://gerrit.wikimedia.org/r/1118847

Change #1119540 had a related patch set uploaded (by Máté Szabó; author: Máté Szabó):

[mediawiki/core@master] linker: Add process cache to UserLinkRenderer::userLink()

https://gerrit.wikimedia.org/r/1119540

Change #1119700 had a related patch set uploaded (by Máté Szabó; author: Máté Szabó):

[mediawiki/extensions/AbuseFilter@master] Add mediawiki.interface.helpers module to pages with user links

https://gerrit.wikimedia.org/r/1119700

Change #1119701 had a related patch set uploaded (by Máté Szabó; author: Máté Szabó):

[mediawiki/extensions/CheckUser@master] Add mediawiki.interface.helpers module to pages with user links

https://gerrit.wikimedia.org/r/1119701

Change #1119702 had a related patch set uploaded (by Máté Szabó; author: Máté Szabó):

[mediawiki/extensions/FlaggedRevs@master] Add mediawiki.interface.helpers module to pages with user links

https://gerrit.wikimedia.org/r/1119702

Change #1119705 had a related patch set uploaded (by Máté Szabó; author: Máté Szabó):

[mediawiki/extensions/CampaignEvents@master] Add mediawiki.interface.helpers module to pages with user links

https://gerrit.wikimedia.org/r/1119705

Change #1119706 had a related patch set uploaded (by Máté Szabó; author: Máté Szabó):

[mediawiki/extensions/GlobalBlocking@master] Add mediawiki.interface.helpers module to pages with user links

https://gerrit.wikimedia.org/r/1119706

Change #1119741 had a related patch set uploaded (by Máté Szabó; author: Máté Szabó):

[mediawiki/core@master] user: Implement batch user registration lookups

https://gerrit.wikimedia.org/r/1119741

Change #1119742 had a related patch set uploaded (by Máté Szabó; author: Máté Szabó):

[mediawiki/extensions/CentralAuth@master] Implement upcoming fetchRegistrationBatch() method

https://gerrit.wikimedia.org/r/1119742

Change #1119744 had a related patch set uploaded (by Máté Szabó; author: Máté Szabó):

[mediawiki/extensions/CentralAuth@master] Enable skipped testFetchRegistrationBatch()

https://gerrit.wikimedia.org/r/1119744

Change #1119540 merged by jenkins-bot:

[mediawiki/core@master] linker: Add process cache to UserLinkRenderer::userLink()

https://gerrit.wikimedia.org/r/1119540

Change #1120185 had a related patch set uploaded (by Máté Szabó; author: Máté Szabó):

[mediawiki/core@master] Preload temporary account expiration status where needed

https://gerrit.wikimedia.org/r/1120185

Change #1120204 had a related patch set uploaded (by Máté Szabó; author: Máté Szabó):

[mediawiki/extensions/PageTriage@master] NewPagesFeed: Update styling for expired temporary account links

https://gerrit.wikimedia.org/r/1120204

Change #1120210 had a related patch set uploaded (by Máté Szabó; author: Máté Szabó):

[mediawiki/extensions/AbuseFilter@master] Preload temporary account expiration status where needed

https://gerrit.wikimedia.org/r/1120210

Change #1119742 merged by jenkins-bot:

[mediawiki/extensions/CentralAuth@master] Implement upcoming fetchRegistrationBatch() method

https://gerrit.wikimedia.org/r/1119742

Change #1120933 had a related patch set uploaded (by Máté Szabó; author: Máté Szabó):

[mediawiki/core@master] output: Use associative arrays to store modules

https://gerrit.wikimedia.org/r/1120933

Change #1119496 abandoned by Máté Szabó:

[mediawiki/core@master] Add mediawiki.interface.helpers module to pages with user links

Reason:

Superseded because I4f70ff15becbc4991c4f1b0307a14d5354c79dc1 now does this automatically.

https://gerrit.wikimedia.org/r/1119496

Change #1119705 abandoned by Máté Szabó:

[mediawiki/extensions/CampaignEvents@master] Add mediawiki.interface.helpers module to pages with user links

Reason:

Superseded because I4f70ff15becbc4991c4f1b0307a14d5354c79dc1 now does this automatically.

https://gerrit.wikimedia.org/r/1119705

Change #1119706 abandoned by Máté Szabó:

[mediawiki/extensions/GlobalBlocking@master] Add mediawiki.interface.helpers module to pages with user links

Reason:

Superseded because I4f70ff15becbc4991c4f1b0307a14d5354c79dc1 now does this automatically.

https://gerrit.wikimedia.org/r/1119706

Change #1119701 abandoned by Máté Szabó:

[mediawiki/extensions/CheckUser@master] Add mediawiki.interface.helpers module to pages with user links

Reason:

Superseded because I4f70ff15becbc4991c4f1b0307a14d5354c79dc1 now does this automatically.

https://gerrit.wikimedia.org/r/1119701

Change #1119700 abandoned by Máté Szabó:

[mediawiki/extensions/AbuseFilter@master] Add mediawiki.interface.helpers module to pages with user links

Reason:

Superseded because I4f70ff15becbc4991c4f1b0307a14d5354c79dc1 now does this automatically.

https://gerrit.wikimedia.org/r/1119700

Change #1119702 abandoned by Máté Szabó:

[mediawiki/extensions/FlaggedRevs@master] Add mediawiki.interface.helpers module to pages with user links

Reason:

Superseded because I4f70ff15becbc4991c4f1b0307a14d5354c79dc1 now does this automatically.

https://gerrit.wikimedia.org/r/1119702

Change #1119741 merged by jenkins-bot:

[mediawiki/core@master] user: Implement batch user registration lookups

https://gerrit.wikimedia.org/r/1119741

Change #1119744 merged by jenkins-bot:

[mediawiki/extensions/CentralAuth@master] Enable skipped testFetchRegistrationBatch()

https://gerrit.wikimedia.org/r/1119744

Change #1121406 had a related patch set uploaded (by Máté Szabó; author: Máté Szabó):

[mediawiki/core@master] LinkBatch: Introduce addUser() helper

https://gerrit.wikimedia.org/r/1121406

Change #1118848 merged by jenkins-bot:

[mediawiki/core@master] user: Introduce TempUserDetailsLookup service

https://gerrit.wikimedia.org/r/1118848

Change #1121406 merged by jenkins-bot:

[mediawiki/core@master] LinkBatch: Introduce addUser() helper

https://gerrit.wikimedia.org/r/1121406

Change #1120933 merged by jenkins-bot:

[mediawiki/core@master] output: Use associative arrays to store modules

https://gerrit.wikimedia.org/r/1120933

Change #1118849 merged by jenkins-bot:

[mediawiki/core@master] linker: Render expired temporary account names differently

https://gerrit.wikimedia.org/r/1118849

Change #1123408 had a related patch set uploaded (by Máté Szabó; author: Máté Szabó):

[mediawiki/core@master] linker: Increase strikethrough width for expired temporary user links

https://gerrit.wikimedia.org/r/1123408

Change #1123415 had a related patch set uploaded (by Máté Szabó; author: Máté Szabó):

[mediawiki/extensions/AbuseFilter@master] Preload temporary account expiration status where needed

https://gerrit.wikimedia.org/r/1123415

Change #1120210 abandoned by Máté Szabó:

[mediawiki/extensions/AbuseFilter@master] Preload temporary account expiration status where needed

Reason:

Superseded by Ie900941faa621c13cbb54c77504b4ba47716425c

https://gerrit.wikimedia.org/r/1120210

Change #1123438 had a related patch set uploaded (by Máté Szabó; author: Máté Szabó):

[mediawiki/extensions/CheckUser@master] Preload temporary account expiration status where needed

https://gerrit.wikimedia.org/r/1123438

Test wiki created on Patch demo by SCardenas (WMF) using patch(es) linked to this task:
http://patchdemo.wmcloud.org/wikis/5cb5aa51f5/w/

Change #1123415 merged by jenkins-bot:

[mediawiki/extensions/AbuseFilter@master] Preload temporary account expiration status where needed

https://gerrit.wikimedia.org/r/1123415

Change #1123408 merged by jenkins-bot:

[mediawiki/core@master] linker: Increase strikethrough width for expired temporary user links

https://gerrit.wikimedia.org/r/1123408

Change #1120185 merged by jenkins-bot:

[mediawiki/core@master] Preload temporary account expiration status where needed

https://gerrit.wikimedia.org/r/1120185

Change #1123438 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@master] Preload temporary account expiration status where needed

https://gerrit.wikimedia.org/r/1123438

Change #1120204 merged by jenkins-bot:

[mediawiki/extensions/PageTriage@master] NewPagesFeed: Update styling for expired temporary account links

https://gerrit.wikimedia.org/r/1120204

QA Notes

  1. Ensure you have some expired temporary accounts in your local setup by running expireTemporaryAccounts.php with a sufficiently low expiry.
  2. Verify that these usernames are displayed according to the design spec (strikethrough and with tooltip) on pagers with user links. An exhaustive list would be overly long - one could check e.g. RecentChanges, BlockList, history pages, NewPages and logs.

Test wiki on Patch demo by SCardenas (WMF) using patch(es) linked to this task was deleted:

http://patchdemo.wmcloud.org/wikis/5cb5aa51f5/w/

Change #1129231 had a related patch set uploaded (by Máté Szabó; author: Máté Szabó):

[mediawiki/core@master] Update tooltip for expired temporary accounts

https://gerrit.wikimedia.org/r/1129231

Change #1129231 merged by jenkins-bot:

[mediawiki/core@master] Update tooltip for expired temporary accounts

https://gerrit.wikimedia.org/r/1129231

Djackson-ctr subscribed.

QA is completed, and the new code has been implemented...
I did discover a couple issues and have discussed this with Máté and we concluded that those issues can be resolved via Bug Reports ( I created 2 Bug Reports for those issues (T392190 and T392191), in the meantime this specific ticket can be marked as DONE (Expired Temporary Accounts will be displayed with a strikethrough and will also display the hover message Temporary account has expired).

image.png (250×1 px, 76 KB)

image.png (707×1 px, 64 KB)