Page MenuHomePhabricator

Make PHP 8.2 voting on development branch of Wikibase
Open, Needs TriagePublic

Event Timeline

Change #1013400 had a related patch set uploaded (by Jforrester; author: Jforrester):

[integration/config@master] Zuul: [Wikibase*] Disable PHP 8.2 testing for more Wikibase repos

https://gerrit.wikimedia.org/r/1013400

Change #1013400 merged by jenkins-bot:

[integration/config@master] Zuul: [Wikibase*] Disable PHP 8.2 testing for more Wikibase repos

https://gerrit.wikimedia.org/r/1013400

Mentioned in SAL (#wikimedia-releng) [2024-03-21T20:28:33Z] <James_F> Zuul: [Wikibase*] Disable PHP 8.2 testing for more Wikibase repos, for T360560

Change #1013574 had a related patch set uploaded (by Jforrester; author: Jforrester):

[integration/config@master] Zuul: [mediawiki/extensions/GeoData] Disable PHP 8.2 testing

https://gerrit.wikimedia.org/r/1013574

Change #1013574 merged by jenkins-bot:

[integration/config@master] Zuul: [mediawiki/extensions/GeoData] Disable PHP 8.2 testing

https://gerrit.wikimedia.org/r/1013574

Change #1013582 had a related patch set uploaded (by Jforrester; author: Jforrester):

[integration/config@master] Zuul: [mediawiki/extensions/CirrusSearch] Disable PHP 8.2 testing

https://gerrit.wikimedia.org/r/1013582

Change #1013582 merged by jenkins-bot:

[integration/config@master] Zuul: [mediawiki/extensions/CirrusSearch] Disable PHP 8.2 testing

https://gerrit.wikimedia.org/r/1013582

GrowthExperiments is affected and tests fails (see T360826)

Score is affected and tests fails

Change #1013973 had a related patch set uploaded (by Jforrester; author: Jforrester):

[integration/config@master] Zuul: [mediawiki/extensions/GrowthExperiments] Disable PHP 8.2 testing due to Wikibase

https://gerrit.wikimedia.org/r/1013973

Change #1013973 merged by jenkins-bot:

[integration/config@master] Zuul: [mediawiki/extensions/GrowthExperiments] Disable PHP 8.2 testing due to Wikibase

https://gerrit.wikimedia.org/r/1013973

Mentioned in SAL (#wikimedia-releng) [2024-03-25T11:44:08Z] <James_F> Zuul: [mediawiki/extensions/GrowthExperiments] Disable PHP 8.2 testing due to Wikibase for T360560

Change #1016745 had a related patch set uploaded (by Hashar; author: Lucas Werkmeister (WMDE)):

[integration/config@master] Zuul: [mediawiki/extensions/EntitySchema] Disable PHP 8.2 testing for now

https://gerrit.wikimedia.org/r/1016745

Change #1016746 had a related patch set uploaded (by Hashar; author: Lucas Werkmeister (WMDE)):

[integration/config@master] Zuul: [mediawiki/extensions/PropertySuggester] Disable PHP 8.2 testing for now

https://gerrit.wikimedia.org/r/1016746

Change #1016745 merged by jenkins-bot:

[integration/config@master] Zuul: [mediawiki/extensions/EntitySchema] Disable PHP 8.2 testing for now

https://gerrit.wikimedia.org/r/1016745

Change #1016746 merged by jenkins-bot:

[integration/config@master] Zuul: [mediawiki/extensions/PropertySuggester] Disable PHP 8.2 testing for now

https://gerrit.wikimedia.org/r/1016746

Change #1016762 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[integration/config@master] Zuul: [mediawiki/extensions/Score] Disable PHP 8.2 testing for now

https://gerrit.wikimedia.org/r/1016762

Change #1016762 merged by jenkins-bot:

[integration/config@master] Zuul: [mediawiki/extensions/Score] Disable PHP 8.2 testing for now

https://gerrit.wikimedia.org/r/1016762

Change #1016765 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[integration/config@master] Zuul: [mediawiki/extensions/WikimediaBadges] Disable PHP 8.2 testing for now

https://gerrit.wikimedia.org/r/1016765

Change #1016765 merged by jenkins-bot:

[integration/config@master] Zuul: [mediawiki/extensions/WikimediaBadges] Disable PHP 8.2 testing for now

https://gerrit.wikimedia.org/r/1016765

Change #1016788 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[integration/config@master] Zuul: Disable PHP 8.2 testing for more extensions

https://gerrit.wikimedia.org/r/1016788

Change #1016788 merged by jenkins-bot:

[integration/config@master] Zuul: Disable PHP 8.2 testing for more extensions

https://gerrit.wikimedia.org/r/1016788

There are a bunch of additional failures in this build (for this change) (from this video); some of them look like they don’t really require separate tasks, so let’s attach some fixes directly here, I think.

Change #1020247 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/Wikibase@master] Remove unused dynamic property in WikibaseApiTestCase

https://gerrit.wikimedia.org/r/1020247

Change #1020254 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/Wikibase@master] Declare dynamic properties in ItemPropertyIdHtmlLinkFormatterTest

https://gerrit.wikimedia.org/r/1020254

Change #1020255 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/Wikibase@master] Don’t use dynamic property in ActionTestCase

https://gerrit.wikimedia.org/r/1020255

Change #1020247 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Remove unused dynamic property in WikibaseApiTestCase

https://gerrit.wikimedia.org/r/1020247

It looks like the above three changes are enough to make PHP 8.2 and 8.3 pass \o/

That said, I think we should hold off enabling 8.2/3 CI in Wikibase until next week (probably even the end of next week), in case the train uncovers any issues with T324202 and we have to revert some of those changes.

It looks like the above three changes are enough to make PHP 8.2 and 8.3 pass \o/

Excellent, thank you.

That said, I think we should hold off enabling 8.2/3 CI in Wikibase until next week (probably even the end of next week), in case the train uncovers any issues with T324202 and we have to revert some of those changes.

Definitely.

Change #1020254 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Declare dynamic properties in ItemPropertyIdHtmlLinkFormatterTest

https://gerrit.wikimedia.org/r/1020254

Change #1020255 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Don’t use dynamic property in ActionTestCase

https://gerrit.wikimedia.org/r/1020255

Change #1023401 had a related patch set uploaded (by Jforrester; author: Jforrester):

[integration/config@master] Zuul: Re-apply PHP 8.2 CI to Wikibase-based code

https://gerrit.wikimedia.org/r/1023401