Page MenuHomePhabricator
Create Task
Maniphest T360560

Make PHP 8.2 voting on development branch of Wikibase
Closed, ResolvedPublic
Actions

Details

Show related patches Customize query in gerrit

Related Objects
Search...

Event Timeline

Jdforrester-WMF created this task.Mar 20 2024, 6:25 PM
Jdforrester-WMF added subtasks: T324202: Remove use of utf8_encode and utf8_decode in Wikibase, T353161: [CLIENT] Creation of dynamic property MediaWiki\Title\Title::$wikibasePushedDeleteToRepo is deprecated.
Jdforrester-WMF moved this task from Backlog to Wikimedia production on the PHP 8.2 support board.
Maintenance_bot added a project: Wikidata.Mar 20 2024, 6:29 PM
Restricted Application added a project: wmde-wikidata-tech. · View Herald TranscriptMar 20 2024, 6:29 PM
gerritbot added a comment.Mar 21 2024, 8:16 PM

Change #1013400 had a related patch set uploaded (by Jforrester; author: Jforrester):

[integration/config@master] Zuul: [Wikibase*] Disable PHP 8.2 testing for more Wikibase repos

https://gerrit.wikimedia.org/r/1013400

gerritbot added a project: Patch-For-Review.Mar 21 2024, 8:16 PM
gerritbot added a comment.Mar 21 2024, 8:27 PM

Change #1013400 merged by jenkins-bot:

[integration/config@master] Zuul: [Wikibase*] Disable PHP 8.2 testing for more Wikibase repos

https://gerrit.wikimedia.org/r/1013400

Stashbot added a comment.Mar 21 2024, 8:28 PM

Mentioned in SAL (#wikimedia-releng) [2024-03-21T20:28:33Z] <James_F> Zuul: [Wikibase*] Disable PHP 8.2 testing for more Wikibase repos, for T360560

gerritbot added a comment.Mar 22 2024, 3:54 PM

Change #1013574 had a related patch set uploaded (by Jforrester; author: Jforrester):

[integration/config@master] Zuul: [mediawiki/extensions/GeoData] Disable PHP 8.2 testing

https://gerrit.wikimedia.org/r/1013574

gerritbot added a comment.Mar 22 2024, 4:09 PM

Change #1013574 merged by jenkins-bot:

[integration/config@master] Zuul: [mediawiki/extensions/GeoData] Disable PHP 8.2 testing

https://gerrit.wikimedia.org/r/1013574

gerritbot added a comment.Mar 22 2024, 5:05 PM

Change #1013582 had a related patch set uploaded (by Jforrester; author: Jforrester):

[integration/config@master] Zuul: [mediawiki/extensions/CirrusSearch] Disable PHP 8.2 testing

https://gerrit.wikimedia.org/r/1013582

gerritbot added a comment.Mar 22 2024, 5:08 PM

Change #1013582 merged by jenkins-bot:

[integration/config@master] Zuul: [mediawiki/extensions/CirrusSearch] Disable PHP 8.2 testing

https://gerrit.wikimedia.org/r/1013582

Umherirrender mentioned this in T360826: Wikibase blocks merges to GrowthExperiments.Mar 22 2024, 11:39 PM
Umherirrender subscribed.Mar 23 2024, 12:58 AM

GrowthExperiments is affected and tests fails (see T360826)

Score is affected and tests fails

gerritbot added a comment.Mar 25 2024, 11:27 AM

Change #1013973 had a related patch set uploaded (by Jforrester; author: Jforrester):

[integration/config@master] Zuul: [mediawiki/extensions/GrowthExperiments] Disable PHP 8.2 testing due to Wikibase

https://gerrit.wikimedia.org/r/1013973

gerritbot added a comment.Mar 25 2024, 11:35 AM

Change #1013973 merged by jenkins-bot:

[integration/config@master] Zuul: [mediawiki/extensions/GrowthExperiments] Disable PHP 8.2 testing due to Wikibase

https://gerrit.wikimedia.org/r/1013973

Stashbot added a comment.Mar 25 2024, 11:44 AM

Mentioned in SAL (#wikimedia-releng) [2024-03-25T11:44:08Z] <James_F> Zuul: [mediawiki/extensions/GrowthExperiments] Disable PHP 8.2 testing due to Wikibase for T360560

Umherirrender added a comment.Mar 25 2024, 6:33 PM

Also seen on ImageSuggestions - https://gerrit.wikimedia.org/r/c/mediawiki/extensions/ImageSuggestions/+/1013222 (via CirrusSearch => WikibaseCirrusSearch => Wikibase)
And Score - https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Score/+/1013651 (directly Wikibase dependency)

Lucas_Werkmeister_WMDE moved this task from Incoming to Radar on the wmde-wikidata-tech board.Mar 26 2024, 10:51 AM
gerritbot added a comment.Wed, Apr 3, 11:28 AM

Change #1016745 had a related patch set uploaded (by Hashar; author: Lucas Werkmeister (WMDE)):

[integration/config@master] Zuul: [mediawiki/extensions/EntitySchema] Disable PHP 8.2 testing for now

https://gerrit.wikimedia.org/r/1016745

gerritbot added a comment.Wed, Apr 3, 11:28 AM

Change #1016746 had a related patch set uploaded (by Hashar; author: Lucas Werkmeister (WMDE)):

[integration/config@master] Zuul: [mediawiki/extensions/PropertySuggester] Disable PHP 8.2 testing for now

https://gerrit.wikimedia.org/r/1016746

gerritbot added a comment.Wed, Apr 3, 11:30 AM

Change #1016745 merged by jenkins-bot:

[integration/config@master] Zuul: [mediawiki/extensions/EntitySchema] Disable PHP 8.2 testing for now

https://gerrit.wikimedia.org/r/1016745

gerritbot added a comment.Wed, Apr 3, 11:32 AM

Change #1016746 merged by jenkins-bot:

[integration/config@master] Zuul: [mediawiki/extensions/PropertySuggester] Disable PHP 8.2 testing for now

https://gerrit.wikimedia.org/r/1016746

gerritbot added a comment.Wed, Apr 3, 12:43 PM

Change #1016762 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[integration/config@master] Zuul: [mediawiki/extensions/Score] Disable PHP 8.2 testing for now

https://gerrit.wikimedia.org/r/1016762

• karapayneWMDE subscribed.Wed, Apr 3, 12:44 PM
gerritbot added a comment.Wed, Apr 3, 1:02 PM

Change #1016762 merged by jenkins-bot:

[integration/config@master] Zuul: [mediawiki/extensions/Score] Disable PHP 8.2 testing for now

https://gerrit.wikimedia.org/r/1016762

gerritbot added a comment.Wed, Apr 3, 1:04 PM

Change #1016765 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[integration/config@master] Zuul: [mediawiki/extensions/WikimediaBadges] Disable PHP 8.2 testing for now

https://gerrit.wikimedia.org/r/1016765

gerritbot added a comment.Wed, Apr 3, 1:07 PM

Change #1016765 merged by jenkins-bot:

[integration/config@master] Zuul: [mediawiki/extensions/WikimediaBadges] Disable PHP 8.2 testing for now

https://gerrit.wikimedia.org/r/1016765

gerritbot added a comment.Wed, Apr 3, 1:18 PM

Change #1016788 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[integration/config@master] Zuul: Disable PHP 8.2 testing for more extensions

https://gerrit.wikimedia.org/r/1016788

gerritbot added a comment.Wed, Apr 3, 1:24 PM

Change #1016788 merged by jenkins-bot:

[integration/config@master] Zuul: Disable PHP 8.2 testing for more extensions

https://gerrit.wikimedia.org/r/1016788

Umherirrender removed a project: Patch-For-Review.Wed, Apr 3, 5:36 PM
Umherirrender unsubscribed.
Umherirrender mentioned this in T360709: Make PHP 8.2 voting on development (master) branch of Math extension.Sat, Apr 6, 10:52 AM
Lucas_Werkmeister_WMDE added a project: Wikidata Dev Team (Wikidata.org Slice).Tue, Apr 16, 1:53 PM
Lucas_Werkmeister_WMDE subscribed.

There are a bunch of additional failures in this build (for this change) (from this video); some of them look like they don’t really require separate tasks, so let’s attach some fixes directly here, I think.

gerritbot added a comment.Tue, Apr 16, 2:12 PM

Change #1020247 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/Wikibase@master] Remove unused dynamic property in WikibaseApiTestCase

https://gerrit.wikimedia.org/r/1020247

gerritbot added a project: Patch-For-Review.Tue, Apr 16, 2:12 PM
Maintenance_bot moved this task from Radar to Ongoing on the wmde-wikidata-tech board.Tue, Apr 16, 2:29 PM
gerritbot added a comment.Tue, Apr 16, 2:31 PM

Change #1020254 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/Wikibase@master] Declare dynamic properties in ItemPropertyIdHtmlLinkFormatterTest

https://gerrit.wikimedia.org/r/1020254

gerritbot added a comment.Tue, Apr 16, 2:31 PM

Change #1020255 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/Wikibase@master] Don’t use dynamic property in ActionTestCase

https://gerrit.wikimedia.org/r/1020255

gerritbot added a comment.Tue, Apr 16, 2:57 PM

Change #1020247 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Remove unused dynamic property in WikibaseApiTestCase

https://gerrit.wikimedia.org/r/1020247

ReleaseTaggerBot added a project: MW-1.43-notes (1.43.0-wmf.2; 2024-04-23).Tue, Apr 16, 3:00 PM
Lucas_Werkmeister_WMDE moved this task from In Task Breakdown to Ready for Peer Review on the Wikidata Dev Team (Wikidata.org Slice) board.Tue, Apr 16, 4:14 PM

It looks like the above three changes are enough to make PHP 8.2 and 8.3 pass \o/

That said, I think we should hold off enabling 8.2/3 CI in Wikibase until next week (probably even the end of next week), in case the train uncovers any issues with T324202 and we have to revert some of those changes.

Jdforrester-WMF added a comment.Tue, Apr 16, 6:09 PM
In T360560#9719240, @Lucas_Werkmeister_WMDE wrote:

It looks like the above three changes are enough to make PHP 8.2 and 8.3 pass \o/

Excellent, thank you.

That said, I think we should hold off enabling 8.2/3 CI in Wikibase until next week (probably even the end of next week), in case the train uncovers any issues with T324202 and we have to revert some of those changes.

Definitely.

gerritbot added a comment.Wed, Apr 17, 1:15 PM

Change #1020254 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Declare dynamic properties in ItemPropertyIdHtmlLinkFormatterTest

https://gerrit.wikimedia.org/r/1020254

gerritbot added a comment.Wed, Apr 17, 1:22 PM

Change #1020255 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Don’t use dynamic property in ActionTestCase

https://gerrit.wikimedia.org/r/1020255

Lucas_Werkmeister_WMDE moved this task from Ready for Peer Review to Waiting for Deployment Window on the Wikidata Dev Team (Wikidata.org Slice) board.Wed, Apr 17, 1:26 PM
gerritbot added a comment.Tue, Apr 23, 11:05 AM

Change #1023401 had a related patch set uploaded (by Jforrester; author: Jforrester):

[integration/config@master] Zuul: Re-apply PHP 8.2 CI to Wikibase-based code

https://gerrit.wikimedia.org/r/1023401

Lucas_Werkmeister_WMDE added a comment.Thu, Apr 25, 12:59 PM

Per T324202#9744647, I think we can go ahead with this now. (The train hasn’t reached group2 yet, but I feel confident enough after seeing no problems on group0 and group1. And tomorrow I’ll be busy with non-tech things all day, so I want to give the green light today ^^)

gerritbot added a comment.Fri, Apr 26, 6:17 PM

Change #1023401 merged by jenkins-bot:

[integration/config@master] Zuul: Re-apply PHP 8.2 CI to Wikibase-based code

https://gerrit.wikimedia.org/r/1023401

Stashbot added a comment.Fri, Apr 26, 6:18 PM

Mentioned in SAL (#wikimedia-releng) [2024-04-26T18:18:26Z] <James_F> Zuul: Re-apply PHP 8.2 CI to Wikibase-based code for T360560 T324202 T353161

Stashbot mentioned this in T324202: Remove use of utf8_encode and utf8_decode in Wikibase.Fri, Apr 26, 6:18 PM
Stashbot mentioned this in T353161: [CLIENT] Creation of dynamic property MediaWiki\Title\Title::$wikibasePushedDeleteToRepo is deprecated.
Jdforrester-WMF closed this task as Resolved.Fri, Apr 26, 6:18 PM
Jdforrester-WMF claimed this task.
Jdforrester-WMF closed subtask T324202: Remove use of utf8_encode and utf8_decode in Wikibase as Resolved.
Jdforrester-WMF closed subtask T353161: [CLIENT] Creation of dynamic property MediaWiki\Title\Title::$wikibasePushedDeleteToRepo is deprecated as Resolved.
Maintenance_bot removed a project: Patch-For-Review.Fri, Apr 26, 6:30 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL