wikibasePushedDeleteToRepo

That reminds me of T268135 – it looks like it’s not quite the same thing (that task was about a wikibasePushedMoveToRepo dynamic property), but I suspect it’s related, and it’s possible the dynamic property can just be removed entirely. (But this needs a bit more investigation. I just saw this task and wanted to quickly leave a pointer to the other one I remembered.)

This dynamic property is causing spurious failures in phan as well, when phan randomly "gets smart enough" to notice that the Title class doesn't actually have a property named wikibasePushedDeleteToRepo. See https://integration.wikimedia.org/ci/job/mwext-php74-phan-docker/96606/console for example.

Change 998818 had a related patch set uploaded (by Jakob; author: Jakob):

[mediawiki/extensions/Wikibase@master] Suppress undeclared property access in `isset()`

https://gerrit.wikimedia.org/r/998818

Change 998818 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Suppress undeclared property access in `isset()`

https://gerrit.wikimedia.org/r/998818

In T353161#9523476, @cscott wrote:

This dynamic property is causing spurious failures in phan as well, when phan randomly "gets smart enough" to notice that the Title class doesn't actually have a property named wikibasePushedDeleteToRepo. See https://integration.wikimedia.org/ci/job/mwext-php74-phan-docker/96606/console for example.

With the remove of the DeprecationHelper trait in 7fc8d800b78e4d3d49cdadc686310485607072fe there is no Title::__set or Title::__get and phan is now strict about the undeclared properties resulting in this report (Before phan could not infer the result of set/get to report every undeclared property directly).
It should not be randomly, that mostly seen in the context of taint-check, where the order of class loading can impact the result.

Would it be possible to expedite this fix, please? It's blocking CI (and the MediaWiki support for) PHP 8.2 generally.

Prio Notes:

Not until production moves to PHP 8.2, which will take quite some time (the next target after mw-on-k8s is 8.1)

I don't believe this is true; my understanding is that we plan to move to 8.1 and then immediately to 8.3.

The situation looks indeed fairly similar to T268135 (I recommend reading that task description first):

• We have again two hook handlers communicating with one another through the dynamic property; UpdateRepoHookHandler::onArticleDeleteComplete() records whether the job queue insertion was successful, and DeletePageNoticeCreator::getMessage() determines whether “We're going to update the item using the repo job queue \o/” or “The user has to update the item per hand for some reason” (quoting from the code comments) and shows the appropriate message.

• The two hooks (ArticleDeleteComplete and ArticleDeleteAfterSuccess) still run in the order Wikibase expects (unlike the other task, they weren’t swapped around); but at some point, they started pointing to different Title instances. The Title seen by the first hook has its mArticleId, mLatestId, mContentModel and mLength initialized; in the Title seen by the second hook, they’re uninitialized. This might have been introduced by Clone WikiPage before delete in August 2016, but I’m not sure.

• The wikibase-after-page-delete message was also changed (in 2017) from “You should also remove the link…” to “Link … should have been removed … we ask that you check this has occurred”.

• (There’s nothing corresponding to the fourth bullet point.)

So, again, the “successful” version of the message (wikibase-after-page-delete-queued) has been unreachable for many years. As in T268135, I don’t think we need to bother resurrecting this communication between the two hook handlers to a working state – let’s just use the other message (wikibase-after-page-delete), which was already rephrased to cover both possible situations.

Change #1017310 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/Wikibase@master] Drop wikibase-after-page-delete-queued message

https://gerrit.wikimedia.org/r/1017310

Change #1017310 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Drop wikibase-after-page-delete-queued message

https://gerrit.wikimedia.org/r/1017310

Change #1023151 had a related patch set uploaded (by Jforrester; author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/Wikibase@REL1_42] Drop wikibase-after-page-delete-queued message

https://gerrit.wikimedia.org/r/1023151

Change #1023401 had a related patch set uploaded (by Jforrester; author: Jforrester):

[integration/config@master] Zuul: Re-apply PHP 8.2 CI to Wikibase-based code

https://gerrit.wikimedia.org/r/1023401

Change #1023151 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@REL1_42] Drop wikibase-after-page-delete-queued message

https://gerrit.wikimedia.org/r/1023151

Change #1023401 merged by jenkins-bot:

[integration/config@master] Zuul: Re-apply PHP 8.2 CI to Wikibase-based code

https://gerrit.wikimedia.org/r/1023401

Mentioned in SAL (#wikimedia-releng) [2024-04-26T18:18:26Z] <James_F> Zuul: Re-apply PHP 8.2 CI to Wikibase-based code for T360560 T324202 T353161